From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 6781@debbugs.gnu.org, Ken Raeburn <raeburn@raeburn.org>,
Leo <sdl.web@gmail.com>,
emacs-devel@gnu.org
Subject: bug#6781: emacs server with X11 build on OSX
Date: Fri, 24 Sep 2010 21:38:28 +0200 [thread overview]
Message-ID: <AANLkTik8qDf9NOb7epns3QLNqqJ1BzcqhpP9fkqiWhzS__26076.5459425331$1285357305$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <jwvr5i6ioiv.fsf-monnier+emacs@gnu.org>
On Tue, Aug 10, 2010 at 15:31, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> But, all in all, I agree that if `localhost' can be interpreted as
>> variably as Ken has pointed out, we shouldn't use it.
>
> Could you make the corresponding change in `trunk'?
OK to this change, then?
Juanma
2010-09-24 Juanma Barranquero <lekktu@gmail.com>
* server.el (server-start): Revert part of 2010-08-08 change. Using
address 127.0.0.1 for local host is now done in Fmake_network_process.
2010-09-24 Juanma Barranquero <lekktu@gmail.com>
* process.c (Fmake_network_process): When arg :host is 'local,
use address 127.0.0.1, not name "localhost". (Bug#6781)
=== modified file 'lisp/server.el'
--- lisp/server.el 2010-08-26 13:46:19 +0000
+++ lisp/server.el 2010-09-24 19:16:01 +0000
@@ -565,7 +565,7 @@
(if server-use-tcp
(list :family 'ipv4 ;; We're not ready for IPv6 yet
:service t
- :host (or server-host "127.0.0.1") ;; See bug#6781
+ :host (or server-host 'local)
:plist '(:authenticated nil))
(list :family 'local
:service server-file
=== modified file 'src/process.c'
--- src/process.c 2010-09-17 15:47:49 +0000
+++ src/process.c 2010-09-24 19:31:13 +0000
@@ -3170,7 +3170,9 @@
if (!NILP (host))
{
if (EQ (host, Qlocal))
- host = build_string ("localhost");
+ /* Depending on setup, "localhost" may map to different IPv4 and/or
+ IPv6 addresses, so it's better to be explicit. (Bug#6781) */
+ host = build_string ("127.0.0.1");
CHECK_STRING (host);
}
next prev parent reply other threads:[~2010-09-24 19:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1ocdmuoqf.fsf@cam.ac.uk>
[not found] ` <AANLkTin+Nok-zrMg46+oQoFGVd3z2xxqRR8EN3ZiresL@mail.gmail.com>
[not found] ` <m162ztuhyf.fsf@cam.ac.uk>
2010-08-02 20:22 ` emacs server with X11 build on OSX Juanma Barranquero
2010-08-02 22:16 ` bug#6781: " Leo
2010-08-03 2:12 ` Ken Raeburn
2010-08-03 2:47 ` bug#6781: " Juanma Barranquero
[not found] ` <AANLkTi=7OkJNWML-KjuPJ8u1tE=iiUmAjtR_jMzGd-4y@mail.gmail.com>
2010-08-03 5:01 ` Leo
[not found] ` <m1eiegs30i.fsf@cam.ac.uk>
2010-08-03 12:02 ` Juanma Barranquero
[not found] ` <AANLkTikYDk_Cv-abMXLP3Zkpj9YKR77s4_56LLnZtBV1@mail.gmail.com>
2010-08-03 12:44 ` Andreas Schwab
[not found] ` <m3vd7rkgqk.fsf@hase.home>
2010-08-03 12:48 ` Juanma Barranquero
[not found] ` <AANLkTin1Cq3LfeXqKaz3v4ixi7=JkpwDGFUH92mJZQu4@mail.gmail.com>
2010-08-03 13:01 ` Andreas Schwab
[not found] ` <m3r5ifkfz8.fsf@hase.home>
2010-08-03 13:03 ` Juanma Barranquero
[not found] ` <AANLkTi=KTmMPqhueCm7ZViyDc3h1tV5nixqcNsWxpRUV@mail.gmail.com>
2010-08-04 0:52 ` YAMAMOTO Mitsuharu
[not found] ` <wl62zrb3nc.wl%mituharu@math.s.chiba-u.ac.jp>
2010-08-04 15:25 ` Chong Yidong
[not found] ` <87k4o6wgam.fsf@stupidchicken.com>
2010-09-25 3:57 ` YAMAMOTO Mitsuharu
[not found] ` <wlzkv68ogs.wl%mituharu@math.s.chiba-u.ac.jp>
2010-09-27 12:12 ` Juanma Barranquero
2010-08-04 13:18 ` Stefan Monnier
2010-08-05 9:02 ` Juanma Barranquero
[not found] ` <AANLkTikdFvn_jUb96hnCYri_hHKttboL+sOW5etgiyFD@mail.gmail.com>
2010-08-09 11:24 ` Stefan Monnier
[not found] ` <jwveie881yq.fsf-monnier+emacs@gnu.org>
2010-08-09 17:08 ` Juanma Barranquero
[not found] ` <AANLkTikh7T=KV89H4z9XQL1+SmD4B8Fo2OT0Am4sATWC@mail.gmail.com>
2010-08-10 13:31 ` Stefan Monnier
[not found] ` <jwvr5i6ioiv.fsf-monnier+emacs@gnu.org>
2010-08-10 18:31 ` Juanma Barranquero
2010-09-24 19:38 ` Juanma Barranquero [this message]
[not found] ` <AANLkTik8qDf9NOb7epns3QLNqqJ1BzcqhpP9fkqiWhzS@mail.gmail.com>
2010-09-24 22:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTik8qDf9NOb7epns3QLNqqJ1BzcqhpP9fkqiWhzS__26076.5459425331$1285357305$gmane$org@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=6781@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=raeburn@raeburn.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).