From: Lennart Borgman <lennart.borgman@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Chong Yidong <cyd@stupidchicken.com>,
7726@debbugs.gnu.org,
Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Mon, 24 Jan 2011 21:09:29 +0100 [thread overview]
Message-ID: <AANLkTik2Nzj3-HoSZr0C=_=6bvkT-qkCLem++Ytae+Lk@mail.gmail.com> (raw)
In-Reply-To: <jwvd3nmp9l7.fsf-monnier+emacs@gnu.org>
On Mon, Jan 24, 2011 at 5:12 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>>>>>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>>>>>> buffer where the destination line is in a hidden outline then the
>>>>>> outline will not be revealed until after next command.
>>>>> also, goto-line is unable to reach line in an outline based buffer.
>>>>> See in anything and ioccur, it is fixed for org-mode and
>>>>> outline-minor-mode.
>>>>> Is there other modes based on outline to handle?
>>>> Anyone have a test case?
>>> I think the problem is that reveal-mode runs from post-command-hook and
>>> reveals what's in the buffer that's current when post-command-hook is
>>> run, whereas in the above cases, the buffer that needs revealing is not
>>> current at that point.
>>> That's one of the cases where we could use something like
>>> a "pre-redisplay-hook".
>> Isn't it more like post-post-command-hook?
>
> No I really meant pre-redisplay-hook. I don't see why
> post-post-command-hook would have anything to do with this problem.
> E.g. I think a case that needs to work is when you're in the *compile*
> buffer and select one entry to display the source but while staying in
> the *compile* buffer: the current buffer before and after the command is
> *compile*, so no amount of post/pre-command-hooks can tell you that some
> other buffer needs revealing.
Oh, I see.
And haven't we been discussing before that such a hook maybe could be
useful for cases where we now are using
window-configuration-change-hook?
prev parent reply other threads:[~2011-01-24 20:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 12:54 bug#7726: reveal-mode bypassed by compile-goto-error Lennart Borgman
2010-12-24 14:40 ` Thierry Volpiatto
2011-01-22 23:47 ` Chong Yidong
2011-01-23 2:00 ` Lennart Borgman
2011-01-23 7:19 ` Thierry Volpiatto
2011-01-24 0:50 ` Stefan Monnier
2011-01-24 1:00 ` Lennart Borgman
2011-01-24 16:12 ` Stefan Monnier
2011-01-24 20:09 ` Lennart Borgman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTik2Nzj3-HoSZr0C=_=6bvkT-qkCLem++Ytae+Lk@mail.gmail.com' \
--to=lennart.borgman@gmail.com \
--cc=7726@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=monnier@iro.umontreal.ca \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).