From: Fran Litterio <flitterio@gmail.com>
To: 7266@debbugs.gnu.org
Subject: bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and completion-cycle-threshold is nil
Date: Fri, 22 Oct 2010 11:03:44 -0400 [thread overview]
Message-ID: <AANLkTi=fDBJF8Hx-H1aKc9She5L0D6eiY7Le9+uV40wZ@mail.gmail.com> (raw)
To reproduce the bug do this:
1. Launch "emacs -q".
2. Type: ESC ESC : (icomplete-mode 1) RET C-h v mini TAB TAB
Notice that minibuffer-complete (which is bound to TAB at this point)
is cycling through the completion choices instead of popping up a
window to display the completion choices. This bug is caused code in
lisp/minibuffer.el that does not check that the value of
completion-cycle-threshold is not nil before deciding to cycle
completions. This patch (to the Bazaar sources) fixes the bug:
--- lisp/minibuffer.el.orig 2010-10-21 17:55:46.380857900 -0400
+++ lisp/minibuffer.el 2010-10-22 10:29:29.188417500 -0400
@@ -607,7 +607,8 @@
(completion-all-sorted-completions))))
(setq completion-all-sorted-completions nil)
(cond
- ((and (not (ignore-errors
+ ((and completion-cycle-threshold ;; Never cycle if
completion-cycle-threshold is nil.
+ (not (ignore-errors
;; This signal an (intended) error if comps is too
;; short or if completion-cycle-threshold is t.
(consp (nthcdr completion-cycle-threshold comps))))
@@ -664,7 +665,8 @@
(scroll-other-window))
nil)))
;; If we're cycling, keep on cycling.
- (completion-all-sorted-completions
+ ((and completion-cycle-threshold ;; Never cycle if
completion-cycle-threshold is nil.
+ completion-all-sorted-completions)
(minibuffer-force-complete)
t)
(t (case (completion--do-completion)
next reply other threads:[~2010-10-22 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 15:03 Fran Litterio [this message]
2010-10-28 2:23 ` bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and completion-cycle-threshold is nil Stefan Monnier
2010-10-28 21:40 ` Fran Litterio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=fDBJF8Hx-H1aKc9She5L0D6eiY7Le9+uV40wZ@mail.gmail.com' \
--to=flitterio@gmail.com \
--cc=7266@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).