From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.bugs Subject: bug#7534: 24.0.50; G-g within Isearch regexp mode Date: Mon, 6 Dec 2010 11:41:32 +0100 Message-ID: References: <878w0724dn.fsf@mail.jurta.org> <87oc8zhl1e.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1291632347 5599 80.91.229.12 (6 Dec 2010 10:45:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Dec 2010 10:45:47 +0000 (UTC) Cc: 7534@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 06 11:45:43 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PPYZg-0007YX-QM for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Dec 2010 11:45:41 +0100 Original-Received: from localhost ([127.0.0.1]:60452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPYZg-0006Fr-71 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Dec 2010 05:45:40 -0500 Original-Received: from [140.186.70.92] (port=48310 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPYZU-0006EW-Vs for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2010 05:45:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPYZT-0002MA-MA for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2010 05:45:28 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPYZT-0002M5-KJ for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2010 05:45:27 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PPYQM-0001qp-1M; Mon, 06 Dec 2010 05:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dani Moncayo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2010 10:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7534-submit@debbugs.gnu.org id=B7534.12916317427087 (code B ref 7534); Mon, 06 Dec 2010 10:36:01 +0000 Original-Received: (at 7534) by debbugs.gnu.org; 6 Dec 2010 10:35:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPYQ2-0001qG-Hj for submit@debbugs.gnu.org; Mon, 06 Dec 2010 05:35:42 -0500 Original-Received: from mail-gx0-f170.google.com ([209.85.161.170]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPYQ0-0001q4-Q3 for 7534@debbugs.gnu.org; Mon, 06 Dec 2010 05:35:41 -0500 Original-Received: by gxk20 with SMTP id 20so7084541gxk.29 for <7534@debbugs.gnu.org>; Mon, 06 Dec 2010 02:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=xJhTBBKs5yons23OWdPm1ak3Phd5+u2HAf07BQORwcc=; b=myLZ7AQIN1BKmDUlOz/OVDSRT09RAXAhY+rvU7c4iu/QUwv/0XFBtDxvjYFGnlR7Kv Syiz3vQE9N38qr1adlpUncim03bjs5UsENthe4rK+sB3nYGV7MQi/w5YMqTA8KFYmmN+ VRtkNV/5dICLZnnrIOg94Wp/GwHw7hSAG+IfA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=giBXFRQ66COHz6jErP92yoHmUS+WrwmyaFkX9EOeo/Tq21zORkRYmj5bzc0oVO4TDB w7CeLouNzgqjO1qSrcK/F3Plcx4ZYcuX1IUextngrmF4IAYyhJ6EdVplByYZazdinocj QA++DVczN/no7Szq2c3bhI086OPM2SP6D5XnU= Original-Received: by 10.91.199.13 with SMTP id b13mr340297agq.94.1291632092437; Mon, 06 Dec 2010 02:41:32 -0800 (PST) Original-Received: by 10.90.227.16 with HTTP; Mon, 6 Dec 2010 02:41:32 -0800 (PST) In-Reply-To: <87oc8zhl1e.fsf@mail.jurta.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 06 Dec 2010 05:36:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42204 Archived-At: On Mon, Dec 6, 2010 at 00:11, Juri Linkov wrote: >> So, IMO, the main principle for C-g (within Isearch mode) should be: >> * if there is unmatched and/or incomplete input --> Delete it. >> * Otherwise --> Exit Isearch mode. > > Please try the following patch. =A0Does it provide the behavior > you are asking for? > It does. Thank you. PS: The patch bellow is like your's, but it also updates the comment accordingly. =3D=3D=3D modified file 'lisp/isearch.el' --- lisp/isearch.el 2010-10-16 14:11:06.000000000 +0200 +++ lisp/isearch.el 2010-12-06 11:27:33.000000000 +0100 @@ -1244,9 +1244,9 @@ (interactive) ;; (ding) signal instead below, if quitting (discard-input) - (if isearch-success - ;; If search is successful, move back to starting point - ;; and really do quit. + (if (and isearch-success (not isearch-error)) + ;; If search is successful and there is no incomplete regexp, + ;; move back to starting point and really do quit. (progn (setq isearch-success nil) (isearch-cancel)) --=20 Dani Moncayo