From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#7190: Crash in menus on w32 Date: Wed, 13 Oct 2010 16:43:55 +0200 Message-ID: References: <4CB591BD.4060804@gmx.de> <4CB5BC32.1030008@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1286982964 17380 80.91.229.12 (13 Oct 2010 15:16:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Oct 2010 15:16:04 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: grischka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 13 17:16:03 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P633c-0006uA-5N for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Oct 2010 17:15:58 +0200 Original-Received: from localhost ([127.0.0.1]:60181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P633a-0008Em-9p for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Oct 2010 11:15:54 -0400 Original-Received: from [140.186.70.92] (port=54838 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6303-0005ra-Kh for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 11:12:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6301-0008Cz-R0 for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 11:12:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6301-0008Cv-Or for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 11:12:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P62Vq-00043o-9D; Wed, 13 Oct 2010 10:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Oct 2010 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7190 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.128698085215600 (code B ref -1); Wed, 13 Oct 2010 14:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 14:40:52 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P62Vf-00043Z-84 for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:40:51 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P62Vc-00043R-Vh for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:40:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P62Z0-0002Bl-FH for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:44:19 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:47034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P62Z0-0002Bh-Cy for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:44:18 -0400 Original-Received: from [140.186.70.92] (port=38309 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P62Yz-0001Sw-Ax for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:44:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P62Yy-0002B3-8C for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:44:17 -0400 Original-Received: from mail-qy0-f176.google.com ([209.85.216.176]:34444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P62Yy-0002Ay-4l for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:44:16 -0400 Original-Received: by qyk29 with SMTP id 29so7308133qyk.0 for ; Wed, 13 Oct 2010 07:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=xbHWtL0A/HGidizfIkbNDhWbV+nVaLPYMgOlyakjGw8=; b=HZKT/mRhbGBegtKpR1Ko3FGgPy8R158WEYLeWj5zYSrvBcNhnAgVn3Ru/Vp4GDFKHf kPMzMritWNyUkrfBvcO/1SJ7/k22tmmJNuO/GPzNk8AQQNqTz2aJdlTIHOAE7+hb21jZ M4Vx3frYaTiWGueY/USAw3gqo8RoQN/Qe9pxw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=QRvXfzcgOm7a5bz/Wv3gq+bVvuvjUjCw9sgdfm8j+5KAV+JLP2kO89ckyLqJShXOkH fgahPLBMzdyhDMv++ZjBtcf87zohi12pTyVe9dW5D8EIv5hyHrcMBRvRYA3EUywMEB2r Wu0GKU2XLCbgYkharNrCUxzq74vcbG7WLZTeE= Original-Received: by 10.229.241.12 with SMTP id lc12mr7604677qcb.178.1286981055362; Wed, 13 Oct 2010 07:44:15 -0700 (PDT) Original-Received: by 10.229.220.195 with HTTP; Wed, 13 Oct 2010 07:43:55 -0700 (PDT) In-Reply-To: <4CB5BC32.1030008@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 13 Oct 2010 10:41:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40857 Archived-At: On Wed, Oct 13, 2010 at 4:03 PM, grischka wrote: > Lennart Borgman wrote: >> >> On Wed, Oct 13, 2010 at 1:02 PM, grischka wrote: >>>> >>>> I assume that their is either a logical problem with the code inside >>>> Emacs or a bad assumption on how menu callbacks are actually run. >>> >>> Is there a difference between logical problem and bad assumption? >> >> Yes. The code could be correct under some bad assumptions regarding >> the way the interface to the OS works. >> >> Is not that an important difference? > > Not if you want to fix the bug. It looks like I am thinking nearly exactly the opposite. For a simple bug it does not matter. For a complicated bug you can not look at all possible places. That would take too long time. So putting some structure on the different places and evaluating them makes much sense to me. >>>> By >>>> adding DebPrint call we could perhaps see if some code where called in >>>> an order we did not expect. >>> >>> Perhaps see the information that you already have? =C2=A0For example >>> =C2=A0#7 =C2=A00x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3) = at >>> w32menu.c:1701 >>> is telling where is "some code", and >>> =C2=A0"Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )" >>> is telling about "order we did not expect", as likely in: =C2=A0Called >>> twice for the same memory object. =C2=A0If in doubt, try to prove that >>> it can't happen. >> >> Yes, perhaps. But it could also be that memory objects are freed in an >> order we did not expect. >> > > Why should it matter in what order "Invalid Address" is passed to free? Maybe I am misunderstanding, I do not know much about this part of the code. Are you saying that you could not get this error from calls to RtlFreeHeap coming in the wrong order? (That would perhaps help much to know.)