From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C Date: Sat, 19 Aug 2023 15:00:52 -0700 Message-ID: References: <83a5wcncj8.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21821"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64442-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 00:02:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXU1k-0005SA-Ep for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 00:02:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXU1O-0007SP-BZ; Sat, 19 Aug 2023 18:02:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXU1C-0007QS-ME for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 18:02:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXU1B-0000Ys-FM for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 18:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXU1C-00045A-Lj for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 18:02:02 -0400 In-Reply-To: <83a5wcncj8.fsf@gnu.org> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 22:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64442 X-GNU-PR-Package: emacs Mail-Followup-To: 64442@debbugs.gnu.org, casouri@gmail.com, eliz@gnu.org Original-Received: via spool by 64442-done@debbugs.gnu.org id=D64442.169248247415632 (code D ref 64442); Sat, 19 Aug 2023 22:02:02 +0000 Original-Received: (at 64442-done) by debbugs.gnu.org; 19 Aug 2023 22:01:14 +0000 Original-Received: from localhost ([127.0.0.1]:52416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXU0Q-000444-Bz for submit@debbugs.gnu.org; Sat, 19 Aug 2023 18:01:14 -0400 Original-Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:58692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXU0N-00043q-SM for 64442-done@debbugs.gnu.org; Sat, 19 Aug 2023 18:01:13 -0400 Original-Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-68a3f0a7092so90670b3a.1 for <64442-done@debbugs.gnu.org>; Sat, 19 Aug 2023 15:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692482464; x=1693087264; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=I6ixjnqzrPMqFvIL0gsNBuePkLQva1vJo/dq+XqW8Tc=; b=IWAgS7KfmPG8S9IPGiHkpRvpSzaSwEeck6/AUa3IJ85dA+y65rtPFBz5wCWU+nUCln M5YELGUtXI+ykD+1LikwLR93C+vl71VPWvEEPnCaHALr7dFyvf8IjDORBwKCQGjn0cli YosxOWS/cEHDYq8AcuWJCNAjijHY0kchglSeO3bMJaM175lB00ueI/bMRBQLl6dFvfJ0 UOm8DW4K9eS0uBG5uEj0esZ95mrBglitHxnyp2U7fAe7wKTSgU8cedXqCe4H2EtYH1Vu MSlw1GLOxlEJAJmC29glZcx0lhGptFMuvvNs20hfRXtqg3xLM9aS5JQBJQX5rZuWKguo hDRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692482464; x=1693087264; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6ixjnqzrPMqFvIL0gsNBuePkLQva1vJo/dq+XqW8Tc=; b=WSBA7iWSXiHI8Q8iisO+MkUfe+gc84EUBujikPNh6gw5Bc7cozMgMVyosXQ6IeKhc6 /uLesyDnTqL40rMX0+ps7lcbC5BtHVqlnPM6Cvk/ego/7KX9g405RJwKABaaO5iezk+F b0JwMGOOfC6Q3l2mmRruzHSs6zw3tlYwakVPEFNNQ1lzeg7+sQ9b3xnVFC2/KdRCI2pm 1JaEIC1v0xqxrkZ2PAgMaZ3ZMUkoE30zfoPwOMlHyTwUqg1h2kLcQATNzru1oDkpv/Ef 0DVzkomxBgFHeXfVPjbmQwdMr9OzbGRnjZ+l2we9a83THuYZ1LdYgw/tAqUy4oTYxvx2 EyFg== X-Gm-Message-State: AOJu0YxFefjUhP6Ckc7Z+0hn92Hm+x2U6CfX1rAVOoO4SDIXlb9MJrFs 2VDY9gEKofXIVi+/hcuod4Y= X-Google-Smtp-Source: AGHT+IHhjgmpDg2Z4RKl2R7k6ok8VCjViQoFYO+beckTNOs65Pb259aLqbemy1EKu3UZWLgBd2PiQw== X-Received: by 2002:a05:6a20:4282:b0:137:40ba:d91f with SMTP id o2-20020a056a20428200b0013740bad91fmr4567298pzj.10.1692482464414; Sat, 19 Aug 2023 15:01:04 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id q18-20020a639812000000b00564be149a15sm3725892pgd.65.2023.08.19.15.01.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Aug 2023 15:01:03 -0700 (PDT) X-Mailer: Apple Mail (2.3731.600.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267922 Archived-At: Eli Zaretskii writes: >> From: Yuan Fu >> Date: Tue, 15 Aug 2023 00:30:53 -0700 >> Cc: 64442@debbugs.gnu.org >>=20 >> >>> That would allow "C-x 4 a" to work inside a DEFUN, >> >>> something that still works less reliably with this patch: you >> >>> must be >> >>> in the "first defun" to get it to find the name of the function. >> >>=20 >> >> C-x 4 a should=E2=80=99ve been fixed already. And it shouldn=E2=80=99= t rely on >> >> this fix to work. Do you have a recipe for when it doesn=E2=80=99t = work? >> >=20 >> > Just try it with your patch. If point is inside the body, the >> > function's name is not captured by "C-x 4 a=E2=80=9D. >>=20 >> My bad, I must=E2=80=99ve been trying C-x 4 a in a different Emacs = session, >> which worked. Anyway, I updated the patch and C-x 4 a should now >> work. > > Thanks, LGTM. Please install on the emacs-29 branch, and close the > bug when you do. Pushed, thanks. Yuan