From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows Date: Mon, 7 May 2012 08:44:53 -0700 Message-ID: References: <83obqeiwb0.fsf@gnu.org> <83mx5n6ceu.fsf@gnu.org> <83fwbf5e8v.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1336405572 3072 80.91.229.3 (7 May 2012 15:46:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 May 2012 15:46:12 +0000 (UTC) Cc: 11348@debbugs.gnu.org To: "'Stefan Monnier'" , "'Eli Zaretskii'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 07 17:46:11 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SRQ8Y-0007t7-Rn for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 May 2012 17:46:10 +0200 Original-Received: from localhost ([::1]:36287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRQ8Y-0001Cr-5b for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 May 2012 11:46:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRQ8V-0001Cb-4U for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 11:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRQ8O-0002Dq-Tp for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 11:46:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRQ8O-0002Dk-Qd for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 11:46:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SRQAL-0004Ri-Kk for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 11:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2012 15:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11348-submit@debbugs.gnu.org id=B11348.133640562517027 (code B ref 11348); Mon, 07 May 2012 15:48:01 +0000 Original-Received: (at 11348) by debbugs.gnu.org; 7 May 2012 15:47:05 +0000 Original-Received: from localhost ([127.0.0.1]:39668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRQ9R-0004QZ-6X for submit@debbugs.gnu.org; Mon, 07 May 2012 11:47:05 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:50985) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRQ9P-0004Q7-1G for 11348@debbugs.gnu.org; Mon, 07 May 2012 11:47:03 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q47Fitmu030184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 May 2012 15:44:55 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q47Fisst025149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 May 2012 15:44:54 GMT Original-Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q47Fisrx023315; Mon, 7 May 2012 10:44:54 -0500 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 07 May 2012 08:44:53 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac0sZgVA3lxxwanzTtqlxFCrY0FqhAAAdwqQ X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59837 Archived-At: > > (Btw, what's the purpose of using eval-when-compile here?) > > To avoid calling `concat' at run-time (especially within the loop). > In older Emacsen, `concat' was marked as pure so the > byte-compiler would evaluate it at compile-time, but someone > complained that it's not strictly correct because he wanted that > (concat ) is not `eq' to (concat ). I actually think > this change was a mistake and would rather mark `concat' as pure again. That sounds like the kind of explanation that would help readers as a comment in the code. If someone as attentive as Eli has to ask this then it might not hurt to inform readers generally. (Ignore my suggestion if inappropriate - I'm not following the thread etc.)