From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Wed, 10 Jun 2020 20:29:37 +0200 Message-ID: References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <87r1v2aat3.fsf@tromey.com> <9902865C-01B4-4E50-A433-DBC8B8311234@acm.org> <83tuzueogo.fsf@gnu.org> <6272275C-560C-4437-90F1-2A8294D27019@acm.org> <83o8q2elja.fsf@gnu.org> <83mu5mel4o.fsf@gnu.org> <77F1DDD3-A69F-40ED-902D-74986D5E6596@acm.org> <83y2p5cumz.fsf@gnu.org> <83blm0cjlz.fsf@gnu.org> <83367ccf8w.fsf@gnu.org> <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> <83o8pyc4bq.fsf@gnu.org> <55D73CA5-1EFB-4B0A-8F8B-FDA1D39F51BF@acm.org> <835zc5bsut.fsf@gnu.org> <3BBCFDD4-C14D-4628-91CB-2A0456A96FC7@acm.org> <838sh0abzz.fsf@gnu.org> <83r1us8kw6.fsf@gnu.org> <020DE875-14A8-457A-9AE4-AA0925DB8997@acm.org> <83img48ffx.fsf@gnu.org> <83bllw82xt.fsf@gnu.org> <1B0F31C8-1E11-4527-A053-DD2DE8235F58@acm.org> <83wo4g5hz6.fsf@gnu.org> <49B7D7B5-D9E3-4E97-A749-CF5E8D8EE2C6@acm.org> <83mu5b5573.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="12182"; mail-complaints-to="usenet@ciao.gmane.io" Cc: simenheg@runbox.com, tom@tromey.com, 41544@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 10 20:31:53 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj5Vw-00035e-SY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 20:31:53 +0200 Original-Received: from localhost ([::1]:38284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj5Vv-0003a4-Tl for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 14:31:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj5UB-0002bp-JY for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 14:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj5UA-0007kL-9E for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 14:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jj5UA-0008DV-5K for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 14:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2020 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159181378531541 (code B ref 41544); Wed, 10 Jun 2020 18:30:02 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 10 Jun 2020 18:29:45 +0000 Original-Received: from localhost ([127.0.0.1]:35341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5Ts-0008Ce-V0 for submit@debbugs.gnu.org; Wed, 10 Jun 2020 14:29:45 -0400 Original-Received: from mail210c50.megamailservers.eu ([91.136.10.220]:58638 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5Tr-0008CV-Mm for 41544@debbugs.gnu.org; Wed, 10 Jun 2020 14:29:44 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1591813781; bh=fc/YGrssHJ8gVJ070dklY2+wiytkIn6XTq9Vxf/EIJM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=lNeTm5oNKynfj+AVRRi9NDcP39tyvHn59Gul5t1Ra76hI4iLrmnHH6Jr3ioCD8INF qFnJn+0DeAy/yuD9TdzJyES5v4c4+7hT1Z6JcG2SBW06nd6A+JvxoWxv+fVuJtnA+E 3UmmXsiPblAILsPc0C5MaA2D2qP4EKF2a5ULlS7M= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 05AITc6R026660; Wed, 10 Jun 2020 18:29:39 +0000 In-Reply-To: <83mu5b5573.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F16.5EE12695.0066, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KsozJleN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=ZKmGqOLGlA_ATwHfmhUA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181822 Archived-At: 10 juni 2020 kl. 17.08 skrev Eli Zaretskii : > Please make sure the doc string says that the function will return > either the black or the white color, depending on which one will > contrast better with COLOR. Otherwise it is impossible to know, > without looking at the code, that this function can return only these > two colors. A good suggestion -- followed. > Other than that, I'm okay with the following parts of your patch: >=20 > . the changes in list-colors-print > . the addition of color-dark-p and the change in > readable-foreground-color to use it > . the replacement of css--contrasty-color with > readable-foreground-color (assuming Tom doesn't object) Thank you, pushed to master. It does not prevent extended use later on. Would still like a better reason for it than a curt dismissal without = any technical argument whatsoever other than a general aversion to = change. The proposed code is likely considerably better researched and = tested than what it aimed to replace ever was.