From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Date: Mon, 5 Dec 2022 12:22:09 -0800 Message-ID: References: <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jostein@kjonigsen.net, 59833@debbugs.gnu.org, Theodor Thornhill , 59833-done@debbugs.gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 21:23:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2Hzm-0002tq-Ho for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 21:23:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2HzU-0005H2-6R; Mon, 05 Dec 2022 15:23:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2HzS-0005GJ-Nj for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 15:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2HzS-0001fF-Ey for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 15:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2HzS-0001A3-An for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 15:23:02 -0500 Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59833 X-GNU-PR-Package: emacs Mail-Followup-To: 59833@debbugs.gnu.org, casouri@gmail.com, jostein@kjonigsen.net Original-Received: via spool by 59833-done@debbugs.gnu.org id=D59833.16702717414427 (code D ref 59833); Mon, 05 Dec 2022 20:23:02 +0000 Original-Received: (at 59833-done) by debbugs.gnu.org; 5 Dec 2022 20:22:21 +0000 Original-Received: from localhost ([127.0.0.1]:38175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hym-00019G-PG for submit@debbugs.gnu.org; Mon, 05 Dec 2022 15:22:21 -0500 Original-Received: from mail-pl1-f178.google.com ([209.85.214.178]:46913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hyk-000195-0z; Mon, 05 Dec 2022 15:22:19 -0500 Original-Received: by mail-pl1-f178.google.com with SMTP id jn7so11894865plb.13; Mon, 05 Dec 2022 12:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JclPXqtPRSFCM/H3UPF1yF80wMCQSw0AL3nlhDQBW8E=; b=fa2DUMIEvBOyJrfhGBvATYwy2Oc8u+ebPhc+azH8uBcBUSPJSY0/tFiX6ejf47GHXG 3eHPApSA2QpbdUee5jM0rFb/n/ZxvNGpykGimVKWqueKpQmBUYbg8U3PXv8h28Y7xyKV nzrUmVrVz4mVaCB4d9+FpjWV1siYWbGid12MzTkEjWWdnPR0Htz65lth+8IC8gkoPyIO +Mib0xsSF74iokP6WcLQtzE63GPZE0NedWruhlJNdh/W+suacIXH4gLzfyKH+6BMvwzD Pqf/UXfM3twapOR7hBpAiWVIoDrAfPxuQczfxEWhcqSUOmTqapduWUGKQr+ysgqyovoM 4Btw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JclPXqtPRSFCM/H3UPF1yF80wMCQSw0AL3nlhDQBW8E=; b=d4OIfRDJSqXGZmF1O4b4LZGl3FViemPA+w3n5E9tQaffPcEX6+bTCw+zG4q+KkwrN0 x/AJ2ZvK8UG6ugifNYWbxYyOxZsUW777qWxMbYi6e+xnf7VA3uXt7M7NtTlRN9Vdflf/ iPxc3QNNb2LNRPDPnDkXUuVaIOfNa5zSqHs9Pv4yHGm0GgB4tDH2YVK77IAv5d/r1bBA bHlBMe0rn7z/baO3I90o7DBZk/cfM3+XV9rr+/sE57K9Uw+zKXnirCCg17/WV6O0ZmjH z7QZL0Rl4Y3lm6lc8FQPcLfT1OQPbLXJ62o3hNXl+WaseodzjpKfWa7bbXM/HUuw4qd1 HjEQ== X-Gm-Message-State: ANoB5pl31hHZPl2vtCiM1yZ6SllkWoRdqMB5H0JRLkuIDOjbYkubAcjt 2yTlc3MTPXZoBQsLMW1yuyU= X-Google-Smtp-Source: AA0mqf7cUKVG9QeuHtZNByMOCrpFwNQwrzKMv3ttjMTKIjeasuUOaxxbppCujY8DjAWiA3I5gSPuog== X-Received: by 2002:a17:903:28d:b0:189:b74e:cd07 with SMTP id j13-20020a170903028d00b00189b74ecd07mr19888165plr.169.1670271732159; Mon, 05 Dec 2022 12:22:12 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 188-20020a6304c5000000b00477bfac06b7sm8673631pge.34.2022.12.05.12.22.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2022 12:22:10 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250068 Archived-At: > On Dec 5, 2022, at 12:19 PM, Randy Taylor wrote: >=20 > On Monday, December 5th, 2022 at 15:14, Theodor Thornhill = wrote: >>=20 >>=20 >> On 5 December 2022 20:57:55 CET, Yuan Fu casouri@gmail.com wrote: >>=20 >>>> On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for = GNU Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu.org = wrote: >>>>=20 >>>> On 5 December 2022 16:35:12 CET, Randy Taylor dev@rjt.dev wrote: >>>>=20 >>>>> On Monday, December 5th, 2022 at 10:03, Theodor Thornhill = theo@thornhill.no wrote: >>>>>=20 >>>>>> Yeah js-json-mode is a lot simpler, and is imo too simple. The = json-mode >>>>>> is not infact default in emacs, but there are two, one in melpa = and one >>>>>> in elpa, IIRC. >>>>>>=20 >>>>>> Anyway, last patch for now - are you both satisfied with this = one? >>>>>>=20 >>>>>> Theo >>>>>=20 >>>>> It's perfect! Sorry for all the trouble :D. >>>>=20 >>>> No problem :) >>>>=20 >>>> Yuan, will you commit this one? >>>=20 >>> Yeah. IIUC :override t is not necessary for pair, right? If so, = I=E2=80=99ll apply the patch and remove the :override, is that OK? >>>=20 >>> Yuan >>=20 >>=20 >> Please test it first, but sure! We want it to not be string face at = least :) >>=20 >> Theo >=20 > It's necessary, since string comes first and pair needs to override it = (just tested). Ah, yes, of course, sorry for my ignorance. Applied! Yuan=