unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 'Lars Magne Ingebrigtsen' <larsi@gnus.org>, 5105@debbugs.gnu.org
Subject: bug#5105: 23.1; doc string of facemenu-set-face
Date: Mon, 1 Aug 2011 18:36:32 -0700	[thread overview]
Message-ID: <A5E9DF021D384089BB97667A4E3CA947@us.oracle.com> (raw)
In-Reply-To: <jwvr554d5hu.fsf-monnier+emacs@gnu.org>

> No, but two faces can have the same name.

In the same obarray?

> And there can even be a face which has a unique name and yet `intern'
> does not return the corresponding face.

In the same obarray?

Anyway, a good reason (finally).  And not so obvious.

Faces are symbols, and I agree that it is generally not good to accept a symbol
name in place of a symbol as arg.  I retract the request, based on your
argument.

In practice, 99% of the faces passed as args will be interned in `obarray' (not
in some other obarray), so there is still some argument for the convenience of
accepting a string name.

But to avoid confusion and explicitly documenting which obarray would be used if
a string is passed, I agree with you after all.






  reply	other threads:[~2011-08-02  1:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 16:49 bug#5105: 23.1; doc string of facemenu-set-face Drew Adams
2011-07-13 14:42 ` Lars Magne Ingebrigtsen
2011-07-13 15:39   ` Drew Adams
2011-07-15 16:06     ` Lars Magne Ingebrigtsen
2011-07-15 16:13       ` Drew Adams
2011-07-18 14:27         ` Stefan Monnier
2011-07-18 16:55           ` Drew Adams
2011-08-01 21:27             ` Stefan Monnier
2011-08-01 21:47               ` Drew Adams
2011-08-01 22:21                 ` Lars Ingebrigtsen
2011-08-01 22:48                   ` Drew Adams
2011-08-02  0:31                   ` Stefan Monnier
2011-08-02  0:29                 ` Stefan Monnier
2011-08-02  1:36                   ` Drew Adams [this message]
2011-08-02 15:42                     ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A5E9DF021D384089BB97667A4E3CA947@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=5105@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).