bug#32187: 26.1; gnutls-hash-digest

bug#32187: 26.1; gnutls-hash-digest

[Devon Sean McCullough]

$ /Applications/Emacs-26.1-2.app/Contents/MacOS/Emacs-x86_64-10_10 -Q --batch \
--eval '(print (md5 ""))' \
--eval '(print (mapconcat (lambda (b) (format "%02x" b)) (gnutls-hash-digest (quote MD5) "") ""))' \
--eval '(print (mapconcat (lambda (b) (format "%02x" b)) (gnutls-hash-digest (quote md5) "") ""))'

"d41d8cd98f00b204e9800998ecf8427e"

"d41d8cd98f00b204e9800998ecf8427e"
Fatal error 11: Segmentation faultAbort trap: 6 (core dumped)

$ oTool -L /Applications/Emacs-26.1-2.app/Contents/MacOS/Emacs-x86_64-10_10
/Applications/Emacs-26.1-2.app/Contents/MacOS/Emacs-x86_64-10_10:
	/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit (compatibility version 45.0.0, current version 1348.17.0)
	/System/Library/Frameworks/IOKit.framework/Versions/A/IOKit (compatibility version 1.0.0, current version 275.0.0)
	/usr/lib/libxml2.2.dylib (compatibility version 10.0.0, current version 10.9.0)
	/usr/lib/libncurses.5.4.dylib (compatibility version 5.4.0, current version 5.4.0)
	@executable_path/lib-x86_64-10_10/libgnutls.30.dylib (compatibility version 45.0.0, current version 45.10.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1213.0.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1153.31.0)
	/System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics (compatibility version 64.0.0, current version 600.0.0)
	/System/Library/Frameworks/CoreText.framework/Versions/A/CoreText (compatibility version 1.0.0, current version 1.0.0)
	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1154.20.0)
	/usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)

$ ls -la /Applications/Emacs-26.1-2.app/Contents/MacOS/lib-x86_64-10_10
total 3696
drwxr-xr-x@  8 devon  admin      272 May 30 22:11 .
drwxr-xr-x@ 22 devon  admin      748 May 30 22:11 ..
-r--r--r--@  1 devon  admin   450608 May 30 22:11 libgmp.10.dylib
-r--r--r--@  1 devon  admin  1256752 May 30 22:11 libgnutls.30.dylib
-r--r--r--@  1 devon  admin   207200 May 30 22:11 libhogweed.4.dylib
-r--r--r--@  1 devon  admin   209840 May 30 22:11 libnettle.6.dylib
-r--r--r--@  1 devon  admin    73600 May 30 22:11 libtasn1.6.dylib
-r--r--r--@  1 devon  admin  1574096 May 30 22:11 libunistring.2.dylib

In GNU Emacs 26.1 (build 1, x86_64-apple-darwin14.5.0, NS appkit-1348.17 Version 10.10.5 (Build 14F2511))
 of 2018-05-30 built on builder10-10.porkrind.org
Windowing system distributor 'Apple', version 10.3.1404
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-ns '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp' --with-modules'

Configured features:
NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core term/tty-colors frame cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote kqueue cocoa ns
multi-tty make-network-process emacs)

Memory information:
((conses 16 204271 8305)
 (symbols 48 20206 1)
 (miscs 40 70 158)
 (strings 32 28846 1534)
 (string-bytes 1 764420)
 (vectors 16 35070)
 (vector-slots 8 718022 14100)
 (floats 8 48 68)
 (intervals 56 204 0)
 (buffers 992 12))

bug#32187: 26.1; gnutls-hash-digest

[Robert Pluim]

Devon Sean McCullough <Emacs-Hacker2018@jovi.net> writes:

> $ /Applications/Emacs-26.1-2.app/Contents/MacOS/Emacs-x86_64-10_10 -Q --batch \
> --eval '(print (md5 ""))' \
> --eval '(print (mapconcat (lambda (b) (format "%02x" b)) (gnutls-hash-digest (quote MD5) "") ""))' \
> --eval '(print (mapconcat (lambda (b) (format "%02x" b)) (gnutls-hash-digest (quote md5) "") ""))'
>
> "d41d8cd98f00b204e9800998ecf8427e"
>
> "d41d8cd98f00b204e9800998ecf8427e"
> Fatal error 11: Segmentation faultAbort trap: 6 (core dumped)

Hmm. How about this:

diff --git i/src/gnutls.c w/src/gnutls.c
index 117278df35..63e3be61b9 100644
--- i/src/gnutls.c
+++ w/src/gnutls.c
@@ -2608,7 +2608,7 @@ the number itself. */)
     digest_method = intern (SSDATA (digest_method));
 
   if (SYMBOLP (digest_method))
-    info = XCDR (Fassq (digest_method, Fgnutls_digests ()));
+    info = CDR_SAFE (Fassq (digest_method, Fgnutls_digests ()));
   else if (TYPE_RANGED_INTEGERP (gnutls_digest_algorithm_t, digest_method))
     gda = XINT (digest_method);
   else

bug#32187: 26.1; gnutls-hash-digest

[Eli Zaretskii]

> From: Devon Sean McCullough <Emacs-Hacker2018@jovi.net>
> Date: Tue, 17 Jul 2018 08:55:38 -0400
> 
> $ /Applications/Emacs-26.1-2.app/Contents/MacOS/Emacs-x86_64-10_10 -Q --batch \
> --eval '(print (md5 ""))' \
> --eval '(print (mapconcat (lambda (b) (format "%02x" b)) (gnutls-hash-digest (quote MD5) "") ""))' \
> --eval '(print (mapconcat (lambda (b) (format "%02x" b)) (gnutls-hash-digest (quote md5) "") ""))'
> 
> "d41d8cd98f00b204e9800998ecf8427e"
> 
> "d41d8cd98f00b204e9800998ecf8427e"
> Fatal error 11: Segmentation faultAbort trap: 6 (core dumped)

Thanks, should be fixed now (on the emacs-26 branch).