From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#18109: 24.4.50; `compilation-error-regexp-alist-alist': wrong regexp for Maven Date: Sun, 6 Dec 2020 16:05:20 +0100 Message-ID: References: <5FFB3461-E756-4C09-9BFE-E0F9C840E533@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36527"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 18109@debbugs.gnu.org To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 16:06:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klvcO-0009PO-4B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 16:06:32 +0100 Original-Received: from localhost ([::1]:44048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klvcN-0004mR-4i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 10:06:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klvbu-0004lJ-NQ for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klvbu-00013J-Gd for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klvbu-0001u0-BL for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18109 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 18109-submit@debbugs.gnu.org id=B18109.16072671327270 (code B ref 18109); Sun, 06 Dec 2020 15:06:02 +0000 Original-Received: (at 18109) by debbugs.gnu.org; 6 Dec 2020 15:05:32 +0000 Original-Received: from localhost ([127.0.0.1]:50697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klvbQ-0001tC-7U for submit@debbugs.gnu.org; Sun, 06 Dec 2020 10:05:32 -0500 Original-Received: from mail1476c50.megamailservers.eu ([91.136.14.76]:48116 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klvbO-0001sx-44 for 18109@debbugs.gnu.org; Sun, 06 Dec 2020 10:05:31 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1607267123; bh=K/Ml8/cxHTxyfVoerCtmceY9JzXxG21MR/0omSnJbUA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=hpJjxCavrg5akhkKiIX+si7crZc9kHL3LUEXDxrNdFw9ZaUA9K6xI5JbZOo9HEMLx JutkI2jRH4dnuNZex6Me8bBdFK5xEzBBGUFwoLX1x/Q34AvWtNjuPrze5KWwsdWaXH Ku5sE/9wF+5Zfiyd3t4bblj+R+VhCcgFtHhehpik= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0B6F5KsZ016721; Sun, 6 Dec 2020 15:05:22 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F27.5FCCF333.000C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=HYRqsRM8 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=6oRtVurhXDSkwXCM-FwA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195109 Archived-At: 6 dec. 2020 kl. 15.22 skrev Filipp Gunbin : > Hm, I rarely use Maven these days (many projects switched to Gradle), > and I'm not on Windows any more, so I cannot reproduce the original > problem now. If you think it's very improbable to have non-prefixed > message - just make the regexp more strict, and let's see whether > someone reports it again. Thank you, maybe we should indeed do that. It is good to have someone knowing Gradle! That pattern could need some = work as well. It currently is (in rx form): (rx bol (| (group "w") nonl) ":" (* " ") ; ?? (group (? (in "A-Za-z") ":") (+ (not (in "\n:")))) ":" (* " ") ; ?? "(" (group (+ (in "0-9"))) "," (* " ") ; ?? (group (+ (in "0-9"))) ")") but the examples (from compilation.txt) look like: e: /src/Test.kt: (34, 15): foo: bar w: /src/Test.kt: (34, 15): foo: bar Thus it looks like we can expect exactly one space each after the first = and second colon and after the comma, instead of zero-or-more spaces = (the '??' comments above). As a Gradle user, can you confirm this? The way the pattern is written makes it prone to matching other messages = entirely or partly, with potential negative consequences for = correctness, performance or both.