From: Robert Dallas Gray <mail@robertdallasgray.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 15886@debbugs.gnu.org
Subject: bug#15886: 24.3.50; Incorrect window-text-height with non-zero line-spacing
Date: Wed, 13 Nov 2013 20:55:20 +0000 [thread overview]
Message-ID: <A505F7F3-CFF6-4571-8288-CC84EF21A539@robertdallasgray.com> (raw)
In-Reply-To: <837gcc116m.fsf@gnu.org>
On 13 Nov 2013, at 20:44, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Robert Dallas Gray <mail@robertdallasgray.com>
>> Date: Wed, 13 Nov 2013 20:36:14 +0000
>> Cc: 15886@debbugs.gnu.org
>>
>>
>> On 13 Nov 2013, at 20:32, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>>> From: Robert Dallas Gray <mail@robertdallasgray.com>
>>>> Date: Wed, 13 Nov 2013 19:23:19 +0000
>>>>
>>>> On a graphical display, when `line-spacing' is non-zero,
>>>> `window-text-height' reports an incorrect number; equally,
>>>> `set-window-text-height' can't be used properly. This impacts on
>>>> libraries which use `set-window-text-height' e.g. to attempt to size a
>>>> window accurately.
>>>
>>> Those libraries should use 'window-screen-lines' instead.
>>>
>>> I think 'window-text-height' should continue doing what it does, as
>>> many packages, and Emacs itself, depend on its current behavior.
>>
>> OK, but is there a parallel setter method, or some way to set the height of a window in pixels, so that a window could be correctly sized taking into account line-spacing?
>
> I don't understand: if you need to get a window's height and then use
> it to change the height, then why isn't 'window-text-height' and
> set-window-text-height' what you want? They are consistent with one
> another.
>
> Perhaps it would help if you explain more about what you want to
> accomplish, and why.
Well, it's not my library, but the reason it fails (in my setup, where I have line-spacing set to 2), is that it tries to set the height of the minibuffer using 'set-window-text-height' -- which, in my setup, sets the height incorrectly (the bottom of the minibuffer is obscured). I note that 'set-window-text-height' uses 'window-text-height'
If there's a setter equivalent of 'window-screen-lines' (which there doesn't seem to be), then I can raise that with the maintainer. Otherwise, is there a way to set window height in pixels (which can be easily worked out from the number of lines of text)? If not, then there's no way (that I can see) to accomplish the intended function of 'set-window-text-height' in gui Emacs.
next prev parent reply other threads:[~2013-11-13 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 19:23 bug#15886: 24.3.50; Incorrect window-text-height with non-zero line-spacing Robert Dallas Gray
2013-11-13 20:32 ` Eli Zaretskii
2013-11-13 20:36 ` Robert Dallas Gray
2013-11-13 20:44 ` Eli Zaretskii
2013-11-13 20:55 ` Robert Dallas Gray [this message]
2013-11-13 21:16 ` Eli Zaretskii
2013-11-13 21:27 ` Robert Dallas Gray
2013-11-14 3:44 ` Eli Zaretskii
[not found] ` <CAOTeZj9_+4P1yUFpObLV+acFxpZyHsPG0uW2HyV=34zOQUT88Q@mail.gmail.com>
2013-11-14 18:07 ` Eli Zaretskii
2013-11-14 19:24 ` Robert Dallas Gray
2020-10-28 7:39 ` Stefan Kangas
2013-11-14 7:38 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A505F7F3-CFF6-4571-8288-CC84EF21A539@robertdallasgray.com \
--to=mail@robertdallasgray.com \
--cc=15886@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).