From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#64283: 29.0.91; js-mode's mark-defun does not work correctly when functions have a comment on top Date: Mon, 26 Jun 2023 18:42:41 -0700 Message-ID: References: <83leg7y44c.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7906"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Eli Zaretskii , 64283@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 27 03:43:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDxjp-0001wI-40 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Jun 2023 03:43:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDxjX-0006N2-Ds; Mon, 26 Jun 2023 21:43:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDxjT-0006MY-20 for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 21:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDxjS-0003Wg-OT for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 21:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDxjS-0006Ai-7n for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 21:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2023 01:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64283 X-GNU-PR-Package: emacs Original-Received: via spool by 64283-submit@debbugs.gnu.org id=B64283.168783018123717 (code B ref 64283); Tue, 27 Jun 2023 01:43:02 +0000 Original-Received: (at 64283) by debbugs.gnu.org; 27 Jun 2023 01:43:01 +0000 Original-Received: from localhost ([127.0.0.1]:47319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDxjR-0006AT-4u for submit@debbugs.gnu.org; Mon, 26 Jun 2023 21:43:01 -0400 Original-Received: from mail-oi1-f169.google.com ([209.85.167.169]:48404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDxjO-0006AG-Tx for 64283@debbugs.gnu.org; Mon, 26 Jun 2023 21:42:59 -0400 Original-Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3a0423ea74eso2850515b6e.1 for <64283@debbugs.gnu.org>; Mon, 26 Jun 2023 18:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687830173; x=1690422173; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v0dL7hcvI1MgjlRexU/VS4kESp8KH+LMa7S2Y8Xsu3w=; b=NOyl7kqQqcSpxX8MNscqjUkTPkXvuPSAd9d9g4WvW6ioUwhMjS8aiZuKK99CJMh9Ly hPE7roK5nUiC6WcHy7G1YwfSeYFaOcQ1Fx8oMcU6j43qAaYfwrDzmaRyEIkWHYgHRLG2 rlxEBkmTHnx5qSp4IZWmj+3w1gm9caO1CD4UhJxRB6I+1K6uFnyavlljMfhIrLAWfm8+ 0lB4oVl9SB6rzOYvYIbj1VB1Q2Xtu52LpUDg628GDkPQuR1JY375VGX21zATTm/9joip G334vxLywUAI2FUA3fFrLkQ3ksxTW8aoykUTYDRqsRVDJ8iZm1JOcRH3wjQjDt92MpZ1 d+OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687830173; x=1690422173; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v0dL7hcvI1MgjlRexU/VS4kESp8KH+LMa7S2Y8Xsu3w=; b=aTDyoWqkrYmA+mUBHu5mWzViPxb1aSc+7I5NBr8KnkeqHzaAQWE5wFYcajc8ApG8ll suMrLJ04n/kTV2lM9m5Tl06UoPiUcpTSbDlxHtuTusACvFAbpts9f45Ex3Dp/nbpjdCg qnzSYQNSQDiGyBzB7Yaut7DXmgv9PDLo9YRvL1o7rX3ZNxU4wKUTxebDnvmep0gSJBTS gtm5osPWVgJqq+BYBRQldXj9YsTLza8XCcygUOlzMKa287VZwp2ux+IGERc/j1hcY+3u +lC6WnAIVO/Q47msLGq6dcnotoNUCZ97egB133wh2q5HpeRB4HEI+d6hyj5Vr3U+kkrt Ivnw== X-Gm-Message-State: AC+VfDzs/Ft2DmmZeb1fEeL06kd9pCjb25YMi/7RjIXkdl/wfv8w0Qo0 aShNOkHGymfBZB4ZaMeync0= X-Google-Smtp-Source: ACHHUZ5J7gIzcid/TVPnwnfqxeEGIMzE5puV0Dziz8mqM2sRLaM9RbxrYE5Jeh7udJQMRNoCSsSCTQ== X-Received: by 2002:a05:6808:138a:b0:3a1:e132:dd8b with SMTP id c10-20020a056808138a00b003a1e132dd8bmr4850318oiw.41.1687830172919; Mon, 26 Jun 2023 18:42:52 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id n11-20020a6546cb000000b00528da88275bsm4168863pgr.47.2023.06.26.18.42.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jun 2023 18:42:52 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3731.600.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264118 Archived-At: >=20 > What I see is that, after 4489450f37deafb013b1f0fc00c89f0973fda14a, > defun movement may be subtly broken if beginning-of-defun-function = does > not return non-nil when it found the beginning of a defun. One of the > affected modes is js-mode, but who knows if there are more out there. >=20 > We could either revert 4489450f37deafb013b1f0fc00c89f0973fda14a, = because > of the incompatibilities it may cause (Yuan, what is the bug it tries = to > fix?), or maybe adjust js-mode so that it follows the documentation of > beginning-of-defun-function and returns non-nil when it found the > beginning of a defun. I've attached a patch that follows this second > approach, with some unit tests. It fixes the bug on my side. >=20 > <0001-Make-js-beginning-of-defun-return-non-nil-on-success.patch> The original problem that I tried to solve is that sometimes = end-of-defun-function was called when point isn=E2=80=99t at the = beginning of a defun, contrary to what the documentation claims.=20 I first find out about it when writing defun movement functions for = tree-sitter, but if you revert the commit now tree-sitter defun = functions wouldn=E2=80=99t break: they have change quite a bit since = then and treesit-end-of-defun don=E2=80=99t need to be called at the = beginning of the defun anymore. Yuan=