From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60127: treesit-end-of-defun: possible bug with clojure grammar Date: Tue, 17 Jan 2023 01:30:22 -0800 Message-ID: References: <87sfhf5ghj.fsf@dfreeman.email> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31586"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60127@debbugs.gnu.org, Danny Freeman To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 17 10:31:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHiJL-000874-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Jan 2023 10:31:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHiJ8-0004Xs-Nb; Tue, 17 Jan 2023 04:31:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHiJ4-0004W7-B0 for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 04:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHiJ3-0002TI-UO for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 04:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHiJ3-0000X4-LD for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 04:31:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87sfhf5ghj.fsf@dfreeman.email> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jan 2023 09:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending Original-Received: via spool by 60127-submit@debbugs.gnu.org id=B60127.16739478332000 (code B ref 60127); Tue, 17 Jan 2023 09:31:01 +0000 Original-Received: (at 60127) by debbugs.gnu.org; 17 Jan 2023 09:30:33 +0000 Original-Received: from localhost ([127.0.0.1]:35749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHiIb-0000WC-FF for submit@debbugs.gnu.org; Tue, 17 Jan 2023 04:30:33 -0500 Original-Received: from mail-pj1-f48.google.com ([209.85.216.48]:53797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHiIZ-0000Vw-84 for 60127@debbugs.gnu.org; Tue, 17 Jan 2023 04:30:32 -0500 Original-Received: by mail-pj1-f48.google.com with SMTP id d8so595079pjc.3 for <60127@debbugs.gnu.org>; Tue, 17 Jan 2023 01:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=3ITKihIQSCli07PwFr2mYsPxQfNYYXHGTPiNzDUeKl0=; b=kdsZ2e6HVmXhT42LAhW782128KtNDtssIObxWBcLhZ0C90yiwEfW1Aoabuur08c3Qu tJqSbTFRLDnvAULuujv0/gvRMZ6l038ak9+whrJI+eIhPlh7FENYdRMXiFvMCi8/AMmP MY4TevU6u85ldvFluYHTkMnhbWrFpYw8gWIOYIP4dot5EkuRUSbp9U6iFfAUl3nuMtvN J6WfKw7mh/0Ac/3fcWAfVm3Uo4GuGD1prrpYxrUMvbrNOxMK9krufmOG1w0uVSApUlr6 aKBjnCSJMBAPzjq2M4DDf5qLy7VYtC2AU2iFjSVHHKx3ddu512mG2mbtqBQFxNahyIwk wLcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ITKihIQSCli07PwFr2mYsPxQfNYYXHGTPiNzDUeKl0=; b=s10NuUpk2yKTRs6Xy8Uh4rLqa9rtq1z5SIr/ynJkukbNc5lf1Q1H56IxdtXLzEhEax yvKn2h6RDrWlZefXkQWpNyYwvvMQ2xhAeIPPGKuo0KaxB2WBuSKxIGmj8QA0HpeYJzwC F3qr/KFJGClKruOpAmLL/xM0iM3PyhFs5efiTTErexmTAq0CumyB0xakLvvVbEibYJme Bvib2H7GvxnuXPd8vpxT6NU/IDdiWDpc1BvTS+iYkvGexxa9YDvIg2eV9CpeGYY/uz3B +iWCA/cfs79nRGAH4LpJh2u5SL6WIQv4TOTwkkJ+f9qezdWK6SXp73mYZMKwh5I5IhxK aadA== X-Gm-Message-State: AFqh2kojxBhqbDilwANm4BM4R5zeeQcqtxlOhqKmHgwWdznnTYeFYlb/ LvhSaDYHkkvWk1lvNwwiUHU= X-Google-Smtp-Source: AMrXdXsmhc3H+4FS2cVa1X4UqxANumE8fqs3rkiF111IQVo+3fz5eyoLGUVBM+tjYjhc/ww/jBQWZA== X-Received: by 2002:a17:90a:a795:b0:226:3a18:177e with SMTP id f21-20020a17090aa79500b002263a18177emr2668924pjq.16.1673947825183; Tue, 17 Jan 2023 01:30:25 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x4-20020a634844000000b0044046aec036sm16932226pgk.81.2023.01.17.01.30.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2023 01:30:24 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253534 Archived-At: > I=E2=80=99d rather not use treesit_search_dfs, as it does much more = work than > the current code. You know what, I can write a custom > ts_node_first_child_for_byte and use that in Emacs, I=E2=80=99ve = already done > that for ts_node_parent anyway. I did that. I tested with the Clojure example and it works fine now. Eli, we don=E2=80=99t use ts_node_first_child_for_pos for now until = tree-sitter fix that function, should I removed the boilerplate for it or should I leave it as-is? I saw you removed ts_node_parent when I did a similar fix. Yuan