unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jacob Faibussowitsch <jacob.fai@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63415@debbugs.gnu.org, Andrea Corallo <akrl@sdf.org>
Subject: bug#63415: 30.0.50; More Build Warnings
Date: Thu, 11 May 2023 09:39:59 -0400	[thread overview]
Message-ID: <A070A978-80C5-402F-BD28-C4ADF4255BAE@gmail.com> (raw)
In-Reply-To: <838rdv57ak.fsf@gnu.org>

> Avoiding it is too much
> trouble (will make the code harder to read), and this configuration is
> rare enough to not justify that.  So I've left that alone.

FWIW the following silences the warning. But up to you

diff --git a/src/dispnew.c b/src/dispnew.c
index fe661579daf..f456a60246b 100644
--- a/src/dispnew.c
+++ b/src/dispnew.c
@@ -3808,6 +3808,8 @@ update_window (struct window *w, bool force_p)
              redraw_overlapped_rows (w, yb);
              redraw_overlapping_rows (w, yb);
            }
+#else
+          (void)changed_p;
 #endif

          /* Make cursor visible at cursor position of W.  */

Best regards,

Jacob Faibussowitsch
(Jacob Fai - booss - oh - vitch)

> On May 11, 2023, at 09:25, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Jacob Faibussowitsch <jacob.fai@gmail.com>
>> Date: Wed, 10 May 2023 07:25:34 -0400
>> 
>> dispnew.c:3650:12: warning: variable 'changed_p' set but not used [-Wunused-but-set-variable]
>>      bool changed_p = 0, mouse_face_overwritten_p = 0;
>>           ^
>> 1 warning generated.
> 
> This is expected in a build --without-x.  Avoiding it is too much
> trouble (will make the code harder to read), and this configuration is
> rare enough to not justify that.  So I've left that alone.
> 
>> In native--compile-async:
>> comp.el:4240:14: Warning: value from call to ‘cl-substitute’ is unused
> 
> Andrea, would you please take care of this warning?
> 
> I hope I've now fixed the rest, thanks.






  reply	other threads:[~2023-05-11 13:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 11:25 bug#63415: 30.0.50; More Build Warnings Jacob Faibussowitsch
2023-05-11 13:25 ` Eli Zaretskii
2023-05-11 13:39   ` Jacob Faibussowitsch [this message]
2023-05-11 14:01     ` Eli Zaretskii
2023-05-17  7:55   ` Andrea Corallo
2023-05-17 11:06     ` Eli Zaretskii
2023-05-17 14:11       ` Andrea Corallo
2023-05-17 14:30         ` Eli Zaretskii
2023-05-17 14:37           ` Andrea Corallo
2024-03-21 11:08             ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A070A978-80C5-402F-BD28-C4ADF4255BAE@gmail.com \
    --to=jacob.fai@gmail.com \
    --cc=63415@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).