bug#14270: shadow.el, simple.el, shadows shadows

bug#14270: shadow.el, simple.el, shadows shadows

[Greg Minshall]

hi.  in shadow.el, list-load-path-shadows has some code to look for the
(originally, first; now last)
----
http://lists.gnu.org/archive/html/bug-gnu-emacs/2002-03/msg00507.html
----
directory with simple.el in it.  i *assume* that originally, there were
no directories underneath, e.g., /usr/local/share/emacs/24.3/lisp.  but
now, subsystems seem to live in directories.  i.e., in my case, the
following are subdirectories:
----
calc calendar cedet emacs-lisp emulation erc eshell gnus international
language mail mh-e net nxml obsolete org play progmodes term textmodes
url vc
----

in my setup, i have local copies of mh-e and org.  if i say M-x
list-load-path-shadows, i get the message that
----
No Emacs Lisp load-path shadowings were found
----
but, if i disable the search for simple.el, i instead get the more
accurate:
----
118 Emacs Lisp load-path shadowings were found
----

i wonder if the test for simple.el might be removed?  it appears that it
was designed to help in the case where a developer's own load-path
includes his/her source directory (and, with the above change from first
to last, i'm not sure if it even fulfills that desire).  if there's
still a desire for that behavior, maybe a customizable list of
directories to ignore, similar to (but markedly different from) the
suggestion in
----
http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-09/msg00135.html
----

cheers, Greg Minshall

bug#14270: shadow.el, simple.el, shadows shadows

[Glenn Morris]

Greg Minshall wrote:

> hi.  in shadow.el, list-load-path-shadows has some code to look for the
> (originally, first; now last)
> ----
> http://lists.gnu.org/archive/html/bug-gnu-emacs/2002-03/msg00507.html
> ----
> directory with simple.el in it.  i *assume* that originally, there were
> no directories underneath, e.g., /usr/local/share/emacs/24.3/lisp.

No, the simple.el check is for something else.
list-load-path-shadows assuredly works fine with subdirs.

It's actually because when Emacs was running uninstalled, it used to
add the installation lisp directories to load-path if they existed.
It doesn't do that since 2012-07-07, so this check can probably be
removed anyway, but it should not cause the issue you describe by itself.

> in my setup, i have local copies of mh-e and org.  if i say M-x
> list-load-path-shadows, i get the message that
> ----
> No Emacs Lisp load-path shadowings were found
> ----
> but, if i disable the search for simple.el, i instead get the more
> accurate:
> ----
> 118 Emacs Lisp load-path shadowings were found
> ----

This implies you have multiple copies of "simple.el" in directories
directly specified in your load-path. Do you? If so, why?
(cedet/ede/simple.el does not count, because cedet/ede is not in
load-path.)

bug#14270: shadow.el, simple.el, shadows shadows

[Greg Minshall]

Glenn,

yes, you are absolutely right.  i had (and have had for years) some
buggy code in my .emacs to tweak load-path, which code was causing my
load-path to have lots of duplicate entries.  i just now re-did that
code using push (plus normal-top-level-add-subdirs-to-load-path), and
now load-path has no more duplicates, and list-load-path-shadows reports
the expected 118 shadowings.

thanks, and sorry for the noise.

cheers, Greg Minshall

bug#14270: shadow.el, simple.el, shadows shadows

[Glenn Morris]

Version: 24.4

Thanks for the report anyway. I will remove the simple.el check, because
it should not be needed any more.