From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional Date: Fri, 15 Mar 2024 19:41:33 -0500 Message-ID: <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> <867ci5b324.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------HMZoTgSB7suN2LfyCwsHNTnv" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7640"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 69666@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 16 01:42:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlI8X-0001lv-BU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Mar 2024 01:42:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlI84-0001OW-S3; Fri, 15 Mar 2024 20:42:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlI82-0001O3-7X for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 20:42:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlI81-00035y-WF for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 20:42:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlI8c-0005sO-8Q for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 20:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Mar 2024 00:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69666-submit@debbugs.gnu.org id=B69666.171054974822517 (code B ref 69666); Sat, 16 Mar 2024 00:43:02 +0000 Original-Received: (at 69666) by debbugs.gnu.org; 16 Mar 2024 00:42:28 +0000 Original-Received: from localhost ([127.0.0.1]:54282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlI80-0005qy-Ud for submit@debbugs.gnu.org; Fri, 15 Mar 2024 20:42:28 -0400 Original-Received: from toucan.tulip.relay.mailchannels.net ([23.83.218.254]:13219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlI7v-0005qj-2F for 69666@debbugs.gnu.org; Fri, 15 Mar 2024 20:42:23 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5C0D94C0B2A; Sat, 16 Mar 2024 00:41:41 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a277.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B85384C29EF; Sat, 16 Mar 2024 00:41:40 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1710549700; a=rsa-sha256; cv=none; b=vjpUGJ6+x/36Q+4c6c/hXcw3sWhq+9tLQUIOCJSuWSHNvOxgGuKqOSPtNFb9Ailq95f9UN 2RlETbKxdcE9hzNtSH2R5QDPAS+N1wcflRzHOGe30Y+SDe3HD6UutgHlDqgOc7RznEFS+L tsWrZ5WTXv7l1LZER/iCAFeqZNHPE1NZ0XLwpee++BaMHl16luQIpL6ohyB3RGDojId9kY rSZG8sfBrHEOlt3sqFk4tD9YnmZdrp9Vkr35+5HnWKRZR6kIhfEZXc2M8b1lbqVcY1962p CIXchhpC9eeTLlRnM4yU+AbuXImmVxiU7xK+reaiu2imtUoKnUimK4lxefj6yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1710549700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79y3FvAoVC7lyHphGArrjpJv5bIqd3u2wAFnGBf1GQk=; b=LgXOUoobkNH9UJNeicsfbJ4EIfGt07a5Iz9T/lw+FKFuUZpN07C/nSwhGYgwS+EVf4G+0I nQNS4armN92SrDeyE0FTYTPQsU2orojolazXsie4v/4ABkCSCTJoFLVjRJ9NomrxHpyo6P v2yBCLbfiKi8DDbD6BjS7xri/dgm1HGPfWV5HBbhXxB6uBLr8qGD6LvgtkNI7/j914eXeA JWXZZBjcnFfuMMQXCJIJbdVcLO9ylc+I8lQ83NI/kYjhKPhkJSxc+z687O6g4gw9iemwEb GqiCY01rsGL8EqyI1CFbrAmLV+OpqrFC2MFTuRly09Hkz9f/04Apdx/Ji8lmdg== ARC-Authentication-Results: i=1; rspamd-76c7995f89-qr5dd; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Sponge-Squirrel: 666eefa22ecbdf2e_1710549701013_335945126 X-MC-Loop-Signature: 1710549701013:2137507591 X-MC-Ingress-Time: 1710549701013 Original-Received: from pdx1-sub0-mail-a277.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.109.159.228 (trex/6.9.2); Sat, 16 Mar 2024 00:41:41 +0000 Original-Received: from [10.43.0.18] (unknown [193.56.116.15]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a277.dreamhost.com (Postfix) with ESMTPSA id 4TxMkX1dYWzxr; Fri, 15 Mar 2024 17:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1710549700; bh=79y3FvAoVC7lyHphGArrjpJv5bIqd3u2wAFnGBf1GQk=; h=Content-Type:Date:Subject:To:Cc:From; b=gU9ODe6RZZiAF3icebW5qa755P0lPV6VS8iux+3/GMNfY8/eKAfeInH8FtxfaEz8d ZlurV/ej6u+qE8KBtGrME4Z4JlzqauBdN9xgcjoX8qwfc2a/UraTGKQDBxShm9roe0 qJaNfUeIcgW+wBRkllJekGwgMsQXW2MhvYbfydwtYTCULJhSbTd/Y+QskslRwwOgxg sO+GyHEQrdUl7LVzNKCJOqhHuUiDJ5holdLiKJY/KQyiSXtdcEfHztCGADrVP+0cDz 10sVAG39MW9AA3oPu+o1rxRiE2fB8d2ebSlSt0bUXHIsbawD9rj3CcjEuIzS9PBy7M ooi6358TZlZEQ== Content-Language: en-US In-Reply-To: <867ci5b324.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281700 Archived-At: This is a multi-part message in MIME format. --------------HMZoTgSB7suN2LfyCwsHNTnv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Eli, On 3/14/24 04:00, Eli Zaretskii wrote: >> Date: Fri, 8 Mar 2024 23:51:33 -0600 >> From: Adam Porter >> >> Please see the attached patch which makes `vtable-update-object' easier >> to use in the common case of updating an existing object's >> representation in a table (rather than replacing it with another object). > > Thanks, I have some minor comments below. Thanks for your review. Please see the attached patch which addresses those three items and is rebased on current master. Please let me know if I need to make any further changes. Thanks, Adam --------------HMZoTgSB7suN2LfyCwsHNTnv Content-Type: text/x-patch; charset=UTF-8; name="0001-vtable-update-object-Make-old-object-argument-option.patch" Content-Disposition: attachment; filename*0="0001-vtable-update-object-Make-old-object-argument-option.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0Yjc2MjAxNWViYjgyZDE4NjFjMmVmZTUxYzFlOTAyYWMzMjliYzhlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFBvcnRlciA8YWRhbUBhbHBoYXBhcGEubmV0 PgpEYXRlOiBGcmksIDggTWFyIDIwMjQgMjM6NDM6MTQgLTA2MDAKU3ViamVjdDogW1BBVENI XSAodnRhYmxlLXVwZGF0ZS1vYmplY3QpOiBNYWtlIG9sZC1vYmplY3QgYXJndW1lbnQgb3B0 aW9uYWwKIChCdWcjNjk2NjYpCgoqIGxpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwgKHZ0YWJs ZS11cGRhdGUtb2JqZWN0KTogTWFrZSAnb2xkLW9iamVjdCcKYXJndW1lbnQgb3B0aW9uYWwu CiogZG9jL21pc2MvdnRhYmxlLnRleGkgKEludGVyZmFjZSBGdW5jdGlvbnMpOiBVcGRhdGUg ZG9jdW1lbnRhdGlvbi4KKiBldGMvTkVXUzogQWRkIG5ld3MgZW50cnkuCgpJdCdzIG9mdGVu IG5lY2Vzc2FyeSB0byB1cGRhdGUgdGhlIHJlcHJlc2VudGF0aW9uIG9mIGEgc2luZ2xlIG9i amVjdCBpbgphIHRhYmxlIChlLmcgYSBzdHJ1Y3QsIHdob3NlIGlkZW50aXR5IGRvZXMgbm90 IGNoYW5nZSB3aGVuIGl0cyBzbG90cycKdmFsdWVzIGFyZSBjaGFuZ2VkKS4gIFRvIGRvIHNv LCBub3cgdGhlIGZ1bmN0aW9uIG1heSBiZSBjYWxsZWQgbGlrZQp0aGlzOgoKICAodnRhYmxl LXVwZGF0ZS1vYmplY3QgdGFibGUgb2JqZWN0KQoKSW5zdGVhZCBvZiBsaWtlIHRoaXM6Cgog ICh2dGFibGUtdXBkYXRlLW9iamVjdCB0YWJsZSBvYmplY3Qgb2JqZWN0KQotLS0KIGRvYy9t aXNjL3Z0YWJsZS50ZXhpICAgICAgfCA5ICsrKysrKy0tLQogZXRjL05FV1MgICAgICAgICAg ICAgICAgICB8IDkgKysrKysrKysrCiBsaXNwL2VtYWNzLWxpc3AvdnRhYmxlLmVsIHwgOSAr KysrKysrLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvbWlzYy92dGFibGUudGV4aSBiL2RvYy9taXNjL3Z0 YWJsZS50ZXhpCmluZGV4IGE0ZjJlZDI5ZDkzLi42ODgxZTk2NjNjNCAxMDA2NDQKLS0tIGEv ZG9jL21pc2MvdnRhYmxlLnRleGkKKysrIGIvZG9jL21pc2MvdnRhYmxlLnRleGkKQEAgLTU1 NCw5ICs1NTQsMTIgQEAgSW50ZXJmYWNlIEZ1bmN0aW9ucwogYWxzbyB1cGRhdGVzIHRoZSBk aXNwbGF5ZWQgdGFibGUuCiBAZW5kIGRlZnVuCiAKLUBkZWZ1biB2dGFibGUtdXBkYXRlLW9i amVjdCB0YWJsZSBvYmplY3Qgb2xkLW9iamVjdAotQ2hhbmdlIEB2YXJ7b2xkLW9iamVjdH0g aW50byBAdmFye29iamVjdH0gaW4gQHZhcnt0YWJsZX0uICBUaGlzIGFsc28KLXVwZGF0ZXMg dGhlIGRpc3BsYXllZCB0YWJsZS4KK0BkZWZ1biB2dGFibGUtdXBkYXRlLW9iamVjdCB0YWJs ZSBvYmplY3QgJm9wdGlvbmFsIG9sZC1vYmplY3QKK1VwZGF0ZSBAdmFye29iamVjdH0ncyBy ZXByZXNlbnRhdGlvbiBpbiBAdmFye3RhYmxlfS4gIE9wdGlvbmFsIGFyZ3VtZW50CitAdmFy e29sZC1vYmplY3R9LCBpZiBub24tQGNvZGV7bmlsfSwgbWVhbnMgdG8gcmVwbGFjZSBAdmFy e29sZC1vYmplY3R9Cit3aXRoIEB2YXJ7b2JqZWN0fSBhbmQgcmVkaXNwbGF5IHRoZSBhc3Nv Y2lhdGVkIHJvdyBpbiB0aGUgdGFibGUuICBJbgorZWl0aGVyIGNhc2UsIGlmIHRoZSBleGlz dGluZyBvYmplY3QgaXMgbm90IGZvdW5kIGluIHRoZSB0YWJsZSAoYmVpbmcKK2NvbXBhcmVk IHdpdGggQGNvZGV7ZXF1YWx9KSwgc2lnbmFsIGFuIGVycm9yLgogCiBUaGlzIGhhcyB0aGUg c2FtZSBlZmZlY3QgYXMgY2FsbGluZyBAY29kZXt2dGFibGUtcmVtb3ZlLW9iamVjdH0gYW5k CiB0aGVuIEBjb2Rle3Z0YWJsZS1pbnNlcnQtb2JqZWN0fSwgYnV0IGlzIG1vcmUgZWZmaWNp ZW50LgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBhNjU0ZDJkOGQ3 OS4uODU3NTEwNzRhYWEgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBA IC0yMTc1LDYgKzIxNzUsMTUgQEAgYWZvcmVtZW50aW9uZWQgZnVuY3Rpb25zOgogICAgIChh bmQgKGFycmF5cCBleGVjdXRpbmcta2JkLW1hY3JvKQogICAgICAgICAgKD49IGV4ZWN1dGlu Zy1rYmQtbWFjcm8taW5kZXggKGxlbmd0aCBleGVjdXRpbmcta2JkLW1hY3JvKSkpKQogCisr KysKKyoqICd2dGFibGUtdXBkYXRlLW9iamVjdCcgdXBkYXRlcyBhbiBleGlzdGluZyBvYmpl Y3Qgd2l0aCBqdXN0IHR3byBhcmd1bWVudHMuCitJdCBpcyBub3cgcG9zc2libGUgdG8gdXBk YXRlIHRoZSByZXByZXNlbnRhdGlvbiBvZiBhbiBvYmplY3QgaW4gYSB2dGFibGUKK2J5IGNh bGxpbmcgJ3Z0YWJsZS11cGRhdGUtb2JqZWN0JyB3aXRoIGp1c3QgdGhlIHZ0YWJsZSBhbmQg dGhlIG9iamVjdCBhcworYXJndW1lbnRzLiAgKFByZXZpb3VzbHkgdGhlICdvbGQtb2JqZWN0 JyBhcmd1bWVudCB3YXMgcmVxdWlyZWQgd2hpY2gsIGluCit0aGlzIGNhc2UsIHdvdWxkIG1l YW4gcmVwZWF0aW5nIHRoZSBvYmplY3QgaW4gdGhlIGFyZ3VtZW50IGxpc3QuKSAgV2hlbgor cmVwbGFjaW5nIGFuIG9iamVjdCB3aXRoIGEgZGlmZmVyZW50IG9uZSwgcGFzc2luZyBib3Ro IHRoZSBuZXcgYW5kIG9sZAorb2JqZWN0cyBpcyBzdGlsbCBuZWNlc3NhcnkuCisKIAwKICog Q2hhbmdlcyBpbiBFbWFjcyAzMC4xIG9uIE5vbi1GcmVlIE9wZXJhdGluZyBTeXN0ZW1zCiAK ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwgYi9saXNwL2VtYWNzLWxp c3AvdnRhYmxlLmVsCmluZGV4IDE1YTQzMGY1YzI2Li5kZmNmYTQzNDEzNSAxMDA2NDQKLS0t IGEvbGlzcC9lbWFjcy1saXNwL3Z0YWJsZS5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvdnRh YmxlLmVsCkBAIC0yODMsOCArMjgzLDEzIEBAIHZ0YWJsZS1nb3RvLWNvbHVtbgogICAgICAg KGdvdG8tY2hhciAocHJvcC1tYXRjaC1iZWdpbm5pbmcgbWF0Y2gpKQogICAgIChlbmQtb2Yt bGluZSkpKQogCi0oZGVmdW4gdnRhYmxlLXVwZGF0ZS1vYmplY3QgKHRhYmxlIG9iamVjdCBv bGQtb2JqZWN0KQotICAiUmVwbGFjZSBPTEQtT0JKRUNUIGluIFRBQkxFIHdpdGggT0JKRUNU LiIKKyhkZWZ1biB2dGFibGUtdXBkYXRlLW9iamVjdCAodGFibGUgb2JqZWN0ICZvcHRpb25h bCBvbGQtb2JqZWN0KQorICAiVXBkYXRlIE9CSkVDVCdzIHJlcHJlc2VudGF0aW9uIGluIFRB QkxFLgorV2hlbiBPTEQtT0JKRUNUIGlzIG5vbi1uaWwsIHJlcGxhY2UgT0xELU9CSkVDVCB3 aXRoIE9CSkVDVCBhbmQgZGlzcGxheQoraXQuICBJbiBlaXRoZXIgY2FzZSwgaWYgdGhlIGV4 aXN0aW5nIG9iamVjdCBpcyBub3QgZm91bmQgaW4gdGhlCit0YWJsZSAoYmVpbmcgY29tcGFy ZWQgd2l0aCBgZXF1YWwnKSwgc2lnbmFsIGFuIGVycm9yLiIKKyAgKHVubGVzcyBvbGQtb2Jq ZWN0CisgICAgKHNldHEgb2xkLW9iamVjdCBvYmplY3QpKQogICAobGV0KiAoKG9iamVjdHMg KHZ0YWJsZS1vYmplY3RzIHRhYmxlKSkKICAgICAgICAgIChpbmhpYml0LXJlYWQtb25seSB0 KSkKICAgICA7OyBGaXJzdCByZXBsYWNlIHRoZSBvYmplY3QgaW4gdGhlIG9iamVjdCBzdG9y YWdlLgotLSAKMi4zMC4yCgo= --------------HMZoTgSB7suN2LfyCwsHNTnv--