From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#976: 23.0.60; incorrect code for filesets-get-filelist Date: Wed, 30 Dec 2015 08:42:20 -0800 (PST) Message-ID: <9fbcc27b-8b44-4a03-8837-0930f205e9d4@default> References: <002901c915bf$811df210$0200a8c0@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1451493806 30483 80.91.229.3 (30 Dec 2015 16:43:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Dec 2015 16:43:26 +0000 (UTC) Cc: 976@debbugs.gnu.org To: Andrew Hyatt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 30 17:43:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aEJq9-0004FP-UV for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Dec 2015 17:43:10 +0100 Original-Received: from localhost ([::1]:52996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEJq9-00048l-AO for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Dec 2015 11:43:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEJq5-00043K-GV for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2015 11:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aEJq2-0000SG-4F for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2015 11:43:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEJq2-0000S1-0T for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2015 11:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aEJq1-0007Dl-Sc for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2015 11:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2015 16:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 976-submit@debbugs.gnu.org id=B976.145149375527721 (code B ref 976); Wed, 30 Dec 2015 16:43:01 +0000 Original-Received: (at 976) by debbugs.gnu.org; 30 Dec 2015 16:42:35 +0000 Original-Received: from localhost ([127.0.0.1]:50559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aEJpa-0007D2-QU for submit@debbugs.gnu.org; Wed, 30 Dec 2015 11:42:35 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:24293) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aEJpY-0007Cp-Uk for 976@debbugs.gnu.org; Wed, 30 Dec 2015 11:42:33 -0500 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tBUGgQfr024502 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 30 Dec 2015 16:42:26 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tBUGgPKg007329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 30 Dec 2015 16:42:26 GMT Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id tBUGgPsT014322; Wed, 30 Dec 2015 16:42:25 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111029 Archived-At: > >> I'm looking into whether this still exists in Emacs 25. The code stil= l > >> is as you describe. Can you give steps to reproduce a user-visible bu= g? > > > > My guess is that no one has changed the filesets code, so yes, > > I'm pretty sure the problem is still there as reported. > > > > The user-visible bug is what I described. See the original > > report, which is quite detailed wrt the problem. > > > > See also the version of `filesets-get-filelist' that I sent (in > > attachment throw.el). It should be a fix. If it does not fix > > everything 100%, it is at least an improvement over the current > > code, which is completely broken for :tree. > > > > You can also contact the original author of filesets.el. As I > > said in the bug report, the GNU Emacs version does not respect > > what the author wrote, and it cannot possibly work (e.g., for > > :tree). > > > > I can't really help more than this now. I'm sure someone on > > the Emacs Dev team can fix it, but there is not much interest > > in filesets, it seems. > > > > Apparently there was only one person (Chong Yidong) who took a > > look at the bug report, and he just asked someone else to look > > into it. And that person never followed up (didn't even reply > > to Yidong's request, apparently). >=20 > OK, thanks for the reply. The original report seems lost (the bug > report at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D976 starts with > your response, in fact). But given what you've already provided, it > seems that someone familiar with filesets can reproduce and test your > fix. We'll leave the bug open until someone gets to it. Hi Andrew, No, AFAICT the thread at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D97= 6 is complete. It starts with my bug report, which begins this way, continuing from the bug title, which is "incorrect code for filesets-get-filelist": The part that treats a :tree of the code defining `filesets-get-filelist' is not correct and never could have been correct. And it does not correspond to the (correct) code from the filesets author. One wonders if the GNU Emacs code was ever tested. Thx - Drew