From: Drew Adams <drew.adams@oracle.com>
To: Andrew Hyatt <ahyatt@gmail.com>
Cc: 976@debbugs.gnu.org
Subject: bug#976: 23.0.60; incorrect code for filesets-get-filelist
Date: Wed, 30 Dec 2015 08:42:20 -0800 (PST) [thread overview]
Message-ID: <9fbcc27b-8b44-4a03-8837-0930f205e9d4@default> (raw)
In-Reply-To: <m27fjwiqzm.fsf@gmail.com>
> >> I'm looking into whether this still exists in Emacs 25. The code still
> >> is as you describe. Can you give steps to reproduce a user-visible bug?
> >
> > My guess is that no one has changed the filesets code, so yes,
> > I'm pretty sure the problem is still there as reported.
> >
> > The user-visible bug is what I described. See the original
> > report, which is quite detailed wrt the problem.
> >
> > See also the version of `filesets-get-filelist' that I sent (in
> > attachment throw.el). It should be a fix. If it does not fix
> > everything 100%, it is at least an improvement over the current
> > code, which is completely broken for :tree.
> >
> > You can also contact the original author of filesets.el. As I
> > said in the bug report, the GNU Emacs version does not respect
> > what the author wrote, and it cannot possibly work (e.g., for
> > :tree).
> >
> > I can't really help more than this now. I'm sure someone on
> > the Emacs Dev team can fix it, but there is not much interest
> > in filesets, it seems.
> >
> > Apparently there was only one person (Chong Yidong) who took a
> > look at the bug report, and he just asked someone else to look
> > into it. And that person never followed up (didn't even reply
> > to Yidong's request, apparently).
>
> OK, thanks for the reply. The original report seems lost (the bug
> report at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=976 starts with
> your response, in fact). But given what you've already provided, it
> seems that someone familiar with filesets can reproduce and test your
> fix. We'll leave the bug open until someone gets to it.
Hi Andrew,
No, AFAICT the thread at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=976
is complete. It starts with my bug report, which begins this way,
continuing from the bug title, which is "incorrect code for
filesets-get-filelist":
The part that treats a :tree of the code defining
`filesets-get-filelist' is not correct and never could have been
correct. And it does not correspond to the (correct) code from the
filesets author. One wonders if the GNU Emacs code was ever tested.
Thx - Drew
next prev parent reply other threads:[~2015-12-30 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 16:40 bug#976: 23.0.60; incorrect code for filesets-get-filelist Drew Adams
2008-09-16 20:44 ` Drew Adams
2008-09-16 21:28 ` Drew Adams
2015-12-30 1:16 ` Andrew Hyatt
2015-12-30 1:32 ` Drew Adams
2015-12-30 2:56 ` Andrew Hyatt
2015-12-30 16:42 ` Drew Adams [this message]
2020-11-20 15:39 ` Mauro Aranda
2020-11-21 22:40 ` Drew Adams
2020-11-24 11:05 ` Mauro Aranda
-- strict thread matches above, loose matches on Subject: below --
2008-09-19 4:07 cyd
2008-09-19 7:58 ` Thomas Link
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fbcc27b-8b44-4a03-8837-0930f205e9d4@default \
--to=drew.adams@oracle.com \
--cc=976@debbugs.gnu.org \
--cc=ahyatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).