From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44611: Prefix arg for xref-goto-xref Date: Fri, 25 Dec 2020 18:01:20 +0200 Message-ID: <9f7729c3-af46-1e79-65aa-adb98f69e38f@yandex.ru> References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 25 17:02:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kspXp-0005pD-Gr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 17:02:21 +0100 Original-Received: from localhost ([::1]:42430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kspXo-0002uh-FJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 11:02:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kspXW-0002tg-Ow for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 11:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kspXW-0003YN-H2 for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 11:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kspXW-0007gd-EP for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 11:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2020 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44611 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44611-submit@debbugs.gnu.org id=B44611.160891209129505 (code B ref 44611); Fri, 25 Dec 2020 16:02:02 +0000 Original-Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 16:01:31 +0000 Original-Received: from localhost ([127.0.0.1]:58068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kspX1-0007fp-3c for submit@debbugs.gnu.org; Fri, 25 Dec 2020 11:01:31 -0500 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:33688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kspWz-0007fd-Pc for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 11:01:30 -0500 Original-Received: by mail-ej1-f52.google.com with SMTP id b9so6689237ejy.0 for <44611@debbugs.gnu.org>; Fri, 25 Dec 2020 08:01:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NURuZkWWKKj1uX9ONfCm1zqD20w90CVsMOU7JPaEugg=; b=PW3fubon2i83shb/4A6KaqomuWxOLBrICR+/Edegi4uDiNYDULyiLT7RMJqTRzk9tK EyXnibvre1isA1KggrGpJ3FMoAlxdb/VxCppEfNVnFel5uAKmDh9UFij8XiFMor0UyY/ qNQiATXy/8Y7jf+C/irx5FznX0A7N+6obLZtJs2mfdfY8wLGli/LDH1BUv9JQ7+gZ+zW KTif76+FhbeXU8hGDnUneO5ASJlMs//SxE3qZhlVMEVjyu0uMvsF8+vK53mvq75c9FFo aE8H+KFjpWxJd0r2LwuZYKTlQeWCc3K+NZJF06kTVQjwFFlVBV9l5fX5eSXVT+oXL4aJ XwfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NURuZkWWKKj1uX9ONfCm1zqD20w90CVsMOU7JPaEugg=; b=cIOoxsYDdKXWaKvjKz90sMAxJS9khQ1OwV/mXm7wAPGF50ZpuOjpbk/c7rEuFIgijI fUERINNyhIZ3rXs11Er8aXlgfLHX4KFIZxYla/xGyXSeniqC6LpUcZ24iwHcWsu+xAVP JfqZ227VjEqeMZsPjLqFgCxVHpmkusaXI97kmk/anHQl3xOSIxSVOQ8ZvqZrXBodhh4K uUgvyZGck0eUfz0YdYeww3fWu/uEGl3MA+66h9n+s7KATVoDgEcwwKA5eQB19U+rzau2 yqC3v1iKrWf3ma4WfVmSnsf2UdHw8fvTtayzmB2WdaMwoRi4XM12zX/npxMkM7wDlhQx 1zLw== X-Gm-Message-State: AOAM533nrLJVVZzy/VnHmbSfhWRePKzDTsoAup2Bz363/+Tcuecho6z7 /Wjjquk81hh/KlbfZ8zxq3ZJCc5mXinL7w== X-Google-Smtp-Source: ABdhPJw6XGzb+v35EpDIK2cBTzGJ7ivdN8SNJ1K4KFiXNLbKLtn47d4JwXJ2lmjV0F2GLY7Q8B6LPQ== X-Received: by 2002:a17:906:34ca:: with SMTP id h10mr32561686ejb.417.1608912083605; Fri, 25 Dec 2020 08:01:23 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id b19sm33124030edx.47.2020.12.25.08.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Dec 2020 08:01:22 -0800 (PST) In-Reply-To: <83pn2znloa.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196705 Archived-At: On 24.12.2020 19:44, Eli Zaretskii wrote: > There's only one rule: not to make backward-incompatible changes > without a very good reason. That is not limited to changes in > functions and APIs, key bindings are definitely included. In fact, I > think incompatible changes in key bindings are even worse than changes > in code, since they might go against muscle memory, and nothing can > fix that except a long and painful process of unlearning. I'm pretty sure backward incompatible changes in code can be much worse. They can break the code a user has been relying on for many years, and the user might not have the technical ability to fix that code. Adapting to a new binding is something that is within anybody's capability, though. We shouldn't do those frivolously either, but I believe it is something we should be less worried about. > I've reviewed all the NEWS since v24.1, and found only one > incompatible change in key bindings -- which started by declaring the > existing binding obsolete. So I think we change key bindings in > incompatible ways only very rarely and carefully, and that is a Good > Thing. It has never been my impression that we are too careful about the bindings. Let's review the history. NEWS.27: the function 'package-menu-filter-by-keyword' has been renamed from 'package-menu-filter'. Its keybinding has also been changed to '/ k' (from 'f') That binding was changes without an obsoletion period, whereas the function itself still has an obsolete-alias. Both are good things, IMO. NEWS.26: *** 'vc-region-history' is now bound to 'C-x v h', replacing the older 'vc-insert-headers' binding. The binding changed to a function with an entirely different behavior. NEWS.25: ** The old 'C-x w' bindings in 'hi-lock-mode' are officially deprecated in favor of the global 'M-s h' bindings introduced in Emacs 23.1. They'll disappear soon. This is probably the example you're referring to. Note that it talks about a whole family of bindings, not just one, and that those bindings almost certainly have had their users. They have probably been the main way to use hi-lock-mode's functionality at some point in time. NEWS.24: ** New Ibuffer `derived-mode' filter, bound to `/ M'. The old binding for `/ M' (filter by used-mode) is now bound to `/ m'. Bindings changed in an incompatible way (the previous binding had been there for 12 years). ** Dired *** The minibuffer default for `=' (`dired-diff') has changed. It is now the backup file for the file at point, if one exists. In Transient Mark mode the default is the file at the active mark. *** `M-=' is no longer bound to `dired-backup-diff' in Dired buffers. The global binding for `M-=', `count-words-region' is in effect. ** Ruby mode I have omitted a few others too, where the changes have seemingly been really critical and thus unlike the present issue. To sum up, we don't change bindings often (in part because it's hard to get everyone to agree on a new default, I guess), but we do that from time to time. And out of all examples, there was only one when we announced the obsoletion first. > Given the single precedent I found, I'm fine with declaring the > current binding of TAB obsolete and providing a replacement for it > ('b'? 'q'?), so that we could replace it in some future version after > 28, if that is okay with you and Juri. Thank you, this is at least one path forward we can take, which is good to have. But if that is what we have to do to change that binding, it's pretty costly time-wise, so let's discuss some alternatives first.