From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file Date: Tue, 20 Dec 2022 16:29:31 -0800 Message-ID: <9f56f995-c03d-a10e-ac18-b873af8589dc@gmail.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------fHCBRKMquYj5LnhzxYdjJWRk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31923"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org To: Milan Zimmermann , 59545@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 21 01:30:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7n06-00089y-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Dec 2022 01:30:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7mzo-00029m-Ny; Tue, 20 Dec 2022 19:30:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7mzj-00027r-Ag for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2022 19:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7mzi-0006gv-VW for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2022 19:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7mzi-0006j9-QI for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2022 19:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Dec 2022 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59545 X-GNU-PR-Package: emacs Original-Received: via spool by 59545-submit@debbugs.gnu.org id=B59545.167158258025818 (code B ref 59545); Wed, 21 Dec 2022 00:30:02 +0000 Original-Received: (at 59545) by debbugs.gnu.org; 21 Dec 2022 00:29:40 +0000 Original-Received: from localhost ([127.0.0.1]:48133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7mzM-0006iM-Aj for submit@debbugs.gnu.org; Tue, 20 Dec 2022 19:29:40 -0500 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:36821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7mzK-0006iG-P5 for 59545@debbugs.gnu.org; Tue, 20 Dec 2022 19:29:39 -0500 Original-Received: by mail-pg1-f178.google.com with SMTP id s196so9417973pgs.3 for <59545@debbugs.gnu.org>; Tue, 20 Dec 2022 16:29:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:cc:references:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=3dyzvdZpfnTKbfpQhDa/5syrkmddQsF0W4ANYRCgdSg=; b=embVc4XvRXEUn22dk00PeMsKBlpYtfngMYGr8sRzZ/6PECbNNf3hqmgDXXOvT1OKol Hlb5kvFPh6EVM15li53S7/HwDXfY4qsgOmCkQ/tmkmPGubXt6nbqUxXlGDC31TJ9mzIt cqUkNyVAqdNtxFFeRiV2wKAjQId5G+N7qVHX8Vd77GO8cSCodwTBXGKYBD/m5NbYqdZM I4w8YdyTEAkwaUwwtf6ln25Y8iqqeL601+9ZVassAbF5xmcMX65UMXLLUOjngVQWJGab 79Unh5UNakeVX7PBJ/lokEGEw4LiQr0aoiO3dmZmErvdaVSaZXus6td5HaN9r743J3WP 31Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:cc:references:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3dyzvdZpfnTKbfpQhDa/5syrkmddQsF0W4ANYRCgdSg=; b=GCDMMtFHFq3FDsz+VQYz8bL2DLuQjS5bmGFhNKDnjLfnT4bRQeEMlUax0VFTaSKxyB XbS+dMOgEh8+ZzxnzU8VHHHjZXYqHAj+PSHBWpuxnXfVg1SZDsnQ78y+BMNiImKXiTPf cmjUGMj72vwJ83si4HZGcMIQui80whBaGG9Uq5gBY3ykxc/ZLK4lwDuDaBHmOUBF3lNl C7VpAjCTcCJ+eyvRywQF7iEeXSFKZ8Jwq3tlFbNu+NKusw4Bw3IQ5MUfbw/MS4SniW0r t9R9SZoPO8ik7XXWmUIwyF9W1KQAIWbZ5nsduhlJKra7b0b3y77dwX2dRwT/2vYOv5JU fPcQ== X-Gm-Message-State: AFqh2krhSWktRQQkXSFUzpuZEIn0A0uptJADdv2AI9zhqYLj2O/FY8+1 AXCG6/BDzZMl7w2J57XeRKk= X-Google-Smtp-Source: AMrXdXsqMBoOic347O22p9ThA5jfAU3vEUU7oy44CYv8+1nYKT3Xqb4nOeD6QPGRU/8zclr55c05mg== X-Received: by 2002:a62:ab16:0:b0:56b:d68d:7136 with SMTP id p22-20020a62ab16000000b0056bd68d7136mr284759pff.11.1671582572908; Tue, 20 Dec 2022 16:29:32 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k5-20020aa79985000000b005623f96c24bsm9213382pfh.89.2022.12.20.16.29.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 16:29:32 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251547 Archived-At: This is a multi-part message in MIME format. --------------fHCBRKMquYj5LnhzxYdjJWRk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/20/2022 4:18 PM, Jim Porter wrote: > Attached is a patch series to fix this, with a bunch of new tests. I > also fixed a related issue where redirecting to /dev/null could clobber > your other redirects. (There's *also* an issue that should be fixed for > the release branch; I'll send that in a separate message.) Eli, this is the patch for the release branch (it corresponds to part 0003 of the patch series for master). Is this ok to merge? It's a regression that was introduced in Emacs 28.1, and the fix is pretty simple. --------------fHCBRKMquYj5LnhzxYdjJWRk Content-Type: text/plain; charset=UTF-8; name="0001-When-redirecting-to-the-null-device-in-Eshell-use-de.patch" Content-Disposition: attachment; filename*0="0001-When-redirecting-to-the-null-device-in-Eshell-use-de.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiMDRmNDJjY2EyNzJiOWEwZjNiNWUzMTY3Y2U5NTY1MjNiMTYxYTdlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMjAgRGVjIDIwMjIgMTY6MjA6NTAgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIHJlZGlyZWN0aW5nIHRvIHRoZSBudWxsIGRldmljZSBpbiBFc2hlbGwsIHVz ZQogIi9kZXYvbnVsbCIKClRoaXMgaXMgc28gdGhhdCB1c2VycyBjYW4gdHlwZSAiY21kIC4u LiA+IC9kZXYvbnVsbCIgaW4gRXNoZWxsIG5vCm1hdHRlciB3aGF0IHRoZWlyIHN5c3RlbSdz IG51bGwgZGV2aWNlIGlzIGNhbGxlZC4gIFRoaXMgcGFydGlhbGx5CnJldmVydHMgNjdhOGJk YjkwYzliNTg2NWI3ZjE3MjkwYzcxMzViMWE1NDU4YzM2ZC4KCkRvIG5vdCBtZXJnZSB0byBt YXN0ZXIuCgoqIGxpc3AvZXNoZWxsL2VzaC1pby5lbCAoZXNoZWxsLXNldC1vdXRwdXQtaGFu ZGxlKTogVXNlICIvZGV2L251bGwiCmxpdGVyYWxseS4KLS0tCiBsaXNwL2VzaGVsbC9lc2gt aW8uZWwgfCA0ICsrKy0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtaW8uZWwgYi9saXNwL2Vz aGVsbC9lc2gtaW8uZWwKaW5kZXggNDYyMDU2NWY4NTcuLjZkZjQwOTE0MDYwIDEwMDY0NAot LS0gYS9saXNwL2VzaGVsbC9lc2gtaW8uZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWlvLmVs CkBAIC0zNDIsNyArMzQyLDkgQEAgZXNoZWxsLXNldC1vdXRwdXQtaGFuZGxlCiAgICh3aGVu IHRhcmdldAogICAgIChsZXQgKChoYW5kbGVzIChvciBoYW5kbGVzIGVzaGVsbC1jdXJyZW50 LWhhbmRsZXMpKSkKICAgICAgIChpZiAoYW5kIChzdHJpbmdwIHRhcmdldCkKLSAgICAgICAg ICAgICAgIChzdHJpbmc9IHRhcmdldCAobnVsbC1kZXZpY2UpKSkKKyAgICAgICAgICAgICAg IDs7IFRoaXMgc2hvdWxkIGJlIHRoZSBsaXRlcmFsIHN0cmluZyAiL2Rldi9udWxsIiwgbm90 CisgICAgICAgICAgICAgICA7OyBgbnVsbC1kZXZpY2UnLgorICAgICAgICAgICAgICAgKHN0 cmluZz0gdGFyZ2V0ICIvZGV2L251bGwiKSkKICAgICAgICAgICAoYXNldCBoYW5kbGVzIGlu ZGV4IG5pbCkKICAgICAgICAgKGxldCAoKHdoZXJlIChlc2hlbGwtZ2V0LXRhcmdldCB0YXJn ZXQgbW9kZSkpCiAgICAgICAgICAgICAgIChjdXJyZW50IChjYXIgKGFyZWYgaGFuZGxlcyBp bmRleCkpKSkKLS0gCjIuMjUuMQoK --------------fHCBRKMquYj5LnhzxYdjJWRk--