unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 21090@debbugs.gnu.org
Subject: bug#21090: 25.0.50; `condition-case-no-debug': Please fix indentation & highlighting
Date: Sat, 18 Jul 2015 13:07:01 -0700 (PDT)	[thread overview]
Message-ID: <9f06ef83-8877-41ef-b6d5-ce551d9826bb@default> (raw)

In Emacs 23 you introduced `condition-case-no-debug'.  In Emacs 24.1 you
immediately turned around and deprecated it - to improve the name.
Hindsight is 20x20, but such things happen.

What should not happen is that when you make such a replacement,
especially for a simple renaming, you break the behavior of the alias
that is deprecated.

You should at least let the alias act the same as the newly named
replacement (and in the case of just a renaming, act the same as it did
before).  Especially for a macro, you should reinstate the highlighting
and, especially, the indentation, so one can use recent Emacs on code
that must work also with Emacs 23.

This macro is one case in point.  Please restore at least the
indentation, and preferably the font-lock highlighting as well.

And then please search for other such renamings of things that had
indentation declarations and were font-locked, and fix them too.

Thx.


In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'





             reply	other threads:[~2015-07-18 20:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-18 20:07 Drew Adams [this message]
2015-07-20  0:19 ` bug#21090: 25.0.50; `condition-case-no-debug': Please fix indentation & highlighting Stefan Monnier
2015-07-20 15:01   ` Drew Adams
2015-07-20 22:54     ` Stefan Monnier
2015-07-20 23:30       ` Drew Adams
2016-04-30 21:24     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f06ef83-8877-41ef-b6d5-ce551d9826bb@default \
    --to=drew.adams@oracle.com \
    --cc=21090@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).