From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: brennan@umanwizard.com, 61521@debbugs.gnu.org
Subject: bug#61521: "default" is now the first item returned from (font-faces), breaking various code.
Date: Wed, 15 Feb 2023 14:11:55 +0000 [thread overview]
Message-ID: <9e9ed8043fd6413e6183@heytings.org> (raw)
In-Reply-To: <83ttznavsp.fsf@gnu.org>
>> Thanks. It seems the change you describe is not a recent one: the
>> first element of the list returned by 'face-list' is 'default' in Emacs
>> 27, 28, 29 and 30. (This is caused by e3b8ddd500, since which frame
>> faces are stored in a hash table instead of an alist.)
>
> Right. So I wonder whether we should remove the nreverse call in
> face-set-after-frame-default. WDYT?
>
There are three occurrences of '(nreverse (face-list))': one in
facemenu-complete-face-list, which seems to date from the 1990s, one in
x-create-frame-with-faces, which was added by e3b8ddd500 "to handle subtle
semantic change to how frame faces propagate, which otherwise breaks frame
creation with reverse video enabled (bug#41200)", and the third one in
'face-set-after-frame-default'.
The comment there is definitely outdated and should be removed, but given
that '(nreverse (face-list))' is placed in a dolist whose body starts with
'(face-spec-recalc face frame)', like in x-create-frame-with-faces, I'm
not sure the nreverse can be removed without introducing a subtle bug.
It is probably safer to leave the code unchanged.
next prev parent reply other threads:[~2023-02-15 14:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 0:31 bug#61521: "default" is now the first item returned from (font-faces), breaking various code Brennan Vincent
2023-02-15 0:52 ` Brennan Vincent
2023-02-15 1:00 ` Gregory Heytings
2023-02-15 1:06 ` Brennan Vincent
2023-02-15 9:00 ` Gregory Heytings
2023-02-15 13:43 ` Eli Zaretskii
2023-02-15 14:11 ` Gregory Heytings [this message]
2023-02-17 22:17 ` Kai Ma
2023-02-18 6:49 ` Eli Zaretskii
2023-02-18 6:54 ` Kai Ma
2023-02-18 7:40 ` Eli Zaretskii
2023-02-15 12:58 ` Eli Zaretskii
2023-02-15 14:01 ` Brennan Vincent
2023-02-15 14:19 ` Gregory Heytings
2023-02-15 14:24 ` Eli Zaretskii
2023-02-15 16:19 ` Brennan Vincent
2023-02-17 8:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e9ed8043fd6413e6183@heytings.org \
--to=gregory@heytings.org \
--cc=61521@debbugs.gnu.org \
--cc=brennan@umanwizard.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).