From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Wed, 15 Feb 2023 13:37:46 +0000 Message-ID: <9e9ed8043fc8bfe49bfe@heytings.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> <83ttzsk6v4.fsf@gnu.org> <83wn4le8s3.fsf@gnu.org> <0f053182b02103503c26@heytings.org> <83pmaccnz7.fsf@gnu.org> <0f053182b04357300cb1@heytings.org> <83lel0chku.fsf@gnu.org> <0f053182b00a59a41caa@heytings.org> <835yc3cdhk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6810"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 14:38:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSHzC-0001UH-3c for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 14:38:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSHz6-0003CW-Eh; Wed, 15 Feb 2023 08:38:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSHz0-0003BZ-Bw for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 08:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSHyz-0006dT-Nr for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 08:38:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSHyz-0000uB-H7 for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 08:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 13:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16764682733462 (code B ref 56682); Wed, 15 Feb 2023 13:38:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 15 Feb 2023 13:37:53 +0000 Original-Received: from localhost ([127.0.0.1]:58241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSHyr-0000tl-2X for submit@debbugs.gnu.org; Wed, 15 Feb 2023 08:37:53 -0500 Original-Received: from heytings.org ([95.142.160.155]:58016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSHyl-0000tQ-I2 for 56682@debbugs.gnu.org; Wed, 15 Feb 2023 08:37:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1676468266; bh=YFO9YV761qUaGmvTIHC3insCKMPuFN9RneCIXIIA3cc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ieyNWaeCDdc7BcrlA/5BTVuwr2ybOKPKI5ULqj0UJFp6m3thcF6sXgtSSKoiJnZcS f9ZeobhOWketDeUJ2239cW6Vhq1/GORxVgSJ5D/VobxJPE5MOnrHa3tZfr3kwcqslk Sebe99IhCRGyLwDu9InVPnE24MFluym5gY7sAGSShSv0pqRQddFweANKRrfKB3weLg op2f81gTc9iSdU7ijmnJbknIikPGqF7x7xjQbPztiD/W+HF+nwJH2hbVQdouq4aH/j W0t1kO14xongUS8yT0anWAelC4ZeR8zJua3SJeZJgIUDutfboX6nW+83J8X3x1uF8B qL3E5cQDQ5izw== In-Reply-To: <835yc3cdhk.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255697 Archived-At: > > Hmm... I'm probably missing something, but doesn't > narrowing_locks_remove permanently removes the lock from the restriction > in the buffer? And if so, don't we want to restore the lock after > whatever we need to do in a widened buffer is done? > Yes: that's what the "record_unwind_protect (save_restriction_restore, save_restriction_save ());" does. The two places where 'narrowing_locks_remove_in_current_buffer' is not preceded by that statement are the two places where we indeed don't want to restore the restrictions after widening: Ferase_buffer and Fcall_process_region.