From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61022: 28.2.50; Mouse tracking of high coordinates not working in rxvt-unicode Date: Tue, 24 Jan 2023 21:09:03 -0800 Message-ID: <9e731b2056f75065a6b603aa80903400@finder.org> References: <87sfg2nyy5.fsf@home.thecybershadow.net> <83y1ptie7y.fsf@gnu.org> <6f9506a6b306d47ef6064747c4cecb75@finder.org> <831qnki0hh.fsf@gnu.org> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Roundcube Webmail/1.4.13 Cc: git@vladimir.panteleev.md, 61022@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 06:10:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKY3M-0008SB-Ox for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 06:10:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKY2u-0007k8-Qy; Wed, 25 Jan 2023 00:10:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKY2t-0007jw-E2 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 00:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKY2t-0004gM-5s for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 00:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKY2s-0003bD-FE for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 00:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 05:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61022 X-GNU-PR-Package: emacs Original-Received: via spool by 61022-submit@debbugs.gnu.org id=B61022.167462334813757 (code B ref 61022); Wed, 25 Jan 2023 05:10:02 +0000 Original-Received: (at 61022) by debbugs.gnu.org; 25 Jan 2023 05:09:08 +0000 Original-Received: from localhost ([127.0.0.1]:58044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKY1z-0003Zo-Ry for submit@debbugs.gnu.org; Wed, 25 Jan 2023 00:09:08 -0500 Original-Received: from greenhill.hpalace.com ([192.155.80.58]:38044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKY1x-0003Zc-1L for 61022@debbugs.gnu.org; Wed, 25 Jan 2023 00:09:05 -0500 Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 02C2515F; Wed, 25 Jan 2023 05:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1674623344; bh=/oY7IdOaXD01AgrQarsJVAs3KQvJEk7ezHKWHTJ3djU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mgCTDh/LICDNIrvn9B3RcVf9xeRBR+TwEtR5BjVk5hPhbZhyKTVzJrXHqeMd65nk6 rCHAAonhLTCLUuSEzdSI/GJeUhA5Gdkg21c6QeCsrayGDD8ozHfSG9ceuS68pA2wMN 5QXUSB/JoawC9lUt2uuZdH/R95gSFNv760cDKf2bUH5OxL5zZV5Ho9+UPJjv1duira j4tpaThX3PkiVyL2C8nd/A5IcTYE5qLZchICOLcXgLGGUalgmYFQg9d9JPHSLxEcD8 mReDIQspq7/gnHNjy+qDR32FAxk3i4n8mzOUmeGsEu6j18PhldcPpYxmPcKffyiU+I QvKjiOwpkASOg== In-Reply-To: <831qnki0hh.fsf@gnu.org> X-Sender: jared@finder.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254100 Archived-At: On 2023-01-24 4:24 am, Eli Zaretskii wrote: >> Date: Mon, 23 Jan 2023 22:56:09 -0800 >> From: Jared Finder >> Cc: git@vladimir.panteleev.md, 61022@debbugs.gnu.org >> >> The change mostly works as inherit-input-method also causes UTF-8 >> decoding to happen deep in read_char at the C level. (Is this >> intentional? I assume so because read-char just reads single bytes >> normally.) > > Yes, that's how we decode keyboard input using keyboard-coding-system. > >> However, I think the following change is more appropriate: >> >> - (read-char nil nil 0.1)) >> + ;; Read a character with input method conversion enabled >> + ;; but no conversion to force read-char to decode UTF-8 >> + ;; byte sequences. >> + (let ((input-method-function nil)) >> + (read-char nil t 0.1))) >> >> This way we don't apply an actual input method conversion to >> characters. >> For example, without this additional change, if the 'british input >> method was active, the # ==> £ conversion would >> happen, causing mouse events with X=2 to instead have X=131. > > OK, but shouldn't we also use INHERIT-INPUT-METHOD = t in the call to > read-char only when xterm-mouse-utf-8 option is set? Otherwise, we > rely on read-char to not perform any conversions, but why rely on that > if we already know we don't want any conversions in that case? Using > nil when xterm-mouse-utf-8 is unset sounds like a more future-proof > change, no? I think that's not just future-proof, it's more correct. -- MJF