unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
blob 9e1352668dcf4fb63c64bce918f3b621b5f88036 13926 bytes (raw)
name: test/lisp/erc/erc-join-tests.el 	 # note: path name is non-authoritative(*)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
 
;;; erc-join-tests.el --- Tests for erc-join.  -*- lexical-binding:t -*-

;; Copyright (C) 2020-2021 Free Software Foundation, Inc.

;; This file is part of GNU Emacs.
;;
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published
;; by the Free Software Foundation, either version 3 of the License,
;; or (at your option) any later version.
;;
;; GNU Emacs is distributed in the hope that it will be useful, but
;; WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
;; General Public License for more details.
;;
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.

;;; Code:

(require 'ert-x)
(require 'erc-join)
(require 'erc-networks)

(ert-deftest erc-autojoin-channels--connect ()
  (should (eq erc-autojoin-timing 'connect))
  (should (= erc-autojoin-delay 30))
  (should-not erc--autojoin-timer)

  (let (calls
        common
        erc-kill-server-hook)

    (cl-letf (((symbol-function 'erc-server-send)
               (lambda (line) (push line calls))))

      (setq common
            (lambda ()
              (ert-with-test-buffer (:name "foonet")
                (erc-mode)
                (setq erc-server-process
                      (start-process "true" (current-buffer) "true")
                      erc-network 'FooNet
                      erc-session-server "irc.gnu.chat"
                      erc-server-current-nick "tester"
                      erc--session (erc--sid-create nil)
                      erc-server-announced-name "foo.gnu.chat")
                (set-process-query-on-exit-flag erc-server-process nil)
                (erc-autojoin-channels erc-server-announced-name
                                       "tester")
                (should-not erc--autojoin-timer))))

      (ert-info ("Join immediately on connect; server")
        (let ((erc-autojoin-channels-alist '(("\\.gnu\\.chat\\'" "#chan"))))
          (funcall common))
        (should (equal (pop calls) "JOIN #chan")))

      (ert-info ("Join immediately on connect; network")
        (let ((erc-autojoin-channels-alist '((FooNet "#chan"))))
          (funcall common))
        (should (equal (pop calls) "JOIN #chan")))

      (ert-info ("Do nothing; server")
        (let ((erc-autojoin-channels-alist '(("bar\\.gnu\\.chat" "#chan"))))
          (funcall common))
        (should-not calls))

      (ert-info ("Do nothing; network")
        (let ((erc-autojoin-channels-alist '((BarNet "#chan"))))
          (funcall common))
        (should-not calls)))))

(ert-deftest erc-autojoin-channels--delay ()
  (should (eq erc-autojoin-timing 'connect))
  (should (= erc-autojoin-delay 30))
  (should-not erc--autojoin-timer)

  (let (calls
        common
        erc-kill-server-hook
        (erc-autojoin-timing 'ident)
        (erc-autojoin-delay 0.05))

    (cl-letf (((symbol-function 'erc-server-send)
               (lambda (line) (push line calls)))
              ((symbol-function 'erc-autojoin-after-ident)
               (lambda (&rest _r) (error "I ran but shouldn't have"))))

      (setq common
            (lambda ()
              (ert-with-test-buffer (:name "foonet")
                (erc-mode)
                (setq erc-server-process
                      (start-process "true" (current-buffer) "true")
                      erc-network 'FooNet
                      erc-session-server "irc.gnu.chat"
                      erc-server-current-nick "tester"
                      erc--session (erc--sid-create nil)
                      erc-server-announced-name "foo.gnu.chat")
                (set-process-query-on-exit-flag erc-server-process nil)
                (should-not erc--autojoin-timer)
                (erc-autojoin-channels erc-server-announced-name "tester")
                (should erc--autojoin-timer)
                (should-not calls)
                (sleep-for 0.1))))

      (ert-info ("Deferred on connect; server")
        (let ((erc-autojoin-channels-alist '(("\\.gnu\\.chat\\'" "#chan"))))
          (funcall common))
        (should (equal (pop calls) "JOIN #chan")))

      (ert-info ("Deferred on connect; network")
        (let ((erc-autojoin-channels-alist '((FooNet "#chan"))))
          (funcall common))
        (should (equal (pop calls) "JOIN #chan")))

      (ert-info ("Do nothing; server")
        (let ((erc-autojoin-channels-alist '(("bar\\.gnu\\.chat" "#chan"))))
          (funcall common))
        (should-not calls)))))

(ert-deftest erc-autojoin-channels--ident ()
  (should (eq erc-autojoin-timing 'connect))
  (should (= erc-autojoin-delay 30))
  (should-not erc--autojoin-timer)

  (let (calls
        common
        erc-kill-server-hook
        (erc-autojoin-timing 'ident))

    (cl-letf (((symbol-function 'erc-server-send)
               (lambda (line) (push line calls))))

      (setq common
            (lambda ()
              (ert-with-test-buffer (:name "foonet")
                (erc-mode)
                (setq erc-server-process
                      (start-process "true" (current-buffer) "true")
                      erc-network 'FooNet
                      erc-server-current-nick "tester"
                      erc--session (erc--sid-create nil)
                      erc-server-announced-name "foo.gnu.chat")
                (set-process-query-on-exit-flag erc-server-process nil)
                (erc-autojoin-after-ident 'FooNet "tester")
                (should-not erc--autojoin-timer))))

      (ert-info ("Join on NickServ hook; server")
        (let ((erc-autojoin-channels-alist '(("\\.gnu\\.chat\\'" "#chan"))))
          (funcall common))
        (should (equal (pop calls) "JOIN #chan")))

      (ert-info ("Join on NickServ hook; network")
        (let ((erc-autojoin-channels-alist '((FooNet "#chan"))))
          (funcall common))
        (should (equal (pop calls) "JOIN #chan"))))))

(defun erc-join-tests--autojoin-add--common (setup)
  (let (calls
        erc-autojoin-channels-alist)

    (cl-letf (((symbol-function 'erc-handle-parsed-server-response)
               (lambda (_p m) (push m calls))))

      (ert-with-test-buffer (:name "foonet")
        (erc-mode)
        (setq erc-server-process
              (start-process "true" (current-buffer) "true")
              erc-server-current-nick "tester"
              erc-isupport-parameters '((CHANTYPES "&#"))
              erc-server-announced-name "foo.gnu.chat")
        (funcall setup)
        (set-process-query-on-exit-flag erc-server-process nil)
        (should-not calls)

        (ert-info ("Add #chan")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u JOIN #chan")
          (should calls)
          (erc-autojoin-add erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist '((FooNet "#chan")))))

        (ert-info ("More recently joined chans are prepended")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u JOIN #spam")
          (should calls)
          (erc-autojoin-add erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '((FooNet "#spam" "#chan")))))

        (ert-info ("Duplicates skipped")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u JOIN #chan")
          (should calls)
          (erc-autojoin-add erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '((FooNet "#spam" "#chan")))))

        (ert-info ("Server used for local channel")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u JOIN &local")
          (should calls)
          (erc-autojoin-add erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '(("foo\\.gnu\\.chat" "&local")
                           (FooNet "#spam" "#chan")))))))))

(ert-deftest erc-autojoin-add--network ()
  (erc-join-tests--autojoin-add--common
   (lambda () (setq erc-network 'FooNet
                    erc--session (erc--sid-create nil)))))

(ert-deftest erc-autojoin-add--session-id ()
  (erc-join-tests--autojoin-add--common
   (lambda () (setq erc-network 'invalid
                    erc--session (erc--sid-create 'FooNet)))))

(ert-deftest erc-autojoin-add--server ()
  (let (calls
        erc-autojoin-channels-alist)

    (cl-letf (((symbol-function 'erc-handle-parsed-server-response)
               (lambda (_p m) (push m calls))))

      (ert-info ("Network unavailable, announced name used")
        (setq erc-autojoin-channels-alist nil)
        (ert-with-test-buffer (:name "foonet")
          (erc-mode)
          (setq erc-server-process
                (start-process "true" (current-buffer) "true")
                erc-server-current-nick "tester"
                erc-server-announced-name "foo.gnu.chat"
                erc--session (make-erc--sid)) ; assume too early
          (set-process-query-on-exit-flag erc-server-process nil)
          (should-not calls)
          (erc-parse-server-response erc-server-process
                                     ":tester!~u@q6ddatxcq6txy.irc JOIN #chan")
          (should calls)
          (erc-autojoin-add erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '(("gnu.chat" "#chan")))))))))

(defun erc-join-tests--autojoin-remove--common (setup)
  (let (calls
        erc-autojoin-channels-alist)

    (cl-letf (((symbol-function 'erc-handle-parsed-server-response)
               (lambda (_p m) (push m calls))))

      (setq erc-autojoin-channels-alist ; mutated, so can't quote whole thing
            (list '(FooNet "#spam" "##chan")
                  '(BarNet "#bar" "##bar")
                  '("foo\\.gnu\\.chat" "&local")))

      (ert-with-test-buffer (:name "foonet")
        (erc-mode)
        (setq erc-server-process
              (start-process "true" (current-buffer) "true")
              erc-server-current-nick "tester"
              erc-isupport-parameters '((CHANTYPES "&#"))
              erc-server-announced-name "foo.gnu.chat")
        (funcall setup)
        (set-process-query-on-exit-flag erc-server-process nil)
        (should-not calls)

        (ert-info ("Remove #chan")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u PART ##chan")
          (should calls)
          (erc-autojoin-remove erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '((FooNet "#spam")
                           (BarNet "#bar" "##bar")
                           ("foo\\.gnu\\.chat" "&local")))))

        (ert-info ("Wrong network, nothing done")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u PART #bar")
          (should calls)
          (erc-autojoin-remove erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '((FooNet "#spam")
                           (BarNet "#bar" "##bar")
                           ("foo\\.gnu\\.chat" "&local")))))

        (ert-info ("Local channel keyed by server found")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u PART &local")
          (should calls)
          (erc-autojoin-remove erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '((FooNet "#spam") (BarNet "#bar" "##bar")))))))))

(ert-deftest erc-autojoin-remove--network ()
  (erc-join-tests--autojoin-remove--common
   (lambda () (setq erc-network 'FooNet
                    erc--session (erc--sid-create nil)))))

(ert-deftest erc-autojoin-remove--session-id ()
  (erc-join-tests--autojoin-remove--common
   (lambda () (setq erc-network 'fake-a-roo
                    erc--session (erc--sid-create 'FooNet)))))

(ert-deftest erc-autojoin-remove--server ()
  (let (calls
        erc-autojoin-channels-alist)

    (cl-letf (((symbol-function 'erc-handle-parsed-server-response)
               (lambda (_p m) (push m calls))))

      (setq erc-autojoin-channels-alist (list '("gnu.chat" "#spam" "##chan")
                                              '("fsf.chat" "#bar" "##bar")))

      (ert-with-test-buffer (:name "foonet")
        (erc-mode)
        (setq erc-server-process
              (start-process "true" (current-buffer) "true")
              erc-server-current-nick "tester"
              erc-server-announced-name "foo.gnu.chat"
              ;; Assume special case w/o known network
              erc--session (make-erc--sid))
        (set-process-query-on-exit-flag erc-server-process nil)
        (should-not calls)

        (ert-info ("Announced name matched, #chan removed")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u PART ##chan")
          (should calls)
          (erc-autojoin-remove erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '(("gnu.chat" "#spam")
                           ("fsf.chat" "#bar" "##bar")))))

        (ert-info ("Wrong announced name, nothing done")
          (erc-parse-server-response erc-server-process
                                     ":tester!~i@c.u PART #bar")
          (should calls)
          (erc-autojoin-remove erc-server-process (pop calls))
          (should (equal erc-autojoin-channels-alist
                         '(("gnu.chat" "#spam")
                           ("fsf.chat" "#bar" "##bar")))))))))

;;; erc-join-tests.el ends here

debug log:

solving 9e1352668d ...
found 9e1352668d in https://yhetil.org/emacs-bugs/874k8i4tb6.fsf@neverwas.me/

applying [1/1] https://yhetil.org/emacs-bugs/874k8i4tb6.fsf@neverwas.me/
diff --git a/test/lisp/erc/erc-join-tests.el b/test/lisp/erc/erc-join-tests.el
new file mode 100644
index 0000000000..9e1352668d

Checking patch test/lisp/erc/erc-join-tests.el...
Applied patch test/lisp/erc/erc-join-tests.el cleanly.

index at:
100644 9e1352668dcf4fb63c64bce918f3b621b5f88036	test/lisp/erc/erc-join-tests.el

(*) Git path names are given by the tree(s) the blob belongs to.
    Blobs themselves have no identifier aside from the hash of its contents.^

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).