From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#55204: [PATCH v2] 29.0.50; Improve quoting consistency in Eshell predicates/modifiers Date: Sun, 1 May 2022 11:36:19 -0700 Message-ID: <9d8bcd79-42de-6c69-7fb2-68a9a558d167@gmail.com> References: <155d0ab6-fe59-940d-23ad-34a6d066fc46@gmail.com> <87fslttzmk.fsf_-_@gnus.org> <88fcb2cf-213f-b1c1-8d95-b71fba5e4055@gmail.com> <877d75dsek.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20661"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55204@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 01 20:37:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlERT-0005Gf-CF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 20:37:11 +0200 Original-Received: from localhost ([::1]:48894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlERR-0000uY-VN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 14:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlERK-0000tQ-2L for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nlERJ-0003LW-Q4 for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nlERJ-0003t0-MK for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2022 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55204 X-GNU-PR-Package: emacs Original-Received: via spool by 55204-submit@debbugs.gnu.org id=B55204.165143018914893 (code B ref 55204); Sun, 01 May 2022 18:37:01 +0000 Original-Received: (at 55204) by debbugs.gnu.org; 1 May 2022 18:36:29 +0000 Original-Received: from localhost ([127.0.0.1]:34179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlEQn-0003s9-1j for submit@debbugs.gnu.org; Sun, 01 May 2022 14:36:29 -0400 Original-Received: from mail-pl1-f178.google.com ([209.85.214.178]:43631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlEQk-0003rq-PU for 55204@debbugs.gnu.org; Sun, 01 May 2022 14:36:27 -0400 Original-Received: by mail-pl1-f178.google.com with SMTP id i17so1837136pla.10 for <55204@debbugs.gnu.org>; Sun, 01 May 2022 11:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=v0+AoVdnTCeBYG5QZBqkpKPo6nS1jq+Eotr/tlQ/O8o=; b=YAvedtCQ8gAeDsuLXr+Kq2AknuEh+/Ra+o+DScfTzEyRBjVRzv4WgIhtpzb/N1Ehog /LZ5Z/0feimxFUKOMz5HcB2ls4QsFZYCqD0w+U6bUHqfmGzQ/w2djg2imwkpE/AS2n8s 5rLafAMpBUtUDsYXIdjdBIOaZUXPH797g14SgHGsDsc9XHlBcn1LimB/0pndQ4DIPMAS iYKUsXN1PIV6d7B8hceHwdNcCSW6b4CWlpH6tx+FsDYmTT7DEPOcx0Ddok+UwqoBSub2 tm/A4ZgE45ChgF/eLpuec3s2AUCr82BgS+1WbrQ0VAvcKwzpdybXE+5eLzzDwPcWlR4u syAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=v0+AoVdnTCeBYG5QZBqkpKPo6nS1jq+Eotr/tlQ/O8o=; b=TDCgppQtm6KGEYhw8QeWrrqtTcOnWzP0SXLtRgdaTixWLS8LhQuBCetBhqXIhrZSIm DGP6EmHEGbFGw4aXl80EXXIWxwc33XTQ153TXr8YLtwVNToTYj7PWQbTT3njb3iimeHQ W+oF8mVWiue8mQuj4qPF9lMWUTqjtLEEXZDwLcDMPU6REd+jE5ARVmuXRl/gJiJyG48D lMmHmWFjert5LL1a2wa74j7IPlriKhe87HN0eMPxIVdmiJcN9MKTwdAWQOccGkd/KIta yef7PZ1O33B08dJtzTGFSN/QT/11iatIW9lPDSb8UuEbUco4b3uQ6PzXySOXroRN1z1C aFWA== X-Gm-Message-State: AOAM530LnoTN7xcdhntHkNFrldqPz+7g63OYnHOtfLhEfgkjDzOUkEi8 djvAIiSVD0S4s6i5IDKLktEhLFgAuKU= X-Google-Smtp-Source: ABdhPJzU3tS4K1mFExWjT4r+M0lSA+fXOjDYswl3Y2w2okiPM1VYQN/ojd7dTfNMB2qIfj7QHNWxOw== X-Received: by 2002:a17:90b:1c0e:b0:1dc:414c:4927 with SMTP id oc14-20020a17090b1c0e00b001dc414c4927mr5452479pjb.144.1651430180799; Sun, 01 May 2022 11:36:20 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y14-20020a634b0e000000b003c14af50626sm9482490pga.62.2022.05.01.11.36.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 May 2022 11:36:20 -0700 (PDT) In-Reply-To: <877d75dsek.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231191 Archived-At: On 5/1/2022 11:22 AM, Lars Ingebrigtsen wrote: > Thanks; looks good. But this leads to a couple of test failures, like > the one below. (Note -- this doesn't fail when "make eshell-tests", but > with "make check".) > > Test eshell-test/redirect-buffer backtrace: > signal(ert-test-failed (((should (equal (buffer-string) "hi")) :form [snip] This looks like it might be due to the change I made in `with-temp-eshell' in test/lisp/eshell/eshell-tests-helpers.el. Does it work if you run `rm test/lisp/eshell/*.elc' first? The failure may just be due to stale bytecode.