From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files Date: Thu, 14 Feb 2019 04:17:24 +0300 Message-ID: <9d65284f-7a64-5e9c-ab02-fbbd1be41689@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="8562"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Thunderbird/65.0 To: =?UTF-8?Q?Felici=C3=A1n_?= =?UTF-8?Q?N=C3=A9meth?= , 34343@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 14 02:22:47 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gu5jh-00027m-Pw for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Feb 2019 02:22:45 +0100 Original-Received: from localhost ([127.0.0.1]:37901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gu5jg-0005Us-L2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Feb 2019 20:22:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gu5jO-0005Qa-7z for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 20:22:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gu5f8-0008VS-WF for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 20:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48233) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gu5f8-0008UX-M0 for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 20:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gu5f8-000438-3r for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 20:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Feb 2019 01:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34343-submit@debbugs.gnu.org id=B34343.155010705515525 (code B ref 34343); Thu, 14 Feb 2019 01:18:01 +0000 Original-Received: (at 34343) by debbugs.gnu.org; 14 Feb 2019 01:17:35 +0000 Original-Received: from localhost ([127.0.0.1]:47514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu5eh-00042K-Ai for submit@debbugs.gnu.org; Wed, 13 Feb 2019 20:17:35 -0500 Original-Received: from mail-lf1-f65.google.com ([209.85.167.65]:37533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu5ef-000426-0e for 34343@debbugs.gnu.org; Wed, 13 Feb 2019 20:17:33 -0500 Original-Received: by mail-lf1-f65.google.com with SMTP id n23so3291589lfl.4 for <34343@debbugs.gnu.org>; Wed, 13 Feb 2019 17:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uW2opesZ75++F4r3F7Nq8BPCeoUzifYfxeCbHtb8AEM=; b=AvCEhrj8MftCmv89fvCY2jAj1J8/uOWTX1gWtMn8sRU6X+yW0dZqz58TBnVxT9wkSR Eu7hcwWwg/EaKmFUagvdcb8Ut6To1hy/NqAF0kzNaNgdEhdcf0nhFj4yflFKzRpQE4sy KFWAU5AzXEOFyk778dyFE80JroGYr21XapflniY9hx6P/yCdycilyD5f48e7jXEvpuLw dKPvZjElMDhZrlPK/RWsjeBKxCjaUzteBiyr5g99KfXaqwV/vMAS72V108yYYMCBw/vj fdeoXvUgJGDWYVs+bWj3dqwk8Wzv1K+3klBbUjqa6Fn199k5+4bfa9VPIQx0uyhssB0a ECSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uW2opesZ75++F4r3F7Nq8BPCeoUzifYfxeCbHtb8AEM=; b=TsJQXL3j77XyKHTReHSX3kVtqwMKW1Pje2PruwbR0avxGHSfYSZw1PVGDFjiM/dN8c 5K3Eny4SAiISCZqs1iU9+zoYk8u3AunMb9knHQ55Slu24lyVmUC4McEiTXRMhLEQHjmk CxLqeX1igK5IP+iyFRC7qqZpsEtUYy9dl4H9iLxizvUOUXT7XPRXRNT+Muu/KYW6sEPB I0r+oLQq1yZGBhNJyDmzNs4UKP/HOmM1+cmAVVWCEXRo2ihJRVIqJfJKG0K5ETCSh7t/ wWIGsixxWI3fgbGKZOVO3HPkQCFniRroqW/1f87bEV4mcrwaLZ/cct/JC/tQf/6l31We suqA== X-Gm-Message-State: AHQUAuYNmSb6EdtUGcNZQTRW0kDsgjRbVI+QYYRib9aIoBFKMLbiS5Ic 0kYjdWJIxHNR9e74G0cLNYI+0Xtj X-Google-Smtp-Source: AHgI3Ia5m57mN9H14AQzYyQI0W6dhSXLqPKwP4y9pCaUfKYi8s0ClXlVBaEHPEKfDUC8LsQczXWQhA== X-Received: by 2002:a19:4948:: with SMTP id l8mr642757lfj.156.1550107045705; Wed, 13 Feb 2019 17:17:25 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id g68sm158610ljg.53.2019.02.13.17.17.24 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 17:17:24 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155407 Archived-At: On 06.02.2019 11:18, Felicián Németh wrote: > The attached patch enhances the remote file support of project.el. It > also has a new "require" statement, which might be problematic. Thank you for the patch, but I'm not a big fan of first creating a list of all files, and then grouping them again by directories (or a property of directories, but still). First of all, I think we might reasonably expect that either all files are remote (and on the same host), or none of them are. If that assumption doesn't ring true to you, I think we should instead run one xargs process per directory, not the whole file list. Then, project--find-regexp-in-files would return a list of xrefs (for files belonging to one directory), project-find-regexp can nconc it for all its directories and call xref--show-xrefs on the result. Since project-find-regexp and project-or-external-find-regexp will both have to do that, a helper function will also be needed.