From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#54733: Match again in perform-replace Date: Tue, 21 Jun 2022 02:59:06 +0300 Message-ID: <9d54db84-77ba-6453-dcfa-864a7c05e692@yandex.ru> References: <865ynnl9f0.fsf_-_@mail.linkov.net> <86pmlvju2c.fsf@mail.linkov.net> <86o80ju6qx.fsf@mail.linkov.net> <861qxb6qvh.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 To: Juri Linkov , 54733@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 21 02:00:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3RJg-000AB2-JB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 02:00:24 +0200 Original-Received: from localhost ([::1]:44382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3RJd-0005mo-SS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 20:00:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3RJK-0005mf-QG for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 20:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3RJK-0003rK-Hv for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 20:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3RJK-0002Ux-Eo for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 20:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2022 00:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54733 X-GNU-PR-Package: emacs Original-Received: via spool by 54733-submit@debbugs.gnu.org id=B54733.16557695759547 (code B ref 54733); Tue, 21 Jun 2022 00:00:02 +0000 Original-Received: (at 54733) by debbugs.gnu.org; 20 Jun 2022 23:59:35 +0000 Original-Received: from localhost ([127.0.0.1]:58616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3RIp-0002Tp-UK for submit@debbugs.gnu.org; Mon, 20 Jun 2022 19:59:35 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:46929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3RIZ-0002TN-C3 for 54733@debbugs.gnu.org; Mon, 20 Jun 2022 19:59:29 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id e25so12766026wrc.13 for <54733@debbugs.gnu.org>; Mon, 20 Jun 2022 16:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9BxnzP025Scji40UHx7Gy6xlaDrtzuksdv4lSAp2y5U=; b=ZXwnrjN1AgqaqtcwSYYyMZi5btOey+XJWwZXuxlDT25ACgI2VDFesqlHds+APW0QYz Iy8HyrnvKpMToo7TUBlaR44C5dJvn45Xd4RNAEjILKBOyclFGMmBIWz7Zi0nZDtdMUBP 6HEpbOHoTFfFzdFEYjw/3sK9QMuuXGAyPRqNeB0R97B2IU2WP851WwU+s1rjmArsKAjq yk1WpmPz5j39Q3OE3fdTv9OAbHaZ/FQssvBSRt9alaR3Zd7YIu9pHDuqtyI+FPpsQUMO Vksb81ZxqEzfvgwg6QoXFQtKfeYAHoUAVTEkoncxmkV3CdDTcBARN0iDuh0a8o+M9wwA KzLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9BxnzP025Scji40UHx7Gy6xlaDrtzuksdv4lSAp2y5U=; b=YkrLon9YZStgU/gulIY0XVLm/ruZ9IKSut51QCbZt9onN4XdLV7CLxxM8rVwYlOR35 +3/ugF+lfgUfpEsWnDRKZHtdQ336JnC9wOdd2cvBW7gj3ogH82/iEtVjvOH7fViRUa+P nKHFG8BCM9RFA7mdZWJ5weIKkeflWhSamiyuWOsI8A8JVI7PmPyDOAueEa1IlJQ0dNzI sCTjYTUdG5FvuP6M0y6hNcdJhhK7RJYuGOdJmDeLeSqpgeJ53J0a8nxrlNAfJ+tlOEEc n0ZkY47kNJuLfW34Bj82TJ1JgC5Ppg1e6JrYEFpoBDU9iZ0627zUHQhGeGYq3Y96nVdJ MNDA== X-Gm-Message-State: AJIora9iE3A7BCIorDScxvnJC97TnzFooA2oDkAyMuAHydAlIyj2xhje cA9FCvlaP390+31esF0kw4Q= X-Google-Smtp-Source: AGRyM1vF5qxGSuotFXHWyXIrVREMRcYgpM9PDQW6OUM1gYEGFXiTtBQQufCOzZwMaldCAc5u+HOjMw== X-Received: by 2002:a5d:59a7:0:b0:218:5584:e3b1 with SMTP id p7-20020a5d59a7000000b002185584e3b1mr25383004wrr.421.1655769549083; Mon, 20 Jun 2022 16:59:09 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u2-20020a5d4342000000b0020fe61acd09sm14754161wrr.12.2022.06.20.16.59.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 16:59:08 -0700 (PDT) Content-Language: en-US In-Reply-To: <861qxb6qvh.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234921 Archived-At: Hi Juri, Thanks for working on this. On 03.05.2022 10:10, Juri Linkov wrote: > + (replace-search search-string limit > + regexp-flag delimited-flag > + case-fold-search backward)) I don't know this code too well, but perhaps SEARCH_STRING here should be anchored with something like "\\=" at the beginning? Otherwise the search can succeed here even if the next match is not here. Not sure how important that is, though. > - ;; Counteract the "do the next match now" hack in > - ;; `perform-replace'. And still, it'll report that those > - ;; matches were "filtered out" at the end. > - (isearch-filter-predicate > - (lambda (beg end) > - (and current-beg > - (>= beg current-beg) > - (<= end current-end)))) Please note that we'll likely have to keep this code here for a number of Emacs releases. So the patch should be tested with both versions: with this code present and with it removed, to ensure present and future compatibility.