From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message Date: Fri, 7 Feb 2014 19:18:17 -0800 (PST) Message-ID: <9d2961a4-ff90-4a14-8582-c5934adc5558@default> References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> <87mwi2b9s4.fsf@building.gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1391829557 23745 80.91.229.3 (8 Feb 2014 03:19:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Feb 2014 03:19:17 +0000 (UTC) Cc: 16331@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 08 04:19:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WByRv-0007VF-5W for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 04:19:23 +0100 Original-Received: from localhost ([::1]:44679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WByRu-00088j-Cz for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Feb 2014 22:19:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WByRj-00088O-Jf for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 22:19:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WByRa-0005kr-Sq for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 22:19:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WByRa-0005kn-Q5 for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 22:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WByRa-0005un-9c for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 22:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Feb 2014 03:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16331-submit@debbugs.gnu.org id=B16331.139182950422678 (code B ref 16331); Sat, 08 Feb 2014 03:19:02 +0000 Original-Received: (at 16331) by debbugs.gnu.org; 8 Feb 2014 03:18:24 +0000 Original-Received: from localhost ([127.0.0.1]:55773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WByQx-0005ti-Vo for submit@debbugs.gnu.org; Fri, 07 Feb 2014 22:18:24 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:38843) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WByQv-0005tZ-7p for 16331@debbugs.gnu.org; Fri, 07 Feb 2014 22:18:22 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s183IJ9q009515 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 8 Feb 2014 03:18:20 GMT Original-Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s183IJw2022834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 8 Feb 2014 03:18:19 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s183IIlD022822; Sat, 8 Feb 2014 03:18:18 GMT In-Reply-To: <87mwi2b9s4.fsf@building.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:84860 Archived-At: > > The message "Trashing..." (which is unclear, BTW) or "Deleting..." > > appears while the user is being asked whether to delete/trash. > > > > So the message is wrong: Emacs is not (yet) deleting files. > > > > A better message would be something like "Preparing to delete..." > > > > A message such as "Deleting..." can give the impression that the > > files are already being deleted. If you have 50 marked files, > > you don't want to see a message saying that they are being > > deleted before you have had a chance to cancel deletion. >=20 > As far as I can tell from reading the code, it's not saying > "Deleting..." before it's deleting the messages. (Or trashing > them.) I see the message when the pending-deletion file list is popped and you are asked for confirmation. Emacs is not deleting anything at that point. It does not start deleting the files until you confirm that you want to delete them. Whether the message appears at all depends on the timing done in `progress-reporter-do-update'. That is the code that shows the message. You may or may not see the message at all, depending on your context.