From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#67112: 30.0.50; [PATCH] Fix completion annotations when using 'pcomplete-here-using-help' Date: Sun, 19 Nov 2023 15:16:09 -0800 Message-ID: <9d1f5a33-9cdd-9788-08b7-3acc5df14b2b@gmail.com> References: <6955475e-3ea7-f6a9-bc99-58420b7ba2f5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18807"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: 67112@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 20 00:17:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4r2Y-0004lY-9Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Nov 2023 00:17:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4r2F-0003QT-3B; Sun, 19 Nov 2023 18:17:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4r2D-0003Q4-2H for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 18:17:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4r2C-0004JP-QY for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 18:17:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4r2E-00026U-Ev for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 18:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 23:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67112-submit@debbugs.gnu.org id=B67112.17004357828037 (code B ref 67112); Sun, 19 Nov 2023 23:17:02 +0000 Original-Received: (at 67112) by debbugs.gnu.org; 19 Nov 2023 23:16:22 +0000 Original-Received: from localhost ([127.0.0.1]:52245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4r1Z-00025Y-TR for submit@debbugs.gnu.org; Sun, 19 Nov 2023 18:16:22 -0500 Original-Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:58431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4r1W-00025J-KJ for 67112@debbugs.gnu.org; Sun, 19 Nov 2023 18:16:21 -0500 Original-Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6b2018a11efso3979528b3a.0 for <67112@debbugs.gnu.org>; Sun, 19 Nov 2023 15:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700435770; x=1701040570; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=ynj8quszWwigXHc1LT87q6205dJIEuBqyk9ii2j3NRs=; b=BL0A8G96YU5Sej6JFvvqMBBweQSybqkCf41U8rdJjfzGxe3JOn5YynTvC9ViXZb/k+ CuvsPkZfeJvNGKJi6ScOyz4xIWdfU2UjmwErdDXK3cbXQRQJAwKKHVJpDn1jD+4mpap1 VQ4xmc3h5BT1lZVvoQ3Oc4GMbtslYGCobs3L4CQBImzY+6GQAsWy04/Re3fb6UwC0Vzg qpjnHcwidVWxva17LGDrZ1cVQWpsgmpPWcOOySsuu5x8+PKAhuMYcBgJ6LIKjKKXHYVM Ug6+qAHzTXTKwgk/yint6Thax7E4ye8uEp9w/nfysfhIQcCh8MkGt/sM1eEOOoHww06L g4QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700435770; x=1701040570; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ynj8quszWwigXHc1LT87q6205dJIEuBqyk9ii2j3NRs=; b=MdE8oYECJbZKBJ+EUYZWs4bT7kzjw0oPVuTIke3bu3BiyvWlYjPmQLSthsQSy0y3so 1xbgkfPMk5G8hH4Qp17GZR1K7om7m1rL3HRDyUzLpjkC/oHJpddYds9fPV4fDqJXeSdX +LgSn1b3BAHMzZDzWOotgFt64kvZxXizpQ6Ng4A2cKAiMbfBHYx4i7idOauyJSJuTAO5 /zuldsejPa91KYpEubLPPxaEVDuRe2KAhxsoibrihRFVnE09aVT6YX3WfHoO8aZZ4tXr C16olSCxEsaAqZH/uzU4l/+qXveuyYAImeXWZSTY9dZKes8HKWYrdq0PCjHA9AmSVMkH 8eVw== X-Gm-Message-State: AOJu0YxEeBF9ay5AQgmwWvyiovgbALM8lGs6Kw0x0AjsSu8n8cr3T6xf kCiYHZhykLRqO7l+JfQl67Jr+xzS/FQ= X-Google-Smtp-Source: AGHT+IFxzO23ADZizylcIiT+dlw8QDpCUHTXdv20HmxE/I/q7A+7oH2HaVO8a42O0psw+gHf9Pg2uQ== X-Received: by 2002:a05:6a20:3942:b0:181:15:5755 with SMTP id r2-20020a056a20394200b0018100155755mr9321743pzg.56.1700435770504; Sun, 19 Nov 2023 15:16:10 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c12-20020a63ef4c000000b005b3cc663c8csm4894496pgk.21.2023.11.19.15.16.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 15:16:10 -0800 (PST) Content-Language: en-US In-Reply-To: <6955475e-3ea7-f6a9-bc99-58420b7ba2f5@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274640 Archived-At: Version: 30.1 On 11/11/2023 1:43 PM, Jim Porter wrote: > This was happening because 'pcomplete-here-using-help' passes along the > annotation as a text property on the first character of each completion > candidate. That property failed to propagate through > 'completion-table-with-quoting' though. So the fix is to propagate text > properties on the first character of the candidate, since that's already > a convention in a couple places with completion tables. Merged to the master branch as 16ac377aab2, and closing this now.