From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Thu, 04 Mar 2021 09:19:50 +0000 Message-ID: <9cff0f8894658f3b50c8@heytings.org> References: <87im69uzlt.fsf@mail.linkov.net> <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> <4119ea30553e3f90ab8c@heytings.org> <87y2f42ex5.fsf@mail.linkov.net> <4119ea30552873ab9870@heytings.org> <83eegvk2u0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37719"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 10:20:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHk9R-0009hA-9h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 10:20:09 +0100 Original-Received: from localhost ([::1]:44700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHk9Q-0008Pw-8q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 04:20:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHk9K-0008Pq-Jj for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 04:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHk9K-00019j-Ca for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 04:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHk9K-0004Ib-8r for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 04:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161484959416508 (code B ref 46859); Thu, 04 Mar 2021 09:20:02 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 4 Mar 2021 09:19:54 +0000 Original-Received: from localhost ([127.0.0.1]:57701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHk9C-0004IB-0y for submit@debbugs.gnu.org; Thu, 04 Mar 2021 04:19:54 -0500 Original-Received: from heytings.org ([95.142.160.155]:42570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHk9A-0004I2-G9 for 46859@debbugs.gnu.org; Thu, 04 Mar 2021 04:19:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1614849591; bh=3G2IbMGriRgqPmrvFpLgEJ2og2yRSkUfKzPNXNJFGt8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=L62LSL9mydmAAbVUrbq353+WSXENSArwzlaR4J3sXKROWR4TTIuHgWOeibnO+Arym lAQF86rVECNzq4/hoTeNzGCux5Wp0MqdHUNNbnzrHgLGbUSKFAZd7+/afiFNLAoI1R WOvJOJkqrN4FCkGAuR8NtuhS4o5GHOwc5c/ErrJf7rwnB2saML1BagDTkJ6eZrxPn8 Qbgt55kVnKte7M6raB4HBJRNxJ474c1RcNSE8YcpC/B6ZawuMFjyGaMG9UKiXTBUkJ TX0FNcmNNlkm4pJOdNeTgsBpOuLsxgYWQPEvhq0kfNg0PLek7cgWsrwI63S8iMl/qA dBIfHlMN8SzCg== In-Reply-To: <83eegvk2u0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201369 Archived-At: > > While you discuss all those possibilities, please be aware that byte > offsets have one more problem: converting them to character offsets or > columns might not be trivial, especially if the encoding of the file is > not UTF-8. (Apologies if you already discussed this.) > We did not discuss this, thanks for pointing that out. Is this not easy to do with byte-to-position? What I would suggest is to use "grep -nbo '.\{0,50\}PATTERN.\{0,50\}'", to hide the byte position in the xref buffer, and when the user jumps to an occurrence to use something like (goto-char (byte-to-position (get-byte-position))). Does that make sense?