From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Thu, 04 Mar 2021 14:39:23 +0000 Message-ID: <9cff0f88942d4103c685@heytings.org> References: <87im69uzlt.fsf@mail.linkov.net> <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> <4119ea30553e3f90ab8c@heytings.org> <87y2f42ex5.fsf@mail.linkov.net> <4119ea30552873ab9870@heytings.org> <83eegvk2u0.fsf@gnu.org> <9cff0f8894658f3b50c8@heytings.org> <83y2f3huz2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28148"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 15:41:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHpAJ-0007Ck-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 15:41:23 +0100 Original-Received: from localhost ([::1]:51172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHpAI-0006Ns-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 09:41:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHp90-0005O5-PM for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 09:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHp90-0003yZ-I5 for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 09:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHp90-0006OH-Cx for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 09:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161486876824519 (code B ref 46859); Thu, 04 Mar 2021 14:40:02 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 4 Mar 2021 14:39:28 +0000 Original-Received: from localhost ([127.0.0.1]:58236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHp8S-0006NP-9I for submit@debbugs.gnu.org; Thu, 04 Mar 2021 09:39:28 -0500 Original-Received: from heytings.org ([95.142.160.155]:42938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHp8O-0006NF-Ts for 46859@debbugs.gnu.org; Thu, 04 Mar 2021 09:39:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1614868763; bh=ItK91PCkD14HTyk9TK/H7golE3Kn2so/if0FI+QnepU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=HccmgNIiL2b+tGqd12p1tunoMKKuNWY5Wf8QkNqNyPuPDwLJSw9fGeGHHQ6xSGUbd CHtYo4hHvCGERQI8FU4oJ9/vMhyIgBR/736rcD+vyO6XsBWmKIWooRq0HNxJNU/aUm YKUBFiW4bO41NrfbGe9V2kn/mCwHQc/9IpCZ5LBfNR6lJzFXsPyajPE6co07yo7q6W 4u2BCApe4/LB3Rl1siNCC2iJeQjVerzPuPIJijJt7B0FPm/7W3RuuxDZGKCnJUd9UK jKK+lQopzVCuJpJJhusWqQqaoL7Ql7THCwYrt4ch00lVPBjz64J5I4JGXM1Se4M2eo qcRBZfJZdyJtw== In-Reply-To: <83y2f3huz2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201399 Archived-At: > > No. byte-to-position works for text in an Emacs buffer, whereas we are > talking about the text in its original file on disk. Unless that file > is encoded in UTF-8, byte-to-position will give you wrong results. You > need to use filepos-to-bufferpos, and you will need to specify the > file's encoding. And it's relatively slow for non-UTF-8 encoded files. > Thank you, I was not aware of that subtlety. But you provide the solution: when an xref is followed, the file is opened in a buffer, at which point buffer-file-coding-system is set. So it seems that it suffices to do (goto-char (filepos-to-bufferpos (get-byte-position))). I just did a filepos-to-bufferpos for one of the last bytes of a 6 MB Latin-1 file, and it took only ~2 ms.