From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Date: Thu, 27 Jun 2013 11:40:36 -0700 (PDT) Message-ID: <9cf39b5d-d100-4b72-bf78-95f6cee0d8c0@default> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1372358473 12013 80.91.229.3 (27 Jun 2013 18:41:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Jun 2013 18:41:13 +0000 (UTC) Cc: 14734-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 20:41:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UsH81-0001W3-Nu for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 20:41:09 +0200 Original-Received: from localhost ([::1]:33050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsH81-0004xc-Au for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 14:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsH7x-0004xU-Dk for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsH7v-0004Ei-1d for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:41:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsH7u-0004EQ-Up for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UsH7u-00036n-2b for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2013 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 14734-done@debbugs.gnu.org id=D14734.137235845211928 (code D ref 14734); Thu, 27 Jun 2013 18:41:02 +0000 Original-Received: (at 14734-done) by debbugs.gnu.org; 27 Jun 2013 18:40:52 +0000 Original-Received: from localhost ([127.0.0.1]:45636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsH7j-00036J-NY for submit@debbugs.gnu.org; Thu, 27 Jun 2013 14:40:52 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:26858) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsH7d-00035m-Tl for 14734-done@debbugs.gnu.org; Thu, 27 Jun 2013 14:40:46 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5RIYJRS023413 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Jun 2013 18:34:21 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5RIebcx006400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Jun 2013 18:40:38 GMT Original-Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5RIebXA014365; Thu, 27 Jun 2013 18:40:37 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75656 Archived-At: > tags 14734 wontfix > thanks >=20 > > :around advice: `ad-Advice-isearch-forward' > > It is also incorrect. The advice is :before, not :around. >=20 > It is correct: the ad-Advice-isearch-forward advice is an around advice > (and it is not your advice, it's internal as you say). > If you click on it, you'll see your before advice, properly labeled. >=20 > If you don't want to see the internal thingy, then use the new > advice-add rather than the old defadvice. How can you close this bug? Did you read the whole report? The addition to the doc string, which is the only point of this particular = advice, is MISSING from the output of C-h f. The added text should appear = at the end of the original doc string, seamlessly. Please read the whole report and try to control your knee jerks.