From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Morgan.J.Smith@outlook.com, 70894@debbugs.gnu.org
Subject: bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation
Date: Sun, 19 May 2024 11:22:36 +0200 [thread overview]
Message-ID: <9ce8c102-65eb-4c66-8474-87ce7bb7a55b@gmx.at> (raw)
In-Reply-To: <86le46b4ue.fsf@gnu.org>
> For the last issue: we should use default-font-width/height. But the
> question is: would replacing frame-char-width/height by these two fix
> that use case, or do we need anything else?
It might improve those use cases but won't take care of any extra line
spacing. But there are too many unresolved issues there: How would we
interpret the MAX/MIN-WIDTH and MAX/MIN-HEIGHT arguments - still in
frame character units as we (partially) do now? Note that functions
like 'window-min-size' or 'window-safe-min-pixel-height' don't care
about window character units, they operate in frame units. And there's
always the possibility that intermediate rounding errors sum up and make
things only get worse.
martin
prev parent reply other threads:[~2024-05-19 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 13:25 bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation Morgan Smith
2024-05-18 9:39 ` Eli Zaretskii
2024-05-19 7:58 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-19 8:09 ` Eli Zaretskii
2024-05-19 9:22 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ce8c102-65eb-4c66-8474-87ce7bb7a55b@gmx.at \
--to=bug-gnu-emacs@gnu.org \
--cc=70894@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
--cc=eliz@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).