From: Dmitry Gutov <dgutov@yandex.ru>
To: Ryan Thompson <rct@thompsonclan.org>,
Drew Adams <drew.adams@oracle.com>,
27158@debbugs.gnu.org
Subject: bug#27158: 25.2; Eliminating old usage of completing-read from built-in files
Date: Tue, 6 Jun 2017 03:09:43 +0300 [thread overview]
Message-ID: <9ce0139f-36c0-efac-067d-14b8c0e89d7e@yandex.ru> (raw)
In-Reply-To: <CAHCt_abNdDGgwer3r2F3y710U_Rj7mzF+hWqtn=uOjWCkM3VaQ@mail.gmail.com>
On 6/6/17 3:06 AM, Ryan Thompson wrote:
> Does it work well in the "don't want any default" case?
>
> It does the same thing as completing-read-default, which is that it
> allows you to enter an empty string by pressing RET and assumes that the
> calling function is expecting that to happen. In particular, this means
> that any code that wrongly assumed that setting REQUIRE-MATCH would
> guarantee returning an element of COLLECTION is now equally broken in
> both standard completion and ido completion, as opposed to being
> spuriously "fixed" by ido ignoring the spec of completing-read.
Indeed. So less than ideal, like discussed.
> Anyway, I'm finding it to work pretty well without requiring a
> distinction between commands that do or do not expect the empty string.
> I merged that branch into my bleeding-edge branch and fixed a bunch of
> bugs, and I'm going to test it for a while before releasing.
I agree that it's a step forward toward better compatibility.
next prev parent reply other threads:[~2017-06-06 0:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 4:41 bug#27158: 25.2; Eliminating old usage of completing-read from built-in files Ryan
2017-05-31 5:52 ` Drew Adams
2017-05-31 11:45 ` Ryan Thompson
2017-05-31 14:51 ` Drew Adams
2017-05-31 12:23 ` Dmitry Gutov
2017-05-31 14:51 ` Drew Adams
2017-05-31 14:59 ` Dmitry Gutov
2017-05-31 15:19 ` Drew Adams
2017-05-31 15:44 ` Ryan Thompson
2017-05-31 22:41 ` Dmitry Gutov
2017-05-31 23:16 ` Drew Adams
2017-05-31 23:54 ` Dmitry Gutov
2017-06-01 2:23 ` Drew Adams
2017-06-01 9:27 ` Dmitry Gutov
2017-06-01 14:57 ` Drew Adams
2017-06-01 20:53 ` Dmitry Gutov
2017-06-01 21:04 ` Ryan Thompson
2017-06-05 23:01 ` Dmitry Gutov
2017-06-06 0:06 ` Ryan Thompson
2017-06-06 0:09 ` Dmitry Gutov [this message]
2017-05-31 21:20 ` Dmitry Gutov
2020-08-24 14:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ce0139f-36c0-efac-067d-14b8c0e89d7e@yandex.ru \
--to=dgutov@yandex.ru \
--cc=27158@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=rct@thompsonclan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).