From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Mon, 2 Dec 2019 02:07:27 +0200 Message-ID: <9ca96aed-257a-122b-4b94-8964be7777f1@yandex.ru> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <87d0dd88jr.fsf@mail.linkov.net> <83pnhcowtz.fsf@gnu.org> <83blstoav8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27814"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37774@debbugs.gnu.org To: Eli Zaretskii , juri@linkov.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 02 01:08:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibZGA-00077Y-W5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 01:08:15 +0100 Original-Received: from localhost ([::1]:56992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibZG9-0003FW-RD for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Dec 2019 19:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42686) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibZG2-0003FL-6Z for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2019 19:08:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibZFy-0003OS-BR for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2019 19:08:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59135) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibZFy-0003ON-81 for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2019 19:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ibZFy-0004Dh-1w for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2019 19:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2019 00:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157524525716185 (code B ref 37774); Mon, 02 Dec 2019 00:08:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 2 Dec 2019 00:07:37 +0000 Original-Received: from localhost ([127.0.0.1]:36875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibZFZ-0004Cz-75 for submit@debbugs.gnu.org; Sun, 01 Dec 2019 19:07:37 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:34291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibZFX-0004Ck-DH for 37774@debbugs.gnu.org; Sun, 01 Dec 2019 19:07:35 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id f4so4629297wmj.1 for <37774@debbugs.gnu.org>; Sun, 01 Dec 2019 16:07:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YBo7Z3WFNLTlIJPkZ5WkNvRf6pha+pZnc7w3WMyoiUY=; b=fJB/8fcDE52J96xeU3AEFsIDhoWbkMVbNFXP/kLnJY0XgnMEzpPdjnccRB7rcHi/5h kn2Jj4afYlXE2+DF+ScUNHOE9jjdmnEozQoVg2Lwt/2Xia+oaRHqn/JQjlJ4Lg1kzjvX 5ikU6CoRQkx5N6gF4mb2HeY3A7mt5qb7aS9oW4TZfZrTNVnxS5uH+leysb3Mxs+gUI96 FGco10oab8vUZTto6Aq8ZBdomIf12AnF3t3rLDiKyNXN2JsTr/BUz1CxLqME1rptQAWY OuHzmNfGaZzdXKy8vPH1qCC3wzb1VsUHO+MfLfKV/eayduP5A2SIWbeIeeOeTfygmPkk nfsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YBo7Z3WFNLTlIJPkZ5WkNvRf6pha+pZnc7w3WMyoiUY=; b=RwPgLCcOHCsemphLa8R2Ehk92chZXMD9ruzIaTZuSPFBQDraXMZxCx61SQ++uFQQBo zmXw76llSLjJTSWYy4BC25WYD2rrhM0ldfhV1nHtUZRl8cgWtvUOEIYQB+WBykUT7mRv W4AczlLFE49fp+gEs3IQRXoDvGnn5q58r3m+HkR34TiW8OfjmGUD/5JuGrhE71OwMoVn BYT0iS8vzbBuDxv6eew0Cci5zm8DI5M+XBUxmTOe5UVcD0coa/1DmtRoN9bcjL/f8Aiy +1fmCfLlkjZB3ykeS3SZxLhtSqJORtArx5sWyFzK5rL5v7d//IE21fpWp+W/SU1vxhNh WFWA== X-Gm-Message-State: APjAAAUz75BXvWCdMfSjv79ak/CIU4zUoq48wYuo6L33jFHlJACEARRq y+6yo+B7C2Z3Va6prAou8toBPvnd X-Google-Smtp-Source: APXvYqw08RlyEP+qTJvxqCz8vzWC37sRX2I4yhbAr1TCPlwQHsDkmgQSaTO3jNw3eeKFdk5M7/wt5w== X-Received: by 2002:a7b:cb02:: with SMTP id u2mr26176783wmj.142.1575245249625; Sun, 01 Dec 2019 16:07:29 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 13sm21513648wmk.1.2019.12.01.16.07.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Dec 2019 16:07:29 -0800 (PST) In-Reply-To: <83blstoav8.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172742 Archived-At: On 30.11.2019 13:35, Eli Zaretskii wrote: >>> This means manually adding :extend to all files in etc/themes? >> >> Yes. > > I've now done that. > > Two comments: > > . When adding the :extend attribute to a face, we should make sure > all of that face's definitions have the same value of it, even if > the default definition of the face for some 'class' of displays > doesn't need it (e.g., because it specifies only the foreground > color). This is so that if users customize the face, the results > will look uniform regardless of which face attributes they > customize. Otherwise, if the user customizes the background color > or :underline or some other similar attribute, the appearance will > be different from that on other classes of terminals, and that is > baaaad... > > . Some of the themes we have in core customize faces defined by > unbundled packages. I didn't change the definitions of those > faces; it's up to the respective package developers and/or users > to come up and ask for such changes, if it turns out the packages > added the :extend attribute and we didn't. I think the "alternative property" would help both of these concerns with less effort (mental and physical) required from everybody.