From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#39902: 28.0.50; Marking in dired with active region Date: Mon, 23 Mar 2020 08:20:53 -0700 (PDT) Message-ID: <9c815660-acc0-45f9-ab9f-c95cce43d967@default> References: <87d09suras.fsf@web.de> <8736aiqu3y.fsf@mail.linkov.net> <7a0a6f19-f958-4b38-beaf-3d60dc8a279f@default> <87d09lb1ts.fsf@mail.linkov.net> <87a74n4vet.fsf@web.de> <87eetzah2s.fsf@mail.linkov.net> <87zhcn9229.fsf@mail.linkov.net> <6d82d04a-db94-4df4-82cc-3ea13a78a4dd@default> <877dzqidzn.fsf@mail.linkov.net> <1e37a524-80d3-445f-8f81-a18539105ac3@default> <87pndhhyvk.fsf@mail.linkov.net> <1ce62594-cc2a-4e95-b2b3-d022fa65decd@default> <87bloybivx.fsf@mail.linkov.net> <0066d43a-5f97-4c9d-a4b7-84c6b0ecf356@default> <87bloxgp9g.fsf@mail.linkov.net> <8736a7ajn5.fsf@web.de> <87fte52pbf.fsf@mail.linkov.net> <87o8sruchv.fsf@mail.linkov.net> <875zexf6l3.fsf@web.de> <87wo7bzz4h.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="76839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39902@debbugs.gnu.org To: Juri Linkov , Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 23 16:22:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jGOu2-000JsU-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Mar 2020 16:22:10 +0100 Original-Received: from localhost ([::1]:35386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGOu1-0002Tl-Jb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Mar 2020 11:22:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50448) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGOtv-0002Tf-6x for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2020 11:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGOtu-0008RT-6g for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2020 11:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGOtu-0008RF-1n for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2020 11:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jGOtt-0004e6-Tt for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2020 11:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Mar 2020 15:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39902 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 39902-submit@debbugs.gnu.org id=B39902.158497686817784 (code B ref 39902); Mon, 23 Mar 2020 15:22:01 +0000 Original-Received: (at 39902) by debbugs.gnu.org; 23 Mar 2020 15:21:08 +0000 Original-Received: from localhost ([127.0.0.1]:53411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGOt1-0004cl-Q1 for submit@debbugs.gnu.org; Mon, 23 Mar 2020 11:21:08 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:38300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGOsy-0004bq-Ln for 39902@debbugs.gnu.org; Mon, 23 Mar 2020 11:21:06 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02NFALMQ034902; Mon, 23 Mar 2020 15:20:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=Duan1ikT00TpQdyHQq4hrkI8uffDOyPA8r5jw+7HOgA=; b=v3QO0DtaqZ7SqSSvAtVlhjmP9fbQVs1UPgViiwXxLOYVe7iwF0O2sM2LozYQBbw0mbxo +D1l55SN/ejL/28LEz6jWzHZIeNt47NCHt/tUm/cYQiJwgEcCwBcQJcNOmfidfcI+wB2 0lI3avjMXjIATtMIKl7jeASTowByxjxN1CaoZ5Is34P8feAY2m1o2MQku8yw+Fenpow2 6yD5ugBfY2AGnT26UgHANH8ML/gCsgUdTkEx8avhj2ZhFV86UiFna8VCCN7GZYoMLIpB 6h7MCPnjm3XzoeiVz5Uu+JsmZk9FckMDFHaKscQKhJKozvk80ceeSRFSbL4mCRxCLUdd 7w== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2yx8abv6fh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2020 15:20:58 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02NFJsGU068877; Mon, 23 Mar 2020 15:20:56 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2yxw7fn6ra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2020 15:20:56 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02NFKsim015583; Mon, 23 Mar 2020 15:20:54 GMT In-Reply-To: <87wo7bzz4h.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4966.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9569 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 spamscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003230086 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9569 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 adultscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003230086 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177653 Archived-At: > > The docstring of `dired-mark-inclusive' should be enhanced a bit I > > think. You could add one sentence about what "inclusive" means, and > > another saying that other (un-)marking commands are also covered. >=20 > I enhanced the docstring, renamed to `dired-mark-region', > and pushed to master. >=20 > The default behavior was unchanged since it's consistent with > marking without region. But this is not my personal preference. > I have dozens of customized options in my init file, even for features > that I implemented, my customization still differs from default values > that make sense for most users. The default value of the new option > `dired-mark-region' could be changed too in case more people > will demand this. Thank you for changing the name of the option. I meant to say something about that, but forgot. I don't know what you have as the doc string (I don't have the diff/patch), but here's my opinion about the option description: It's _not_ good to express it in the terms you described: as being about including or excluding the limit at the region end. That's not it at all, IMO. This should be expressed in terms of the behavior being either line-oriented (as is nearly all of Dired) or file-name oriented. Put differently, the description should say that the two choices are these: 1. Mark if _any_ part of the file's line is selected. 2. Mark if _all_ of the file name is selected. (Where "selected" means "in the region".) That's much clearer, I think. It's expressed in terms of what users do and see. Either you need to select some part of the line or you need to select all of the file name. What could be simpler? (Anyway, I'm glad we've more or less reached agreement.)