From: Jim Porter <jporterbugs@gmail.com>
To: Manuel Uberti <manuel.uberti@inventati.org>, 50207@debbugs.gnu.org
Subject: bug#50207: 28.0.50; ansi-color-compilation-filter and rgrep
Date: Thu, 26 Aug 2021 10:07:52 -0700 [thread overview]
Message-ID: <9c24f4b0-e7aa-62d3-5737-0edffb8b2501@gmail.com> (raw)
In-Reply-To: <e2cbdb26-3566-caed-4072-b2d0b03b91d6@inventati.org>
On 8/25/2021 10:57 PM, Manuel Uberti wrote:
> From 'emacs -Q', this is what I did:
>
> - (add-hook 'compilation-filter-hook #'ansi-color-compilation-filter)
> - M-x rgrep RET
> - setq RET
> - RET
> - ~/emacs RET (this is where I keep the entire Emacs source code)
>
> As you can see from the attached image, some of the results are red and
> some are not. This is not happening without ansi-color-compilation-filter.y
I encountered this a bit ago, and did a bit of diagnosis, but it ended
up on my back-burner. I think the issue is due to how the
compilation-filter-hooks for grep and ansi-color interact. `grep-filter'
is fairly simple and wants to see both the start and end of an
ANSI-colorized region, so it "rewinds" to the beginning of a line every
time it's called. `ansi-color-compilation-filter', on the other hand, is
smart enough to handle the case where it only sees the start of a
colorized region in one call, and the end in the next call (see
`ansi-color-context' for details).
These interact poorly, since normally `grep-filter' reads all the ANSI
escapes, handles the ones it recognizes, and strips the rest, leaving
`ansi-color-compilation-filter' with nothing to do. However, when grep's
output currently shows the start of a colorized region but not the end,
`grep-filter' doesn't touch that, assuming it can come back to it in the
next call. By then `ansi-color-compilation-filter' has "stolen" that
ANSI escape, confusing `grep-filter'.
To solve this, I just turn off `ansi-color-compilation-filter' for grep.
When things are working right, it should be a no-op, and when things are
working wrong, you see the behavior described in this bug. It might be
nice to turn this off automatically though. Right now it's just a sharp
corner people can cut themselves on.
next prev parent reply other threads:[~2021-08-26 17:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 5:57 bug#50207: 28.0.50; ansi-color-compilation-filter and rgrep Manuel Uberti
2021-08-26 11:10 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-26 22:11 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-26 22:33 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-26 17:07 ` Jim Porter [this message]
2021-08-27 6:06 ` Juri Linkov
2021-08-27 6:36 ` Jim Porter
2022-12-07 11:05 ` Augusto Stoffel
2022-12-08 22:34 ` Augusto Stoffel
2022-12-09 7:20 ` Juri Linkov
2022-12-09 11:57 ` Augusto Stoffel
2022-12-14 16:32 ` Augusto Stoffel
2022-12-15 8:02 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c24f4b0-e7aa-62d3-5737-0edffb8b2501@gmail.com \
--to=jporterbugs@gmail.com \
--cc=50207@debbugs.gnu.org \
--cc=manuel.uberti@inventati.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).