unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: philipk@posteo.net, 43086@debbugs.gnu.org
Subject: bug#43086: [PATCH] Allow tags backend to not query for TAGS file
Date: Tue, 10 Sep 2024 16:30:18 +0300	[thread overview]
Message-ID: <9bf7fe99-fd16-45ed-9215-a617de76777f@yandex.ru> (raw)
In-Reply-To: <86cylbviq0.fsf@gnu.org>

On 10/09/2024 14:41, Eli Zaretskii wrote:

>>> But what do you expect from a backend that depends on TAGS to do when
>>> TAGS is not there?  You yourself just noticed the regression.  Why
>>> would we want that?
>>
>> I'm thinking of the xref-find-references case - where the scanner
>> doesn't depend on the tags table being available. Just the identifier
>> completion step.
> 
> Completion is also important, IMO.

Just not always worth the extra query or wait time.

>> We have an existing way to enable etags-regen-mode. And it's a global
>> mode, so it's not just an issue of using it that one time - the naive
>> solution will make stay on until the end of the session.
> 
> We could in this particular case enable it once, then disable it after
> regenerating TAGS.

I'm not sure I'd want a one-time generation of tags which never gets 
updated afterward. Not for me, nor for an inexperienced user who would 
likely get puzzled at some point about why the index not updating.

>> Also, if the tags file is not loaded, we're not quite sure whether the
>> user wants an auto-generated file, or an existing one.
> 
> The query should allow the user to tell us his/her preference, no?

For that we need to decide on the options and the possible lifetimes of 
the answer in advance. That's all I'm saying: it's not an obvious "just 
ask the user".

>> How do you feel about etags-regen-mode being on by default in some next
>> Emacs release? It shouldn't conflict with the manual invocations of 'M-x
>> visit-tags-file' - and of course if any cases come up we'll work on
>> fixing those.
> 
> As long as there's a way of turning it off, I don't think I will mind
> too much.

Great! As long as nobody objects in the coming days I'll switch the 
default value.





      parent reply	other threads:[~2024-09-10 13:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 12:50 bug#43086: [PATCH] Allow tags backend to not query for TAGS file Philip K.
2020-09-05  0:45 ` Dmitry Gutov
2020-09-06 21:50   ` Philip K.
2020-09-16 10:53     ` Dmitry Gutov
2021-11-12  8:25       ` Lars Ingebrigtsen
2021-11-14  0:02         ` Philip Kaludercic
2022-09-11 11:36           ` Lars Ingebrigtsen
2022-09-13  4:07             ` Richard Stallman
2024-09-03 16:39   ` Philip Kaludercic
2024-09-06 22:16     ` Dmitry Gutov
2024-09-07  6:18       ` Eli Zaretskii
2024-09-09  0:29         ` Dmitry Gutov
2024-09-09 11:54           ` Eli Zaretskii
2024-09-09 23:32             ` Dmitry Gutov
2024-09-10 11:41               ` Eli Zaretskii
2024-09-10 12:45                 ` Eli Zaretskii
2024-09-10 13:32                   ` Dmitry Gutov
2024-09-10 13:30                 ` Dmitry Gutov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bf7fe99-fd16-45ed-9215-a617de76777f@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=43086@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).