From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#46904: Non-unique windows produced by window-state-put Date: Fri, 5 Mar 2021 10:10:31 +0100 Message-ID: <9bd9f7dd-a4d5-6d64-f784-f63f532efa10@gmx.at> References: <877dmo0zdn.fsf@mail.linkov.net> <87a6rj8dhe.fsf@mail.linkov.net> <87lfb2izev.fsf@mail.linkov.net> <8735xar85l.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33295"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46904@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 05 10:11:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI6UM-0008X3-6F for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 10:11:14 +0100 Original-Received: from localhost ([::1]:46018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lI6UK-0002sy-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 04:11:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lI6UA-0002pJ-I5 for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 04:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lI6UA-0005AX-AP for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 04:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lI6UA-0000Ox-4q for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 04:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Mar 2021 09:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46904 X-GNU-PR-Package: emacs Original-Received: via spool by 46904-submit@debbugs.gnu.org id=B46904.16149354411509 (code B ref 46904); Fri, 05 Mar 2021 09:11:02 +0000 Original-Received: (at 46904) by debbugs.gnu.org; 5 Mar 2021 09:10:41 +0000 Original-Received: from localhost ([127.0.0.1]:32775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lI6Tp-0000OH-HR for submit@debbugs.gnu.org; Fri, 05 Mar 2021 04:10:41 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:44299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lI6Tn-0000O3-8n for 46904@debbugs.gnu.org; Fri, 05 Mar 2021 04:10:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1614935432; bh=wKmuGr4GAqJ+ArYDTlHaQSew4Ps38hHjYd4gHzY1Vws=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=M9Orjq6p819yGklUQxknbR/pOhwFuUzImJmDgfylgf4QIU9rG0L70PE5kB1GWjYfK Hvhau4xRmMeQ5jFsPXMelQEsZelWw4Rfogu5MgJBhnplgc8zHZazH1FQ9jPhRynPBt AKIPNykk+gsyjgxmO8RwJi1vaZHORDyzTBInuuQ8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.12]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Msq2E-1lbhj62Lpg-00tBgn; Fri, 05 Mar 2021 10:10:32 +0100 In-Reply-To: <8735xar85l.fsf@mail.linkov.net> Content-Language: en-US X-Provags-ID: V03:K1:RmyJGrcQiO6OGLVjF0qJGH1U+r9aMjlq/iGKT4JMavd5GdBYfSD 1pqdRt5MgZgm9O5MQELQq/vt+JC1o6su4jqRapEh88oPaM7OsS2fKpRNxAXqpd1gge82WCq MEmV8UpoA/3mrs3wbT10mUGKhE2Ir1ESI9gRGwLh6O6Xo7vT0FJoUpKy05miMVsZwgNZ9nM aSoLyc/kHUoA+PXg+eMJw== X-UI-Out-Filterresults: notjunk:1;V03:K0:yovAggoI92s=:lEuhXENU5KOc6So5lYTkXI dnFG57eXkpdduUPYXOMPV2qZuwFcHmXXM5wE0b0ay19CAcpev+zJ8kK8j0X9AFTCbC9wFFLqf AXNSWj1jNbKpHRLvoqeHwr6uhKaCvjbCPXK82NncOCrvzRP/dkETIzvH3EoIEJpQ6+W6IMRt4 wK2Prt8MaxM22lK6nJ3nxX2nu3XXiZ1jolqVmQK/jLtNYAU/T9Ps/O/kMBlYbWAM28r/xPIxS M1ISVqlshYxfIW1DuiVUk77ovJrnwKdWxEXZkNs7BEsk+0awKpCkhwhRb56mblbSPMzXuHDDb NAzuAXKimQ6Zdkp08dtrmsDtYlDai6I/SF/1qmqNQQa+wXp+25ui0D3dnPqfH6aZKJeXKNHon qwsUUxK4DLb9JT8euCftsRe41O1EDIFfob02kmny568BQW4aT7zyeyxhgWkdh10BPH4CPECHj wKlgV1xo23fKxxD55R/TGTk1qcloKuO+GrZzJOJUXEccsI9Rko1ZkDdlBbzP3P/ByOwK36lsJ ozu5wehWAYz8FT8sUZXhAEYK7SHn7jMlGJco/TmZhMS0+9nho0PuBldP5Lg3m+Il494udup4F fF/oBdyFd7T628UmqLTt1W9NrvlVlczmJYpMBpsYGGTRYpWRbXQJ46gd+eJkXarRr/QvtC302 NhtVZJXuN9BzUQHMuDRDZ4WUr5E7llfU5udcFUSeOie2nDrJ6/ygNzbi3YZCxxQg8+rtKQQXk D6HzK1b+iiBHKkhGsqX7jBQme66yC98ybTE8BxdWmKt6Y6kVVajwBN2aiXzIEkKfiJ22AIUt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201507 Archived-At: > Actually with this patch window-swap-states fails with the error > "Wrong type argument: stringp, nil" in: > > ;; Swap basic states. > (window-state-put state-1 window-2 t) > (window-state-put state-2 window-1 t) > ;; Swap overlays with `window' property. > (with-current-buffer (window-buffer window-1) > > Here '(window-buffer window-1)' returns nil because > window-1 doesn't exist anymore after calling window-state-put. We could easily handle that by having `window-state-put' return the window actually used for putting the state into and use that in `window-swap-states'. Yet someone else might use `window-state-put' in much the same way as `window-swap-states' does and we have a quite incompatible change: We nowhere say that the window used as second argument of `window-state-put' will be live if it was so before, but we neither say that it can be deleted. So I'm not sure what to do ... martin