From: Gregory Heytings <gregory@heytings.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: 60467@debbugs.gnu.org
Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced
Date: Mon, 02 Jan 2023 01:50:23 +0000 [thread overview]
Message-ID: <9bc9c69ac282c0148962@heytings.org> (raw)
In-Reply-To: <9bc9c69ac20a37ded741@heytings.org>
>
> If it's an Emacs bug, which is possible, it's in combine-change-calls.
>
A few more details on the bug. It's still unclear to me whether the bug
is in Org or in Emacs.
When the file is opened we start with buffer-undo-list = nil.
The (org-with-limited-levels (org-map-tree 'org-promote)) body in
org-promote-subtree, called inside a combine-change-calls, adds four
entries to buffer-undo-list:
("** " . 6) <timestamp> (9 . 11) <timestamp>
which means that three characters have been removed and two have been
added in the buffer, which seems correct, although the (9 . 11) entry
looks a bit suspicious. Perhaps (6 . 8) would have been expected there?
However, this change does not happen outside the region on which
combine-change-calls is called, which is 6-11.
Upon returning from combine-change-calls, buffer-undo-list contains four
elements, when a single element would have been expected, if I understand
its docstring correctly:
(apply 1 6 10 #'undo--wrap-and-run-primitive-undo 6 10 (("** " . 6))) <timestamp> (9 . 11) <timestamp>
next prev parent reply other threads:[~2023-01-02 1:50 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 13:40 bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Ihor Radchenko
2023-01-01 14:38 ` Eli Zaretskii
2023-01-02 0:46 ` Gregory Heytings
2023-01-02 1:50 ` Gregory Heytings [this message]
2023-01-02 9:31 ` Ihor Radchenko
2023-01-03 9:41 ` Gregory Heytings
2023-01-03 12:46 ` Eli Zaretskii
2023-01-03 13:44 ` Gregory Heytings
2023-01-03 14:48 ` Eli Zaretskii
2023-01-03 15:05 ` Gregory Heytings
2023-01-03 16:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-03 16:33 ` Gregory Heytings
2023-01-03 16:51 ` Gregory Heytings
2023-01-04 0:16 ` Gregory Heytings
2023-01-04 2:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-04 9:24 ` Gregory Heytings
2023-01-04 10:50 ` Gregory Heytings
2023-01-04 14:39 ` Eli Zaretskii
2023-01-04 14:43 ` Gregory Heytings
2023-01-04 14:36 ` Eli Zaretskii
2023-01-04 14:39 ` Gregory Heytings
2023-01-04 18:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-04 18:16 ` Gregory Heytings
2023-01-04 18:42 ` Eli Zaretskii
2023-01-04 21:04 ` Gregory Heytings
2023-01-03 14:56 ` Gregory Heytings
2023-01-03 15:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-03 15:29 ` Gregory Heytings
2023-01-03 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-08 15:43 ` Alan Mackenzie
2023-01-09 6:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-09 12:16 ` Eli Zaretskii
2023-01-13 22:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-14 7:06 ` Eli Zaretskii
2023-01-02 9:27 ` Ihor Radchenko
2023-06-22 19:28 ` bug#60467: New problem introduced Frédéric Giquel via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 11:01 ` bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Eli Zaretskii
2023-06-23 13:06 ` Gregory Heytings
2023-06-26 14:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-26 14:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-26 15:18 ` Gregory Heytings
2023-06-26 15:30 ` Eli Zaretskii
2023-07-01 14:14 ` Gregory Heytings
2023-07-01 14:27 ` Eli Zaretskii
2023-07-15 7:46 ` Eli Zaretskii
2023-08-03 7:38 ` Eli Zaretskii
2023-08-10 11:28 ` Gregory Heytings
2023-08-10 13:41 ` Eli Zaretskii
2023-08-10 13:55 ` Gregory Heytings
2023-08-12 7:09 ` Eli Zaretskii
2023-08-16 16:09 ` Gregory Heytings
[not found] <3eea0a7dff2915453876fc3a2b628886c78a4d4b.camel@laposte.net>
2023-07-04 0:03 ` sbaugh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bc9c69ac282c0148962@heytings.org \
--to=gregory@heytings.org \
--cc=60467@debbugs.gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).