From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#26626: 24.5; doc of `last-command-event' and `last-nonmenu-event' Date: Fri, 26 Jul 2019 07:30:20 -0700 (PDT) Message-ID: <9b9bda4c-235c-4ac6-be33-e7468e6a15d5@default> References: <036c27e0-4509-45e8-942e-9b454b34b0ef@default> <87v9vpnnsc.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="61435"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 26626@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 26 16:31:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hr1FU-000Frh-DM for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 16:31:08 +0200 Original-Received: from localhost ([::1]:40570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr1FS-0003Tv-UX for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 10:31:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48035) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr1FP-0003SA-Jg for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 10:31:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hr1FO-0001hi-G9 for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 10:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34285) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hr1FO-0001hN-B0 for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hr1FO-0006jM-5I for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2019 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26626 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 26626-submit@debbugs.gnu.org id=B26626.156415143125826 (code B ref 26626); Fri, 26 Jul 2019 14:31:02 +0000 Original-Received: (at 26626) by debbugs.gnu.org; 26 Jul 2019 14:30:31 +0000 Original-Received: from localhost ([127.0.0.1]:43106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr1Et-0006iU-0h for submit@debbugs.gnu.org; Fri, 26 Jul 2019 10:30:31 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:51458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr1Er-0006iI-Me for 26626@debbugs.gnu.org; Fri, 26 Jul 2019 10:30:30 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6QETBwg118889; Fri, 26 Jul 2019 14:30:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=rHdN5PoQ7xJqRpfZPgYERrF1l+Rm2iQLk3rz+cArIXA=; b=AUaRt8uzxoY6PbeOXtOeWcIUEhtx9aIx2eb0VxGWeCZjQ71u081b4eIIDnJH9IGBS5sd Qw+L0yk3bUmQkQbPEZLBZApfrrvA0b2znRKmUwiu9Z8zYg/U0fh7u38ESPHL9+37kWQ0 ZBKSOKulYUyMtYNtNOlcvderOWVQbHF455g0ME76/wstJQuriVA43g0MjAWZQG/BoO02 smP+xaCBLk9T1ZKNz7X3xuM0JId875WWrRmRHoWBHA7cjDU/GVQNoNircjnEPBWf8Gxm KaYNiVToY6Qe+vFXjAPF8Wsg8LnP3en2OjhtHxdE0zfz9ad0HayOvshovW5af88MjtP4 Cw== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2tx61cah5b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jul 2019 14:30:23 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6QERwoj045021; Fri, 26 Jul 2019 14:30:22 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2tx60yy9rs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jul 2019 14:30:22 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x6QEULHc023225; Fri, 26 Jul 2019 14:30:22 GMT In-Reply-To: <87v9vpnnsc.fsf@mouse.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9330 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907260178 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9330 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907260178 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163788 Archived-At: > > The essential difference in the descriptions seems to be the last input > > event read "as part of a key sequence" versus read "as part of a > > command". But "read as part of a command" is unclear. Does it mean > > read by a command (e.g., by a call to `read-char' within the command > > definition)? No. But that's all I can think of, when reading that > > description. > > > > The doc of `last-nonmenu-event' is pretty clear. Or at least it is > > before reading also the doc of `last-command-event' and trying to make > > sense of that. Even the name of the latter is unclear - what's a > > "command event"? > > > > The example given for `last-command-event' suggests that what is > > meant is the last event in the key sequence that invoked/initiated a > > command. I think that's closer to what the meaning/behavior is. >=20 > The variable doc string isn't very helpful; no. >=20 > I've now changed it to the following on the trunk: >=20 > Last input event that was part of a command key sequence. > See Info node `(elisp)Command Loop Info'. There's no such thing as a "command key sequence", as opposed, one imagines, to a "non-command key sequence". A key sequence that is complete is always bound to a command. Or did you mean to suggest a complete key sequence, as opposed to an incomplete sequence: a key-sequence prefix? There are events that are not key sequences. That distinction is valid and important. But are there (complete) key sequences that are not bound to keys (including menu and mouse actions)? I don't think so. I still think that the text for this should borrow from what is said for `last-nonmenu-event'. IIUC, `last-command-event' is the "last input event read as part of a key sequence". IOW, same as `last-nonmenu-event', but without the "nonmenu" part. Isn't that the essential difference? And yes, the Info description should be changed, not just the doc string, for the reasons given in the bug description - "as part of a command" is misleading or meaningless. See above for a suggestion: make it similar to what we say for `last-nonmenu-event'.