From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Per Cederqvist" Newsgroups: gmane.emacs.bugs Subject: Re: accept-process-output incompatible change in CVS Emacs: patch included Date: Sat, 5 May 2007 10:42:43 +0200 Message-ID: <9b83c8160705050142o10205741pf4a6c20d3553768d@mail.gmail.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1178354573 32343 80.91.229.12 (5 May 2007 08:42:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 5 May 2007 08:42:53 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 05 10:42:51 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HkFqt-0004Mi-DF for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 May 2007 10:42:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HkFxb-0001g0-Ui for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 May 2007 04:49:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HkFxZ-0001er-5O for bug-gnu-emacs@gnu.org; Sat, 05 May 2007 04:49:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HkFxX-0001eR-32 for bug-gnu-emacs@gnu.org; Sat, 05 May 2007 04:49:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HkFxW-0001eO-TW for bug-gnu-emacs@gnu.org; Sat, 05 May 2007 04:49:42 -0400 Original-Received: from ug-out-1314.google.com ([66.249.92.170]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HkFqn-0006pV-8u for bug-gnu-emacs@gnu.org; Sat, 05 May 2007 04:42:45 -0400 Original-Received: by ug-out-1314.google.com with SMTP id j3so739721ugf for ; Sat, 05 May 2007 01:42:44 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=kA6tznJrVOmeFkpqluui9qaqiDPkODXqQGcZdx2nI/QMTqUfZCRHJJmU7cYS2ayLnUYvdo/0/nyiINwzgw5aveDdRMcIVQjM083yF7bzFBtyuC12Az1w5TOOFXPhcYC71lOpg0tD+i5aK3FfaehAtnw3C6HvS33qyymam93sjGM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ge0Zv1meaF3RuDOQ++p8Xt6L+tIp6Gj2cReq0kgXbpEOFqwDzFUgRMoNM0AQOzbkTKkVNtEQInfH7ejvJcdPPpc3N816Um18cMmh3Km1DYRZfeMi8xNbIc0zQ7/kDQJ/fbzsTUlcXt2ZRqmPsamR2uiRjNNieSbRhZwl9qBu4CI= Original-Received: by 10.67.121.15 with SMTP id y15mr3344978ugm.1178354563930; Sat, 05 May 2007 01:42:43 -0700 (PDT) Original-Received: by 10.67.18.9 with HTTP; Sat, 5 May 2007 01:42:43 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-Google-Sender-Auth: 71370755cd3119c3 X-detected-kernel: Linux 2.4-2.6 (Google crawlbot) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:15690 Archived-At: On 5/5/07, Kim F. Storm wrote: > Per Cederqvist writes: > > > This change in the upcoming Emacs 22 breaks some code: > > > >> 2006-03-22 Kim F. Storm > >> > >> * process.c (Faccept_process_output): Fix to comply with lisp > >> reference. Change arg "timeout" to "seconds" and allow both > >> integer and float value. Change arg "timeout-msec" to "millisec" > >> and interpret" as milliseconds rather than microseconds. Fix doc > >> string accordingly. > > Please see: > > http://lists.gnu.org/archive/html/emacs-devel/2006-03/msg00937.html rms has already installed my patch, so I guess Gnus will have to be fixed. I was not aware that XEmacs used milliseconds. Maybe the documentation should be updated to tell everybody to use floating point instead, as the interpretation of the msec argument varies. > > I enclose a patch that makes accept-process-output > > backwards-compatible with Emacs 21. > > > > One application I'm running now runs very slowly, since its carefully > > tuned timeoutes are multiplied by 1000. > > Well, other code believing the lisp ref, and was broken by the old > behaviour. > > So just reverting the change is no good at this time. If the millisecond interpretation is once again installed, please make the code raise an overflow error if a value larger than 1000 is supplied. This way, code that relies on the old behaviour will not silently be slow, but instead raise an error so that the problem is found and can be fixed. > What application is that? A client to the LysKOM system, called lyskom-elisp-client. Info about the entire system is available from http://www.lysator.liu.se/lyskom/index-en.html, and the client itself can be found in ftp://ftp.lysator.liu.se/pub/lyskom/elisp-client/. > > If, for some reason, my patch is unacceptable, please > > mention this as an incompatible change in the NEWS file. > > This is a good point. > > -- > Kim F. Storm http://www.cua.dk /ceder