From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#48747: add project-name generic Date: Mon, 21 Nov 2022 00:57:33 +0200 Message-ID: <9b4aded1-5dda-25c8-8144-71aa9727353c@yandex.ru> References: <86eedoi0jw.fsf@stephe-leake.org> <86o7t1l18h.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11363"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 To: Stephen Leake , 48747@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 23:58:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owtGX-0002nP-Rq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 23:58:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owtGG-00038o-MC; Sun, 20 Nov 2022 17:58:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owtGE-00038L-VH for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 17:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owtGE-0004x3-NH for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 17:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owtGE-00072B-Bd for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 17:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 22:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48747 X-GNU-PR-Package: emacs Original-Received: via spool by 48747-submit@debbugs.gnu.org id=B48747.166898506427009 (code B ref 48747); Sun, 20 Nov 2022 22:58:02 +0000 Original-Received: (at 48747) by debbugs.gnu.org; 20 Nov 2022 22:57:44 +0000 Original-Received: from localhost ([127.0.0.1]:44868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owtFv-00071Z-TI for submit@debbugs.gnu.org; Sun, 20 Nov 2022 17:57:44 -0500 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:40498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owtFt-00071M-QW for 48747@debbugs.gnu.org; Sun, 20 Nov 2022 17:57:42 -0500 Original-Received: by mail-wr1-f51.google.com with SMTP id x5so13356687wrt.7 for <48747@debbugs.gnu.org>; Sun, 20 Nov 2022 14:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=2OI91YbDx835OwmoHRIqLe4Btlf8bjUPjK+ub6Y0KKU=; b=nBKzFN9h3de0iCmGzNta6B4WN1stJMyZhG+J7Dkkpk3I8hvOYgVHukZj2ZBVQcwn+f uwp8LI9CASr0tswhvrXPOdYYY1COB5x6criuBudwjnKuPDig9EMVqP4MhhhCTF8THD4r 6oTqPN4rxkCJVhJLc1jBxa0KukEamd3WIP1DtJo0TdHn9MLpgbA2/n+rxTs7CpXjmJez GQJ4Ge038AAVnDm5oRv5DULicTIagjmRwQddQu1loaRl5yu6gardrP6GgxUzGHPsL7Ks 0Dwg66imHNntOGqJ35OUKvyheCN6pTWNAihRA+XnqYPgjqvomOqqwkv+mLgP91YDHnJm Tl7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2OI91YbDx835OwmoHRIqLe4Btlf8bjUPjK+ub6Y0KKU=; b=e4lXt6KOnXp5fZE8G6YlIR7vX1MYVk+ev0azYLLtf/mhJwwnD2p7klszPRJum1tWV/ KADC/GWTQQzld9hRWBFS1sVqr32uTPGDI3FUwrHIREOl+A1dpVn48vdIXaguZFgMltqj KG8YxxChzbwGl54umOfqL2MHzFsQHf1scNnkc3CmHgLn0CTAaJqtGmVNeNswmb+U8pGK eoMRcqwIbGvbr6PaSCZ2gFn58JheHlZrse8X+jdYx2Zn6DMosvXwHo8QpQhl7OwFWEMC 0Ri/NEjNO9keoDtVlaPsoJUGMRA8cd2UPbR9PvBTCAkp5AhzElf1mBfv3jrY0ar+Uz/n YhRA== X-Gm-Message-State: ANoB5pnLi91yACkAaWc+JHurtgNHJrefvbp/rZEZq7B57aPViP2HqNRX hnzvjeAZ4jSaHtY8oc67qaWDpJ1zbaQ= X-Google-Smtp-Source: AA0mqf5ZaK1+E3KLpRif4fgit9IB58Iqso/q3sIO2CYHLnWGP406WZ36A6DaReT/Q/VBktJA4IYpvA== X-Received: by 2002:a5d:670c:0:b0:241:6a95:6aa1 with SMTP id o12-20020a5d670c000000b002416a956aa1mr9436192wru.458.1668985055907; Sun, 20 Nov 2022 14:57:35 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p11-20020a05600c468b00b003c65c9a36dfsm12873475wmo.48.2022.11.20.14.57.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 14:57:35 -0800 (PST) Content-Language: en-US In-Reply-To: <86o7t1l18h.fsf@stephe-leake.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248488 Archived-At: On 21.11.2022 00:17, Stephen Leake wrote: > eglot builds a name for a server using the root directory of the > project - in effect: > > (file-name-base (directory-file-name (project-root (project-current)))) > > That name shows up in the elgot mode line, to tell the user which server > the buffer is connected to, in progress report messages, and in the name > of the EGLOT log buffer, which is useful for debugging things. > > If the project root directory happens to have a meaningful name, that's > fine. In my use cases, it's usually not meaningful. For example, I have > two worktrees of my wisitoken project, one for the main branch, one for > a work branch. The eglot names, and the ones I'd like to see, are: > > default desired > "build" "wisitoken main" > "build" "wisitoken work" > > Similarly, the name for the ada_language_server worktree is: > > "gnat" "als main" > > I could override project-name that in my projects to provide my desired > name, and eglot will use my desired name. Okay, that sounds good. But let's please go back to my question: could we use the new generic in project-prompt-project-dir? And should we? If we do, we'll have to default the return value to (abbreviate-file-name (project-root pr)) rather than your suggested (file-name-base (directory-file-name (project-root pr))) . Would you say you intend to override project-name a lot? Or do you want to take advantage of the shorter default name in most cases? What do you think about the first option anyway? OTOH, it's also possible that some Powerline-style mode-line packages might want to use this method as well. And it seems they generally prefer the latter look because it's more compact. They currently don't show such info, though.