From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#28080: 25.2; `outline-invisible-p' should be specific to `invisible' property of `outline.el' Date: Sun, 13 Aug 2017 17:22:48 +0000 (UTC) Message-ID: <9b4a1372-0759-42a5-a5b2-cc131c638c74@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1502645065 3587 195.159.176.226 (13 Aug 2017 17:24:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 Aug 2017 17:24:25 +0000 (UTC) To: 28080@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 13 19:24:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgwcV-0008Ex-2n for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 19:24:11 +0200 Original-Received: from localhost ([::1]:43246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgwcW-0002MC-L4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 13:24:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgwcP-0002LT-Rl for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 13:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgwcM-0006Gy-Ld for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 13:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51485) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgwcM-0006Gn-IV for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 13:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgwcM-00075J-Bb for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Aug 2017 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28080 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150264498827221 (code B ref -1); Sun, 13 Aug 2017 17:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Aug 2017 17:23:08 +0000 Original-Received: from localhost ([127.0.0.1]:60163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgwbU-00074z-0A for submit@debbugs.gnu.org; Sun, 13 Aug 2017 13:23:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgwbR-00074N-MT for submit@debbugs.gnu.org; Sun, 13 Aug 2017 13:23:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgwbL-0005of-Iz for submit@debbugs.gnu.org; Sun, 13 Aug 2017 13:23:00 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgwbL-0005ob-Fv for submit@debbugs.gnu.org; Sun, 13 Aug 2017 13:22:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgwbK-000214-9r for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 13:22:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgwbH-0005nG-30 for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 13:22:58 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:27855) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgwbG-0005mi-Pn for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 13:22:55 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v7DHMqar018961 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 13 Aug 2017 17:22:52 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v7DHMpKq012063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 13 Aug 2017 17:22:52 GMT Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v7DHMnx9030508 for ; Sun, 13 Aug 2017 17:22:51 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6774.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135729 Archived-At: This is the definition of `outline-invisible-p' in `outline.el': (defsubst outline-invisible-p (&optional pos) "Non-nil if the character after POS is invisible. If POS is nil, use `point' instead." (get-char-property (or pos (point)) 'invisible)) That's wrong. Outline should recognize and respect, for its purposes, only the invisibility that it, itself, imposes. Here is a correct definition, AFAICT. My own use of this indicates that it DTRT. In particular, I believe that it handles all of the invisible text that Outline itself imposes, so that `outline.el' loses nothing by using it. (defun outline-invisible-p (&optional pos) "Non-nil if the character after point is invisible for outline purposes." (eq (get-char-property (or pos (point)) 'invisible) 'outline)) (It also should not be a `defsubst'. 1985 has come and gone.) This fix is important for letting `outline.el' play with other code that uses text invisibility for other reasons. For example, I use it with Info mode in a TOC buffer. (That lets you show/hide parts of the TOC, move parts around, etc., while still keeping hidden *Note:: etc.) In GNU Emacs 25.2.1 (x86_64-w64-mingw32) of 2017-04-24 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --without-compress-install 'CFLAGS=3D-O2 -static -g3''