From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48413: 28.0.50; emacs does not repaint the window after switching workspaces in Xmonad Date: Fri, 14 May 2021 17:56:41 +0200 Message-ID: <9b38426b-8e96-0d93-15f7-b915ce3f7d71@gmx.at> References: <4709c228-9735-4f49-b930-3189ca6c0eed@gmx.at> <2b24c14c-02d9-29f2-571b-ef791a20cc2d@gmx.at> <2acc2d8e-3574-56e9-7b2f-8b9d131fdb3d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16705"; mail-complaints-to="usenet@ciao.gmane.io" To: Platon Pronko , 48413@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 14 18:16:54 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhaUf-00049K-47 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 18:16:53 +0200 Original-Received: from localhost ([::1]:50784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhaUe-0003Wg-67 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 12:16:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhaBS-00026V-AP for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 11:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhaBR-0001wq-TG for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 11:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhaBR-0001iK-M7 for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 11:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 May 2021 15:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48413 X-GNU-PR-Package: emacs Original-Received: via spool by 48413-submit@debbugs.gnu.org id=B48413.16210078156575 (code B ref 48413); Fri, 14 May 2021 15:57:01 +0000 Original-Received: (at 48413) by debbugs.gnu.org; 14 May 2021 15:56:55 +0000 Original-Received: from localhost ([127.0.0.1]:46833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhaBL-0001hz-6o for submit@debbugs.gnu.org; Fri, 14 May 2021 11:56:55 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:45439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhaBF-0001hg-51 for 48413@debbugs.gnu.org; Fri, 14 May 2021 11:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621007802; bh=+Bsh3d7x854cxYEBZ2wSq2qF736RU/Kk2GxDRQVlykY=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=kreXe8CCi1yk7YOtZQYGE1Ta2G7+GT29jHrdV9DrincvXsn2mLLLra93d2NvgzruT rE/RyCnYVx8M99BkCsh3oUJDuvrtsPGKDCkc+b2l1coUremae7lMr2rarYrMSUXkKS i9v70XRn5/dSJUCWp4In9BWnOMKZbjHCooNj3jiQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.218]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MV67y-1m6Qqi1cms-00S8Kj; Fri, 14 May 2021 17:56:42 +0200 In-Reply-To: <2acc2d8e-3574-56e9-7b2f-8b9d131fdb3d@gmail.com> Content-Language: en-US X-Provags-ID: V03:K1:FlHXZgKm8H8t3WsYvED5y6b4uLTDeXQaPxNODDXZC3xZTmXD8lV 9JIcl1VRvBzLj4Gza/ms8srFO46xi4p0i4+r6xSoH+/miT+7Wxla3U6KEba9IgGK4tpB5Gl 3TaWWJr1qRtGI+r0d1w6E2bQzErtRuQpG7BsQqpjCN5fvKLJQxiBSylBv6H9o6wuwqTfPZO huEZU7+RhrYykm8+klDDg== X-UI-Out-Filterresults: notjunk:1;V03:K0:/ebB0HAdf9g=:U/zkaLhMETJlHxOLKCjUcO mEJEy/d0q7OkHRWRbimKQMRQTqJEd4PouivPUtOVClH4d67LIdeO/aeQ/Fk/804Ys7q5qxw+8 DvQGCSKRMI/u4ePNzkHjsVr35D11lPBnwXsNk9VohYTJWiEfmz6M197wthDlWTV5R8rOh4nSE +yWa4VkL31kgdlcZJ7Er4VMmMz6QkxUmt9K+T3h2+NrZ19Enc7c/puB2I0C5feBO1CJq/pgfJ BUf3nFGvgphiyuY3mKUhbEKfJ6A8zGmyDPeDnaP+Kw14poaLtBTBcx4JgfltcrkUiMvC9XBNA fOLdc/9t59MUnAyI3xTY8w5Y7h2jOEQHAA8t8lJCBLkjmNwYhYCbN1siI8rfqNc+yLNxeOK8N DYL9tIlotQ6THTdEqs6rlSCEJR6T3P2AFWlkz4tS0zYE9MTCKcDAp3AfNKyCcv9NG9e4NaJSR 25fRJj8XYo/NiLswIlFWT5aliSlG6B0I6JTq3A4Gi9WL6rH4ewJ8xQUysfs4jIWTwEaiu+DeT RKaspgHfRhqXnJZskco7YpOS7j2iSFkv+U68aK++fakQezcP4I9lHIMBCS5oEs/vkN1O05Ogn +fRzDlEbNNGPuyyodzHSdgSXJx397G8Z/0OkY+3f2V5g61VhxVsia4CCqL+rBWWj2WwUae9vw mzMDIqJFmFz1ry9DfhMM1kBkjbebFG49pkm6DXeiVATQhu0itKRw9PEvtmu1Igs2BoZgYeHfW c6NyotqHsLLpuFNCPmuc6aM7CQ96WoIeExqYXRmWt5kD0fT/C6RERe1abm4xqc8D1s8zq2bT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206534 Archived-At: >> Can you please try the attached patch and tell me whether it improves or >> breaks things. > > Yes, it fixes things - frame is repainted correctly now. > > My attempt was similar, but I included more code alongside SET_FRAME_VISIBLE (same as in Expose handler): > > + block_input (); > + SET_FRAME_VISIBLE (f, 1); > + if (FRAME_X_DOUBLE_BUFFERED_P (f)) > + font_drop_xrender_surfaces (f); > + f->output_data.x->has_been_visible = true; > + SET_FRAME_GARBAGED (f); > + unblock_input (); > > I'm not very familiar with Emacs frame internals - we don't need all these here? If I only knew. If you come up with a patch that works OK for you and does not break the (defvar frame (make-frame)) (make-frame-invisible frame) (frame-visible-p frame) scenario (where the latter returns 'icon) I want to fix here, I'll happily install that. >> Relying on these for setting visibility will fail for anyone who doesn't >> send us an Expose event. > > I agree, feels a little fragile. It apparently has not bitten us so far but the Xlib manual is not very clear in this regard. martin