From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tim Ruffing Newsgroups: gmane.emacs.bugs Subject: bug#46022: 27.1; kill-emacs should call sd_notify only in daemon mode Date: Fri, 22 Jan 2021 13:07:35 +0100 Message-ID: <9b08abb671a740a3eb77fef53bb89f24695bf69b.camel@timruffing.de> References: <1795381c3a29a50341502c2c020dccfcddf4be05.camel@timruffing.de> <837do66qcw.fsf@gnu.org> <6b2b3e7c-b8d0-7386-9ecb-fc3aabe262aa@lucaswerkmeister.de> <83lfcl5qoz.fsf@gnu.org> <6b98486b-a5ff-72fd-5c9b-fe90858790ee@lucaswerkmeister.de> <83k0s55h5a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20659"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46022@debbugs.gnu.org To: Eli Zaretskii , Lucas Werkmeister Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 22 13:08:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2vFK-0005DX-Se for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jan 2021 13:08:58 +0100 Original-Received: from localhost ([::1]:46876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2vFJ-0008RG-Kf for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jan 2021 07:08:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2vER-0008MJ-IK for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 07:08:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2vEQ-0001v3-Ed for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 07:08:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2vEQ-00077V-8q for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 07:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tim Ruffing Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jan 2021 12:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46022 X-GNU-PR-Package: emacs Original-Received: via spool by 46022-submit@debbugs.gnu.org id=B46022.161131726827345 (code B ref 46022); Fri, 22 Jan 2021 12:08:02 +0000 Original-Received: (at 46022) by debbugs.gnu.org; 22 Jan 2021 12:07:48 +0000 Original-Received: from localhost ([127.0.0.1]:60114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2vEC-00076x-8s for submit@debbugs.gnu.org; Fri, 22 Jan 2021 07:07:48 -0500 Original-Received: from mout-p-102.mailbox.org ([80.241.56.152]:39540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2vEA-00076k-5T for 46022@debbugs.gnu.org; Fri, 22 Jan 2021 07:07:47 -0500 Original-Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4DMdLN0cTkzQlXl; Fri, 22 Jan 2021 13:07:40 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1611317258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ljr1WVHBLsz6tJFMjPTl5XB6hRekdXdja/ZmYvoejZQ=; b=qnX7g+17/kDwNKjl/Q7n1APbgLietMucMlgYsKt3YQoL5yvEJ1fcetKYkuQsGt876wkgMR NzvOD5RhbBW1RiaoiqoKmwWkR4sFBQ86XK9tkR+/cCcuwj3OlJGQWH9acEB5tDxT/JWblY qa2FmziAZ1T2SN24/E0P67ow2DXwCHKn6fi0JP0pPd39vs0UH9KF4Gr2RwgN4RR3lQBVwK 7O+xXvNhogkQbceESB8mELj361EsIugpkLPtyCFMwz3tCe8mRanMCRkw/GURK/hLn0LFYB zOkdOsr7nygcQndtulGNOimwkGTHYuTfbcf6uIpORuJw8pIJVrjoCKD3rvblbA== Original-Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id Bx1oKPm7BZEm; Fri, 22 Jan 2021 13:07:36 +0100 (CET) In-Reply-To: <83k0s55h5a.fsf@gnu.org> X-Rspamd-Score: -6.00 / 15.00 / 15.00 X-Rspamd-Queue-Id: 1794C17DF X-Rspamd-UID: 527e01 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198367 Archived-At: I tested the patch and I can conform that it works and makes the warnings disappear.  Thanks for the quick response! Tim On Fri, 2021-01-22 at 13:45 +0200, Eli Zaretskii wrote: > > Cc: public@timruffing.de, 46022@debbugs.gnu.org > > From: Lucas Werkmeister > > Date: Fri, 22 Jan 2021 10:47:49 +0100 > > > > > -  daemon_type = -1; > > > +  daemon_type = -daemon_type; > > >   > > >  #else  /* WINDOWSNT */ > > >    /* Signal the waiting emacsclient process.  */ > > > > > > > That looks good to me. If daemon_type is 0, it will now stay at 0 > > instead of being marked as invalid, but that should be okay, since > > daemon-initialized has no special code for daemon_type == 0. > > Right. > > Tim, does this work for you?  Can you perhaps test this on your > system?