From: Dmitry Gutov <dmitry@gutov.dev>
To: Randy Taylor <dev@rjt.dev>
Cc: casouri@gmail.com, Eli Zaretskii <eliz@gnu.org>,
63086@debbugs.gnu.org, Jimmy Wong <wyuenho@gmail.com>
Subject: bug#63086: 29.0.90; go-ts-mode treesit-query-error during jit-lock
Date: Fri, 28 Apr 2023 13:05:51 +0300 [thread overview]
Message-ID: <9b01dbad-e337-a23c-2341-2a0ca89792dc@gutov.dev> (raw)
In-Reply-To: <sVaonIb2lJW_pzqyzMFotzskDTn4CzwC1xedRlRJfij5nRGpUTAKBHfQPWGATyHuETa4CTfFPOsyEbA7JgGlB4ZmKe_GvxCmmX2t1-ryMMI=@rjt.dev>
On 28/04/2023 04:35, Randy Taylor wrote:
> Maybe I'm missing something, but doesn't treesit-query-string with an empty string do nothing and always error, since it queries on whatever string you pass in?
It would return nil, not error (querying an empty buffer). And we should
be checking for error.
This is the part that java-ts-mode--string-highlight-helper got right, BTW.
go-ts-mode--iota-query-supported-p in your patch relies on the condition
that the file, at the time the mode is enabled, already contains at
least one "iota" node.
> In that case, wouldn't using treesit-query-capture directly be the best? I don't understand why it's not from reading that thread. If it isn't, then treesit-query-validate is the only option, right?
treesit-query-validate pops a new buffer interactively in the case of
failure, so it's not something we should use here.
next prev parent reply other threads:[~2023-04-28 10:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 10:00 bug#63086: 29.0.90; go-ts-mode treesit-query-error during jit-lock Jimmy Yuen Ho Wong
2023-04-26 10:36 ` Eli Zaretskii
2023-04-26 11:07 ` Jimmy Wong
2023-04-26 12:38 ` Randy Taylor
2023-04-26 13:26 ` Jimmy Wong
2023-04-26 13:38 ` Eli Zaretskii
2023-04-26 13:44 ` Jimmy Wong
2023-04-26 14:05 ` Randy Taylor
2023-04-26 15:40 ` Randy Taylor
2023-04-27 6:36 ` Jimmy Wong
2023-04-28 0:16 ` Dmitry Gutov
2023-04-28 1:35 ` Randy Taylor
2023-04-28 10:05 ` Dmitry Gutov [this message]
2023-05-02 0:29 ` Randy Taylor
2023-05-03 21:58 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b01dbad-e337-a23c-2341-2a0ca89792dc@gutov.dev \
--to=dmitry@gutov.dev \
--cc=63086@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=wyuenho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).